Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp505479ybl; Wed, 11 Dec 2019 23:35:37 -0800 (PST) X-Google-Smtp-Source: APXvYqwzxzbcDEX//HoW6DzEk6tV65I7bDOVpnTOiUEs6JLjVdiUzZS5B5G3GxiOcUJ51FUhoJWf X-Received: by 2002:a9d:d0b:: with SMTP id 11mr6855847oti.287.1576136137207; Wed, 11 Dec 2019 23:35:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576136137; cv=none; d=google.com; s=arc-20160816; b=nOpWXnUSoS6U5ScD/R4jC4x+5HlnYoJtARzWPRKzEr3jsJHwNRoT9wBDX0aHBZz91N Vp3KAxC3F+0Zk7ENysz+n0yFK1oSPtTH5FErzTM7keC8VhPmqiw6lLa2+r72XrwAtT8l bR1fUyTGPxcnb5z8g0J1d1IuZqz7eH/xfNQyzkr3QrF5zLw0pFZHa7qwdo8wKaBaBlsT HPUL4MuFQiR526+EyNlbdH7eapSqar1aI1Yt+T52OocB80Rzp/FGZLT4MfcdM7KkZjHZ ghWHqdNP28oL4sYRds6vd5CNvf1tPnZYfsu0PowTOKG4julUqLjJIhA7eelw+Icym+PB 9LWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :dkim-signature; bh=QcotRZOg8cVYsqL5GLsgP8ixI9kdR95Q2W4XEWIcwA4=; b=IB8UwhdO7ShWiHbHHnCc385/k4mfi/lZtAhzFVFYQRL5aWXiXJP8umvoZqWrdN3ugI fghAjlo8U5E4Q80AzD8XHKf9CfcGnE+dPP7vFzJPP0Q0xXTa5z5eomvy7N3gOHfrMQF7 ddcmoS9uKQb9NtRZzSKnSiyHWqdQv4wSLy0M9of5tdb92Bqie1UYVSfhFkjB5g5z4PRP 35T3aeGe8SyktIupuPZ+SO4MDvBPqn6tAZHKgrwHEGq9+8H4F7u3YUoh634zdMZJ6HHI gAnF6auccgqoyrJcmZpEzexYkVKBNFB+Bwrh0QkNmX/r3g6RP3NP4CKBlacYpi9xmcE6 D41w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FadP9GPE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 19si2737411oiq.128.2019.12.11.23.35.24; Wed, 11 Dec 2019 23:35:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FadP9GPE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728133AbfLLHeg (ORCPT + 99 others); Thu, 12 Dec 2019 02:34:36 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:21756 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728151AbfLLHee (ORCPT ); Thu, 12 Dec 2019 02:34:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576136073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QcotRZOg8cVYsqL5GLsgP8ixI9kdR95Q2W4XEWIcwA4=; b=FadP9GPEhm/EYxZySOIyhBMHnzfufJdHIvS3nCljWZx0aRefR+lkR8RJBm5HJeuAnbFAaE sDIN4EbymvXShHzznUHwie194Y1F8mb8z92EfciYmTrmsbLS1wSPiyC8+f0Wsa1Zq5lbCX H/rkFiFRtLLpimqXc+ho/C7mDz8qFDA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-10-4Wt3wXf3P0GGIDpB7LgN2g-1; Thu, 12 Dec 2019 02:34:30 -0500 X-MC-Unique: 4Wt3wXf3P0GGIDpB7LgN2g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 148EB107ACC7; Thu, 12 Dec 2019 07:34:28 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-52.rdu2.redhat.com [10.10.120.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1352D6013D; Thu, 12 Dec 2019 07:34:25 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <157558502272.10278.8718685637610645781.stgit@warthog.procyon.org.uk> <20191206135604.GB2734@twin.jikos.cz> <9417.1576097731@warthog.procyon.org.uk> To: Linus Torvalds Cc: dhowells@redhat.com, David Sterba , Eric Biggers , Al Viro , linux-fsdevel , Linux Kernel Mailing List , Peter Zijlstra , Ingo Molnar , Vincent Guittot Subject: Re: [PATCH 0/2] pipe: Fixes [ver #2] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1416.1576136065.1@warthog.procyon.org.uk> Date: Thu, 12 Dec 2019 07:34:25 +0000 Message-ID: <1417.1576136065@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds wrote: > You are sure you won't want that for the notification queue cases? I > guess they'll never want to "sync" part.. Actually, that's a good point, I do call it in post_one_notification() since I have to hold the lock anyway. But, as you say, I'm not sure whether I need the sync variant. David