Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp588392ybl; Thu, 12 Dec 2019 01:25:29 -0800 (PST) X-Google-Smtp-Source: APXvYqzE4AOpsUIQUgXpFD31edgPo+wa6cRwBjVUUvVIU4OZ8n3TrTSB5OXCTncOuAzb1Qx2r0dZ X-Received: by 2002:a9d:24c1:: with SMTP id z59mr6928816ota.207.1576142729076; Thu, 12 Dec 2019 01:25:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576142729; cv=none; d=google.com; s=arc-20160816; b=DVT7XSDM0fNgfOWP/7fXrsxHwSkl5fIvk8sbjyMXNAYiXe+qoIjEBHC4cEZAlt9a29 lSdTlXHtvj+sDXWeztqSL58LgqnS+hELi2eCVsRNx8PeTxZR2E5Cajzuby2FQ2cwvM06 UcTT/YBGhUQbCv4KGHAwVCDDyftcETfjGkrHhKXtzF2Chw6YnhB8FLNGD/swHtHX65zf X317+yigmxe3JBUcV2OaJk1rz4RzNbyPsAls140VNdbVEFG294ydOlgvKvuXMyfkJTeY kJBTVX1it+1pPiaM788aomzcXYeTY+2LADWAk+7S1IBKZBobewZTLH6jEhM7MS+hSFhz b+PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=B8TAZhPw7pidVrYJVxqGLhjQJJJphJhADnYCyWPQRCc=; b=YdXrwE5aY7ixwkPayxE8CbQxJPX2WBUmXGHSOsK9dAYxntOixDDZBhNM31OXcPXWmG hR4N/U1e5bVOrvdWrvKdzRS68REaaY1vY8AS43edNIfSgqU7Pw9HyjQFwMwv7BkXCdIt 0eAIq8XB/jc0OlO95/pteWj6QYW4qu7NZB+5Ae8xZRtbZ81y/MOME4YKtz2IN1YgrPy0 GTkjJtDlMeUhw7ZTKJ0v9Pv5/1+yE2V8o5RUkTzn8HO4rvxHLV8O7aWhYmRtxjh6eWrG Y6moSvbxgv6QGIuso5jHD654WWKs/G+pN8s9bFx3UpZhxJ9SJgbqlLlIFlQ+MzDB08ml uJ8A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h18si3072546otj.114.2019.12.12.01.25.16; Thu, 12 Dec 2019 01:25:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728302AbfLLJYg (ORCPT + 99 others); Thu, 12 Dec 2019 04:24:36 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:7675 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726382AbfLLJYg (ORCPT ); Thu, 12 Dec 2019 04:24:36 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 25B33D606BB1D6A3F7AF; Thu, 12 Dec 2019 17:24:34 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.439.0; Thu, 12 Dec 2019 17:24:23 +0800 From: Chen Zhou To: , , CC: , , , Hulk Robot Subject: [PATCH -next] pinctrl: samsung: fix build error without CONFIG_OF_GPIO Date: Thu, 12 Dec 2019 17:21:36 +0800 Message-ID: <20191212092136.37870-1-chenzhou10@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If CONFIG_OF_GPIO is n, build fails: drivers/pinctrl/samsung/pinctrl-samsung.c: In function samsung_gpiolib_register: drivers/pinctrl/samsung/pinctrl-samsung.c:969:5: error: struct gpio_chip has no member named of_node gc->of_node = bank->of_node; Use #ifdef to guard this. Reported-by: Hulk Robot Fixes Signed-off-by: Chen Zhou --- drivers/pinctrl/samsung/pinctrl-samsung.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c index f26574e..5c29ad8 100644 --- a/drivers/pinctrl/samsung/pinctrl-samsung.c +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c @@ -966,7 +966,9 @@ static int samsung_gpiolib_register(struct platform_device *pdev, gc->base = bank->grange.base; gc->ngpio = bank->nr_pins; gc->parent = &pdev->dev; +#ifdef CONFIG_OF_GPIO gc->of_node = bank->of_node; +#endif gc->label = bank->name; ret = devm_gpiochip_add_data(&pdev->dev, gc, bank); -- 2.7.4