Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Alison Wang <alison.wang@nxp.com>
To:     Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
CC:     Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Igor Opaniuk <igor.opaniuk@toradex.com>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH] ASoC: sgtl5000: Revert "ASoC: sgtl5000: Fix of
 unmute outputs on probe"
Thread-Topic: [EXT] Re: [PATCH] ASoC: sgtl5000: Revert "ASoC: sgtl5000: Fix of
 unmute outputs on probe"
Thread-Index: AQHVsLyIRDFbzLs7vEuxsFkXl6DgTKe2NokAgAAA1bA=
Date:   Thu, 12 Dec 2019 09:24:42 +0000
Message-ID: <VI1PR04MB40627CDD5F0C17D8DCDCFFE2F4550@VI1PR04MB4062.eurprd04.prod.outlook.com>
References: <20191212071847.45561-1-alison.wang@nxp.com>
 <CAGgjyvHHzPWjRTqxYmGCmk3qa6=kOezHywVDFomgD6UNj-zwpQ@mail.gmail.com>
In-Reply-To: <CAGgjyvHHzPWjRTqxYmGCmk3qa6=kOezHywVDFomgD6UNj-zwpQ@mail.gmail.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: multipart/mixed;
        boundary="_002_VI1PR04MB40627CDD5F0C17D8DCDCFFE2F4550VI1PR04MB4062eurp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: deb4047d-c061-4012-8145-08d77ee51ece
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2019 09:24:42.4585
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hAljXWXyS55kxv/YzmM98XJi95yy2ZxI9v0mfY4apkwFWbYt3CM2xgDiTyBccVyS1qWPcs77C1vG6aohZbHq3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5935
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--_002_VI1PR04MB40627CDD5F0C17D8DCDCFFE2F4550VI1PR04MB4062eurp_
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

SGksIE9sZWtzYW5kciwNCg0KSSB0aGluayBJIGhhdmUgZXhwbGFpbmVkIHRoZSByZWFzb24gaW4g
bXkgZW1haWwgd2hpY2ggc2VudCB0byB5b3UgeWVzdGVyZGF5LiBJIGF0dGFjaGVkIGl0IHRvby4N
CkFjY29yZGluZyB0byBteSB0ZXN0IG9uIHRoZSBib2FyZHMsIE1VVEVfTE8sIE1VVEVfSFAgYW5k
IE1VVEVfQURDIGFyZSBhbGwgbXV0ZWQgd2hlbg0KcGxheWluZyB0aGUgc291bmQuDQoNCkNvdWxk
IHlvdSBnaXZlIG1lIHNvbWUgaWRlYXMgYWJvdXQgdGhpcyBpc3N1ZT8NCg0KDQpCZXN0IFJlZ2Fy
ZHMsSSANCkFsaXNvbiBXYW5nDQoNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBG
cm9tOiBPbGVrc2FuZHIgU3V2b3JvdiA8b2xla3NhbmRyLnN1dm9yb3ZAdG9yYWRleC5jb20+DQo+
IFNlbnQ6IFRodXJzZGF5LCBEZWNlbWJlciAxMiwgMjAxOSA1OjExIFBNDQo+IFRvOiBBbGlzb24g
V2FuZyA8YWxpc29uLndhbmdAbnhwLmNvbT4NCj4gQ2M6IE1hcmNlbCBaaXN3aWxlciA8bWFyY2Vs
Lnppc3dpbGVyQHRvcmFkZXguY29tPjsgSWdvciBPcGFuaXVrDQo+IDxpZ29yLm9wYW5pdWtAdG9y
YWRleC5jb20+OyBmZXN0ZXZhbUBnbWFpbC5jb207IGJyb29uaWVAa2VybmVsLm9yZzsNCj4gbGdp
cmR3b29kQGdtYWlsLmNvbTsgT2xla3NhbmRyIFN1dm9yb3YgPG9sZWtzYW5kci5zdXZvcm92QHRv
cmFkZXguY29tPjsNCj4gYWxzYS1kZXZlbEBhbHNhLXByb2plY3Qub3JnOyBsaW51eC1rZXJuZWxA
dmdlci5rZXJuZWwub3JnDQo+IFN1YmplY3Q6IFtFWFRdIFJlOiBbUEFUQ0hdIEFTb0M6IHNndGw1
MDAwOiBSZXZlcnQgIkFTb0M6IHNndGw1MDAwOiBGaXggb2YNCj4gdW5tdXRlIG91dHB1dHMgb24g
cHJvYmUiDQo+IA0KPiBDYXV0aW9uOiBFWFQgRW1haWwNCj4gDQo+IEFsaXNvbiwgY291bGQgeW91
IHBsZWFzZSBleHBsYWluLCB3aGF0IHJlYXNvbiB0byByZXZlcnQgdGhpcyBmaXg/IEFsbCB0aGVz
ZSBibG9ja3MNCj4gaGF2ZSB0aGVpciBvd24gY29udHJvbCBhbmQgdW5tdXRlIG9uIGRlbWFuZC4N
Cj4gV2h5IGRvIHlvdSBzdGFuZCBvbiB1bmNvbmRpdGlvbmFsIHVubXV0aW5nIG9mIG91dHB1dHMg
YW5kIEFEQyBvbiBkcml2ZXINCj4gcHJvYmluZz8NCj4gDQo+IE9uIFRodSwgRGVjIDEyLCAyMDE5
IGF0IDk6MjAgQU0gQWxpc29uIFdhbmcgPGFsaXNvbi53YW5nQG54cC5jb20+DQo+IHdyb3RlOg0K
PiA+DQo+ID4gVGhpcyByZXZlcnRzIGNvbW1pdCA2MzFiYzhmMDEzNGFlOTYyMGQ4NmE5NmI4YzVm
OTQ0NWQ5MWEyZGNhLg0KPiA+DQo+ID4gSW4gY29tbWl0IDYzMWJjOGYwMTM0YSwgc25kX3NvY19j
b21wb25lbnRfdXBkYXRlX2JpdHMgaXMgdXNlZCBpbnN0ZWFkDQo+ID4gb2Ygc25kX3NvY19jb21w
b25lbnRfd3JpdGUuIEFsdGhvdWdoIEVOX0hQX1pDRCBhbmQgRU5fQURDX1pDRCBhcmUNCj4gPiBl
bmFibGVkIGluIEFOQV9DVFJMIHJlZ2lzdGVyLCBNVVRFX0xPLCBNVVRFX0hQIGFuZCBNVVRFX0FE
QyBiaXRzIGFyZQ0KPiA+IHJlbWFpbmVkIGFzIHRoZSBkZWZhdWx0IHZhbHVlLiBJdCBjYXVzZXMg
TE8sIEhQIGFuZCBBREMgYXJlIGFsbCBtdXRlZA0KPiA+IGFmdGVyIGRyaXZlciBwcm9iZS4NCj4g
Pg0KPiA+IFRoZSBwYXRjaCBpcyB0byByZXZlcnQgdGhpcyBjb21taXQsIHNuZF9zb2NfY29tcG9u
ZW50X3dyaXRlIGlzIHN0aWxsDQo+ID4gdXNlZCBhbmQgTVVURV9MTywgTVVURV9IUCBhbmQgTVVU
RV9BREMgYXJlIHNldCBhcyB6ZXJvICh1bm11dGVkKS4NCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6
IEFsaXNvbiBXYW5nIDxhbGlzb24ud2FuZ0BueHAuY29tPg0KPiA+IC0tLQ0KPiA+ICBzb3VuZC9z
b2MvY29kZWNzL3NndGw1MDAwLmMgfCA2ICsrKy0tLQ0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMyBp
bnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL3NvdW5k
L3NvYy9jb2RlY3Mvc2d0bDUwMDAuYyBiL3NvdW5kL3NvYy9jb2RlY3Mvc2d0bDUwMDAuYw0KPiA+
IGluZGV4IGFhMWY5NjMuLjBiMzVmY2EgMTAwNjQ0DQo+ID4gLS0tIGEvc291bmQvc29jL2NvZGVj
cy9zZ3RsNTAwMC5jDQo+ID4gKysrIGIvc291bmQvc29jL2NvZGVjcy9zZ3RsNTAwMC5jDQo+ID4g
QEAgLTE0NTgsNyArMTQ1OCw2IEBAIHN0YXRpYyBpbnQgc2d0bDUwMDBfcHJvYmUoc3RydWN0DQo+
IHNuZF9zb2NfY29tcG9uZW50ICpjb21wb25lbnQpDQo+ID4gICAgICAgICBpbnQgcmV0Ow0KPiA+
ICAgICAgICAgdTE2IHJlZzsNCj4gPiAgICAgICAgIHN0cnVjdCBzZ3RsNTAwMF9wcml2ICpzZ3Rs
NTAwMCA9DQo+IHNuZF9zb2NfY29tcG9uZW50X2dldF9kcnZkYXRhKGNvbXBvbmVudCk7DQo+ID4g
LSAgICAgICB1bnNpZ25lZCBpbnQgemNkX21hc2sgPSBTR1RMNTAwMF9IUF9aQ0RfRU4gfA0KPiBT
R1RMNTAwMF9BRENfWkNEX0VOOw0KPiA+DQo+ID4gICAgICAgICAvKiBwb3dlciB1cCBzZ3RsNTAw
MCAqLw0KPiA+ICAgICAgICAgcmV0ID0gc2d0bDUwMDBfc2V0X3Bvd2VyX3JlZ3MoY29tcG9uZW50
KTsNCj4gPiBAQCAtMTQ4Niw4ICsxNDg1LDkgQEAgc3RhdGljIGludCBzZ3RsNTAwMF9wcm9iZShz
dHJ1Y3QNCj4gc25kX3NvY19jb21wb25lbnQgKmNvbXBvbmVudCkNCj4gPiAgICAgICAgICAgICAg
ICAweDFmKTsNCj4gPiAgICAgICAgIHNuZF9zb2NfY29tcG9uZW50X3dyaXRlKGNvbXBvbmVudCwN
Cj4gU0dUTDUwMDBfQ0hJUF9QQURfU1RSRU5HVEgsDQo+ID4gcmVnKTsNCj4gPg0KPiA+IC0gICAg
ICAgc25kX3NvY19jb21wb25lbnRfdXBkYXRlX2JpdHMoY29tcG9uZW50LA0KPiBTR1RMNTAwMF9D
SElQX0FOQV9DVFJMLA0KPiA+IC0gICAgICAgICAgICAgICB6Y2RfbWFzaywgemNkX21hc2spOw0K
PiA+ICsgICAgICAgc25kX3NvY19jb21wb25lbnRfd3JpdGUoY29tcG9uZW50LA0KPiBTR1RMNTAw
MF9DSElQX0FOQV9DVFJMLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIFNHVEw1MDAwX0hQ
X1pDRF9FTiB8DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgU0dUTDUwMDBfQURDX1pDRF9F
Tik7DQo+ID4NCj4gPiAgICAgICAgIHNuZF9zb2NfY29tcG9uZW50X3VwZGF0ZV9iaXRzKGNvbXBv
bmVudCwNCj4gU0dUTDUwMDBfQ0hJUF9NSUNfQ1RSTCwNCj4gPiAgICAgICAgICAgICAgICAgICAg
ICAgICBTR1RMNTAwMF9CSUFTX1JfTUFTSywNCj4gPiAtLQ0KPiA+IDIuOS41DQo+ID4NCj4gDQo+
IA0KPiAtLQ0KPiBCZXN0IHJlZ2FyZHMNCj4gT2xla3NhbmRyIFN1dm9yb3YNCj4gDQo+IFRvcmFk
ZXggQUcNCj4gQWx0c2FnZW5zdHJhc3NlIDUgfCA2MDQ4IEhvcncvTHV6ZXJuIHwgU3dpdHplcmxh
bmQgfCBUOiArNDEgNDEgNTAwDQo+IDQ4MDAgKG1haW4gbGluZSkNCg==

--_002_VI1PR04MB40627CDD5F0C17D8DCDCFFE2F4550VI1PR04MB4062eurp_
Content-Type: message/rfc822
Content-Disposition: attachment;
	creation-date="Thu, 12 Dec 2019 09:24:39 GMT";
	modification-date="Thu, 12 Dec 2019 09:24:39 GMT"

From: Alison Wang <alison.wang@nxp.com>
To: "oleksandr.suvorov@toradex.com" <oleksandr.suvorov@toradex.com>, Marcel
 Ziswiler <marcel.ziswiler@toradex.com>, "igor.opaniuk@toradex.com"
	<igor.opaniuk@toradex.com>, Fabio Estevam <festevam@gmail.com>,
	"broonie@kernel.org" <broonie@kernel.org>, "lgirdwood@gmail.com"
	<lgirdwood@gmail.com>
CC: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: RE: [v6,5/6] ASoC: sgtl5000: Fix of unmute outputs on probe
Thread-Topic: [v6,5/6] ASoC: sgtl5000: Fix of unmute outputs on probe
Thread-Index: AdWv8c/6ILgEMkLmRYinQyj4db74kQAAAgFQ
Date: Wed, 11 Dec 2019 07:59:23 +0000
Message-ID:
 <VI1PR04MB4062BD2BB10ADE4EB0DF9C37F45A0@VI1PR04MB4062.eurprd04.prod.outlook.com>
References:
 <VI1PR04MB4062948CF9A3C420C6345A7DF45A0@VI1PR04MB4062.eurprd04.prod.outlook.com>
In-Reply-To:
 <VI1PR04MB4062948CF9A3C420C6345A7DF45A0@VI1PR04MB4062.eurprd04.prod.outlook.com>
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
X-MS-Exchange-Organization-RecordReviewCfmType: 0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Hi, Oleksandr,

I have a question about this patch. Could you give me some ideas? Thanks.

In this patch, snd_soc_component_update_bits is used instead of snd_soc_com=
ponent_write. Although EN_HP_ZCD and EN_ADC_ZCD are enabled in ANA_CTRL reg=
ister, MUTE_LO, MUTE_HP and MUTE_ADC bits are remained as the default value=
. It causes LO, HP and ADC are all muted after driver probe. BTW, in the or=
iginal code, snd_soc_component_write is used and MUTE_LO, MUTE_HP and MUTE_=
ADC are all set as zero (unmute).

I saw the above phenomenon on the latest linux-next. For LO and HP are mute=
d, no sound can be heard.


Best Regards,
Alison Wang

> Subject: [v6,5/6] ASoC: sgtl5000: Fix of unmute outputs on probe
>=20
> To enable "zero cross detect" for ADC/HP, change HP_ZCD_EN/ADC_ZCD_EN
> bits only instead of writing the whole CHIP_ANA_CTRL register.
>=20
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Reviewed-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>=20
> ---
>=20
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2:
> - Fix patch formatting
>=20
>  sound/soc/codecs/sgtl5000.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
>=20
> diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c in=
dex
> b65232521ea8..23f4ae2f0723 100644
> --- a/sound/soc/codecs/sgtl5000.c
> +++ b/sound/soc/codecs/sgtl5000.c
> @@ -1453,6 +1453,7 @@  static int sgtl5000_probe(struct
> snd_soc_component *component)
>  	int ret;
>  	u16 reg;
>  	struct sgtl5000_priv *sgtl5000 =3D
> snd_soc_component_get_drvdata(component);
> +	unsigned int zcd_mask =3D SGTL5000_HP_ZCD_EN |
> SGTL5000_ADC_ZCD_EN;
>=20
>  	/* power up sgtl5000 */
>  	ret =3D sgtl5000_set_power_regs(component);
> @@ -1480,9 +1481,8 @@  static int sgtl5000_probe(struct
> snd_soc_component *component)
>  	       0x1f);
>  	snd_soc_component_write(component, SGTL5000_CHIP_PAD_STRENGTH,
> reg);
>=20
> -	snd_soc_component_write(component, SGTL5000_CHIP_ANA_CTRL,
> -			SGTL5000_HP_ZCD_EN |
> -			SGTL5000_ADC_ZCD_EN);
> +	snd_soc_component_update_bits(component,
> SGTL5000_CHIP_ANA_CTRL,
> +		zcd_mask, zcd_mask);
>=20
>  	snd_soc_component_update_bits(component,
> SGTL5000_CHIP_MIC_CTRL,
>  			SGTL5000_BIAS_R_MASK,
>=20


--_002_VI1PR04MB40627CDD5F0C17D8DCDCFFE2F4550VI1PR04MB4062eurp_--