Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp592984ybl; Thu, 12 Dec 2019 01:31:07 -0800 (PST) X-Google-Smtp-Source: APXvYqz0VmbEMze3A9PLnfMwXBcaL7T9dhm5oea3ZKFyNKFX53/ZFjwWgNH0cKWbEvqgAWOrE+RA X-Received: by 2002:a05:6830:2306:: with SMTP id u6mr7506088ote.78.1576143067392; Thu, 12 Dec 2019 01:31:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576143067; cv=none; d=google.com; s=arc-20160816; b=w1vzRV1M+YVGDVmoA9/6JMq12sp3rAOInQ12NDhUjZTt/wQ3I7cZUq0So+zIag1k9c V/Dw8WkIGvKZwRvr35FY5rW4AwSvbc9TAelAOXUmr5YM0o0xlWMdoLHpSRLCx7tEay3J JKJJDkCGVR+7sh6On7tz962FFIa8z4My6mb4Uk3tabFYZfyY8ccqolOHiSDpSJUsEorv IN2IENMuMdLcjsgoJlEVbplz4acIPDRjMZWSQxleAAme3hYYYogcihHSHmJsKck24CYS shhI9XiW0Q7t/ciZzYNM32/APiAtq7YiXHXqZb1Xcui/JVabTtjeK1Kxd5OyZcy6k145 9zIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=JR3dXTA1MtvsEm3zgnvb7mKaJNnBtIzIqzveZFv9NDg=; b=IRLGVrxlHXwsKHUC8wkzPhiKHETJqQmHj+P2fz6o5SvNdGjKEjh+4cjfuJe5A9HaGQ 8igCI5eWpBnadsYtP1lxOT+7zWw78mukOvauVeVqPg8JMISvSi5K6LDpU+Vg/NBVS5en dvFx1bR3gU7iTTzcE3EZUqQwBHk2kzVxLT/Tv6yLvIfd/NBcMN5AHpVm8jzmIXqtQyOM D//E49s4DOTGb7xKshT45gp5bv0+ZnHUJK4e5FxiRZ6TW0zNU7/MX28kqQ6WUSA4BJix OOrSenjLCSgOm2M9OQfa2P99K13q1oxnZUax0yPEOnNmvgP40ZsaF2V2Nag4+4AZv1eK yP9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l6si2926703oti.249.2019.12.12.01.30.53; Thu, 12 Dec 2019 01:31:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728327AbfLLJaY (ORCPT + 99 others); Thu, 12 Dec 2019 04:30:24 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:7676 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726382AbfLLJaX (ORCPT ); Thu, 12 Dec 2019 04:30:23 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id CBF2CE826BD3C26BC609; Thu, 12 Dec 2019 17:30:20 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.439.0; Thu, 12 Dec 2019 17:30:13 +0800 From: Chen Zhou To: , , CC: , , , Hulk Robot Subject: [PATCH -next v2] pinctrl: samsung: fix build error without CONFIG_OF_GPIO Date: Thu, 12 Dec 2019 17:27:26 +0800 Message-ID: <20191212092726.41027-1-chenzhou10@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If CONFIG_OF_GPIO is n, build fails: drivers/pinctrl/samsung/pinctrl-samsung.c: In function samsung_gpiolib_register: drivers/pinctrl/samsung/pinctrl-samsung.c:969:5: error: struct gpio_chip has no member named of_node gc->of_node = bank->of_node; Use #ifdef to guard this. Reported-by: Hulk Robot Signed-off-by: Chen Zhou --- drivers/pinctrl/samsung/pinctrl-samsung.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c index f26574e..5c29ad8 100644 --- a/drivers/pinctrl/samsung/pinctrl-samsung.c +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c @@ -966,7 +966,9 @@ static int samsung_gpiolib_register(struct platform_device *pdev, gc->base = bank->grange.base; gc->ngpio = bank->nr_pins; gc->parent = &pdev->dev; +#ifdef CONFIG_OF_GPIO gc->of_node = bank->of_node; +#endif gc->label = bank->name; ret = devm_gpiochip_add_data(&pdev->dev, gc, bank); -- 2.7.4