Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp599688ybl; Thu, 12 Dec 2019 01:39:15 -0800 (PST) X-Google-Smtp-Source: APXvYqyCsdisGpK/GOhUHWg1Q2lgofJD1+8DOHFS2WkIDJ+fEYOUd2uTCthVkgVGMTioUTQ240ei X-Received: by 2002:a05:6830:1251:: with SMTP id s17mr6979431otp.108.1576143555243; Thu, 12 Dec 2019 01:39:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576143555; cv=none; d=google.com; s=arc-20160816; b=XKP5n3z1otPhLBReSGVGAdo2Wqtngh4VbZ57DSYr+Tyk0kYety43lVAK0deiQ5uhYq ADTSvTejoffedgOdDlJqlAQQe6BxLEZxTu5bDmme4w0dQ//ZqqYOrpIOo64bEygLJNUu Z8OQCI+h1B4iORcTdtYzw1Amy/fP/a8nwV50fi6zAV1UPgHu2RnPWECOjNRNN9sq3o/S 3pxCiAOv9zyN8zOiJtZ/xtuUIXqubXj0o07ZWW1Js7kY4qDqiiXMSWW1ZMx+ZCtML5pt 6MdRydmhAk9+dpBwYzD5rCuLSSPYcQXgDxwO/wI1QcKTkBGgLWcLP7yWz2q9+tjSOf1y H6rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=PJeytsvwWl8WuLPzmu0cCUjnyOYJkNJeR/9gq40ppbo=; b=WCa1i9naGM9Ebz2kcp+6apsORL2j5Ae841GlM8oIbIyhxiuIEkyTkhq0KXRW71fdqS OtWsUzRgWG1D02hC/M+U86dhs0so2rHy2G8loC+yO9nADFcNL7M3B+uabatnMFwOeLUI yzHHAjupE4DDs2Xq1yUt7eJwHTgW5jnwuPMIv18nXO/vxeshR8K9klbOodivHUeKohZn 0+qiA65pWVvfHfNk0oB7TmxuPth6LCysOlv+jHOq2LKBFaqgS/oqmcXcAet778eccHtK JgiWyE+IfuzC0TYejyYEdpIIVWF6qWtzZYFVxkM8fsO9KIMg4LcOOF4698W/+ix6GgQg egsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DMyWdFLA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n15si2659758otf.302.2019.12.12.01.39.02; Thu, 12 Dec 2019 01:39:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DMyWdFLA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728480AbfLLJiY (ORCPT + 99 others); Thu, 12 Dec 2019 04:38:24 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:44256 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728230AbfLLJiX (ORCPT ); Thu, 12 Dec 2019 04:38:23 -0500 Received: by mail-wr1-f65.google.com with SMTP id q10so1919235wrm.11; Thu, 12 Dec 2019 01:38:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=PJeytsvwWl8WuLPzmu0cCUjnyOYJkNJeR/9gq40ppbo=; b=DMyWdFLAd0oSrDo/7o7GHv5/qmtTOadoKRpRyh9IpsxYB89dXMwRt0URuqKY6rxZgn pmOs9Io5xGpRe3EuVgIosLG2ZqInU/MhWczvBHKrUWV815EelswDFsQR4h5BDwhaZ2gQ 4Ttjg3Nfi734kcgMcfTcnQTbQKXj42Fye0OR1gAQbIvvEU7YCyN6el+/5E7hiYUCmkmI q/9nKJ1Ps3/vBRT68uN8AER0s0oddiC2ID1twFgY830pqGtfEJNQ+JK/oz8mQJyR1K5P zAdXkONR+turs0PtjQ4qWVVuJNaktLDtkzTFfK6xFmdPUgQEuPbqGMVIldSfjwOANTEb eEyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=PJeytsvwWl8WuLPzmu0cCUjnyOYJkNJeR/9gq40ppbo=; b=dYBd9jx8Gr/ufn4KSLl1Y2UwXPViKTQziuKTxsJ7roVglDlI4W4gAnWF+WROfLP0aI TKg1yznx4x7ddN1sYdo092EvxVngbwMg0RDTny09EMhkR6IWz4ZwomMukPw61fmSrCLY 5J8gwqAftjmzjUOBPHm/Qb8UFYXHhHhJLnBODSWRz5lVEOMQYTgilRwLujT+py5n+RKL IjuwjzguyV53dIPKTwYnkDcqaQzEwqTOypLOa5CPhPsSnlNbsRZ3b744yS2WOAlXUnWS O1BRg+nRmHRzfcJrlNdfk+A/fvTAqSGvNvd6F7bCK2DGteqId/kJzO3iEE+TU0cmq68v NpdA== X-Gm-Message-State: APjAAAX0Nl4NJ168vsVmFUnzBWPhJ8hTtlz5M0JYS1Jm2ukk1VR4DTLU 61wPoulz/w6mm34kNt17vcM= X-Received: by 2002:adf:f802:: with SMTP id s2mr5156241wrp.201.1576143501205; Thu, 12 Dec 2019 01:38:21 -0800 (PST) Received: from linux-691t.suse.de ([124.11.22.254]) by smtp.gmail.com with ESMTPSA id z8sm5471508wrq.22.2019.12.12.01.38.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Dec 2019 01:38:20 -0800 (PST) From: "Lee, Chun-Yi" X-Google-Original-From: "Lee, Chun-Yi" To: Ard Biesheuvel , James Morris , "Serge E . Hallyn" , David Howells , Josh Boyer , Nayna Jain , Mimi Zohar Cc: linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, "Lee, Chun-Yi" Subject: [PATCH 0/2] efi: cosmetic patches for the error messages when loading certificates Date: Thu, 12 Dec 2019 17:38:10 +0800 Message-Id: <20191212093812.10518-1-jlee@suse.com> X-Mailer: git-send-email 2.16.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When loading certificates list from EFI variables, the error message and efi status code always be emitted to dmesg. It looks ugly: [ 2.335031] Couldn't get size: 0x800000000000000e [ 2.335032] Couldn't get UEFI MokListRT [ 2.339985] Couldn't get size: 0x800000000000000e [ 2.339987] Couldn't get UEFI dbx list This cosmetic patch set moved the above messages to the error handling code path. And, it adds a function to transfer EFI status code to string to improve the readability of debug log. The function can also be used in other EFI log. Lee, Chun-Yi (2): efi: add a function for transferring status to string efi: show error messages only when loading certificates is failed include/linux/efi.h | 26 +++++++++++++++++ security/integrity/platform_certs/load_uefi.c | 41 ++++++++++++++------------- 2 files changed, 48 insertions(+), 19 deletions(-) -- 2.16.4