Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp612290ybl; Thu, 12 Dec 2019 01:56:39 -0800 (PST) X-Google-Smtp-Source: APXvYqxH69YpqL6LNf9vT6yoFohClW1jPHCRovZHSQkuW4zQGMY06YC1rJ3ZQkQZjBNpU1VwSUeh X-Received: by 2002:a05:6830:12cf:: with SMTP id a15mr7303296otq.222.1576144599825; Thu, 12 Dec 2019 01:56:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576144599; cv=none; d=google.com; s=arc-20160816; b=rnLVZu6WxMVuPUHLQqfJdKSoTdoaNCJguCqfnC/WR7+4J6RMlIawphrrr+2YHeLSIe vu2GYn6W/w0+pbMxnebl86S812IGQW3253EOVQWStNvii5C18IVSYe/OHNzQsyuVUufd 8VKvIIs7rxiOIpVkvIXhGAoJV8o545mjOCl84Xe+lXqNsmqoXHnwedij+uGxvmuREv/c V74FoK/heHSW5nYvVQykGd2Xum7X4ezRNZOohyJKUjQqPz5RiyVd+l25UJMtIy0g66yU A4PwJnIN9l2TCrYWkfggLmrW5Wg/Vf2dMn4YmBVh5+j8QSq9mBpQbK1iGRQRfFR6m6SZ LJ3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=eDIed+Zi+5UTjYPK4Ba5LwS+W5X2j//mWbmGXa+L2Fk=; b=Pq1dTB8RrNpP3tmYAz7Xk0LGzZ7nSke+9gV3fKGzy8fFBD7Eh49Sn71O0fxGhdkboh ry5UvHmv08JgTCRmoly5thD1eqpPtd/Qseaj87YHecmIXxSXxuo26g8x9h4Rdcorpnij PfXAXcW26fXq2JQLW/B5qCVoLg/XA3E1Dgc8m7vV3ZcKUCoE2JQ5cXJ6EyhqUtVECALC ul3u8971pzVCxNugrF37EmtgVxQm8ilHUr4zYQbP4gRxu3DEsK+FNSjtKPQ4PmG5Of6/ wPJuRoDOwqJsIna/nhADioC6ih4tz0E9SDGr5W+2OIj1ZKgZFMBvyUqJEJgaC/c6ZSvX 2apA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=mOV02aD9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u9si2750845oib.55.2019.12.12.01.56.27; Thu, 12 Dec 2019 01:56:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=mOV02aD9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728433AbfLLJzf (ORCPT + 99 others); Thu, 12 Dec 2019 04:55:35 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:52990 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728282AbfLLJzf (ORCPT ); Thu, 12 Dec 2019 04:55:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=eDIed+Zi+5UTjYPK4Ba5LwS+W5X2j//mWbmGXa+L2Fk=; b=mOV02aD9hNY6wre2zZRyh2idB Lv9rZtS2GcgcVn2hq3sClU7V63UF96AHZIQfmyvIlqxAu7CcKsD7sbMI/YCbCYqwtgA0riQoie29E PG7nyVDuvvGbzKoVYepEEYaFlyLdVpzoD5F76YdoWhlmtyPrWZLzN6l5CK1X/bDRGuWmrU+re39rM ukH4j7MXLue6jLkrgu3Cib/7YQwbMQOJ/jmHuhaoHa0wuyFgWO/RAkeJhx3eHeCaXCVhEL/bQAb4e 8FoiS/awvumXM32M8p1+TFDOQBPX/KLqG/t/dp0mnHPlmxUhFtytjT/QXXWJBkf6DIXlqdV7RkoJp 4E21ESQoA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifLC1-0007uW-Kb; Thu, 12 Dec 2019 09:55:33 +0000 Date: Thu, 12 Dec 2019 01:55:33 -0800 From: Christoph Hellwig To: Andreas Gruenbacher Cc: "Darrick J. Wong" , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cluster-devel@redhat.com Subject: Re: [PATCH] iomap: Export iomap_page_create and iomap_set_range_uptodate Message-ID: <20191212095533.GA23944@infradead.org> References: <20191210102916.842-1-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191210102916.842-1-agruenba@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At very least this needs to be a EXPORT_SYMBOL_GPL in sent in a series with the actual user. But I'm not all that happy about exporting such low-level helpers. Can't we come up with a useful higher level primitive instead?