Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp643641ybl; Thu, 12 Dec 2019 02:32:53 -0800 (PST) X-Google-Smtp-Source: APXvYqw4qJcB9kQeHEPifXXbAmKrF7wkS0xDpFOi7+kOXn/6qcxMEnFxDFCjXgUzJ75ubIgdHN7Z X-Received: by 2002:a9d:760f:: with SMTP id k15mr7366672otl.65.1576146773183; Thu, 12 Dec 2019 02:32:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576146773; cv=none; d=google.com; s=arc-20160816; b=sme55T+v6f8fYebsaXb2GRSKc1RVSVrNrYTsF9nXjqWLbbkcuVNAbkTuWMMZGkB2Q9 zVAWeRQKAryHTGVC6kCYBI9Y/1K9ZLjgW5PVLXN8NhD54fZuRbBUnUPiWg9GEnOI8HBH iESRtz0MLMCGhCk4xtsV/Eeo6DNzqnz8v23R18/wrYT+6WBaqNKG5dgpMPqactpuZjTc sXAOh64kM3fvXMD+HmsYatLBJXeQmF7/oVy5VbrdLM+0RrrZW9bcsZVB1dRfr+bVewE1 A6KYtaACbijet4lD9EcUr9T3/DTPkUVTDvOLrmmYYBIT1XrHtLSDy3GmfiAOxwu+9DG9 avDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ziLQtEYjxvu61h+g9EC+nqhtRVmmOST0OYXIKk0q5ho=; b=X1PB3WUmuk+8U7zni+gGwFKjkPd0PtSXmDoDTBdTRva2Uw92oOVEAZYay82MVVLxkU wQgtmh5LSBqEe2hX3Zx7znb7er51yk+ybvVRT6AYO9te825XkwsNrgCE50GTBCyY+7IV tShStzaPG7T53YELf8XaACVlq0jrD7v64RDjzonJUFe288nC+tc1PyubSKcM9PJxv+mn vRCbFIYs06t2WHCEcXT9uU91+P/C505Uvm+FAymXKQRo02rOU6ul4he9sQFpA6KWVZCX aZw/F0sUz2jWF3e2t0h6shSCcaR55iKwfKQMX1/NGVhEQk7kjx/7rFlUsW2EpUUqoElU /Hew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=W0H0pxld; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l21si2817960otk.142.2019.12.12.02.32.37; Thu, 12 Dec 2019 02:32:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=W0H0pxld; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728687AbfLLKcH (ORCPT + 99 others); Thu, 12 Dec 2019 05:32:07 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:27825 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728575AbfLLKcG (ORCPT ); Thu, 12 Dec 2019 05:32:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576146725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ziLQtEYjxvu61h+g9EC+nqhtRVmmOST0OYXIKk0q5ho=; b=W0H0pxldIPjefbYntaBkHb1va0/fjCk/H7EAbd/KrnCGR/iOLTEBzI20vJ+rvadALDEMxK 5ui0m+vPIw8l+qLfIFZ6bv20CaM8Qbe9gw1zERSRWJqvYT2/feS0P3uqO6gWaUIM8oIWzz ZYw/juED8Z9l60InsJq7BZsv+Iexwrw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-391-tTLposStNIWU_L_ye0hL6w-1; Thu, 12 Dec 2019 05:32:04 -0500 X-MC-Unique: tTLposStNIWU_L_ye0hL6w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 56E201800D42; Thu, 12 Dec 2019 10:32:02 +0000 (UTC) Received: from shalem.localdomain.com (unknown [10.36.118.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8AA8A18779; Thu, 12 Dec 2019 10:32:00 +0000 (UTC) From: Hans de Goede To: Ard Biesheuvel , Thomas Gleixner Cc: Hans de Goede , Dominik Brodowski , x86@kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5.5 regression fix 0/2] efi/libstub: Fix mixed-mode crash at boot Date: Thu, 12 Dec 2019 11:31:56 +0100 Message-Id: <20191212103158.4958-1-hdegoede@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi All, Commit 0d95981438c3 ("x86: efi/random: Invoke EFI_RNG_PROTOCOL to seed th= e UEFI RNG table") causes drivers/efi/libstub/random.c to be used on x86 for the first time and some of the code in that file does not deal properly with mixed-mode setups causing a crash at boot on mixed-mode devices. The first patch in this series fixes this and is the regression-fix from $subject. While looking into this I did a quick search for other cases of the same problem in the libstub code and I found the same issue in the handling of LILO-style file=3D kernel commandline arguments, which I guess are not used that often because AFAICT we have no bug report for these not workin= g in mixed-mode. The second patch fixes this, this is a pre-existing proble= m and not a 5.5 regression, still we should probably also include this fix in 5.5. Regards, Hans