Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp669063ybl; Thu, 12 Dec 2019 03:02:34 -0800 (PST) X-Google-Smtp-Source: APXvYqyL1PSz1y9gtMgvvhORe6oKZw2UXAkquSyrQpm+mggG4d/djsZKURBX8pCmqJ/bSqFNeVlL X-Received: by 2002:a05:6830:22e6:: with SMTP id t6mr7864940otc.244.1576148553944; Thu, 12 Dec 2019 03:02:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576148553; cv=none; d=google.com; s=arc-20160816; b=ERfd6cqmbo+8EM1LOpRnRBnbr6rRGbToyM/zN/cNkNLOVYX2mYUAAnx7LsFlpTVpRV vy+pS9kq+76SV90sa123k4YihSRdNLWuhK3zvPqKu/rBOlarZEw5zMQQTRCb7OV2Db6O IDmNTXzIpz6KaHW1kbPOEzyRvTE6ZJ9A94SW/sdV3JFnELl4ba/gSTd4kzdB/Kvlzvjz IC8d4UF/Wq2/ui0MyF3i7fdCh5KiRXRhxol/PFr+b+Wgm/o3HULyvu/Y+KWXL4GUUCh+ 6nvQdMWsrXpQ6hdvvqrddi39ln/c8SaFn4rAGfFEViKKPH+R99j6H3p5KYjLSi3I7XZr o8Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=E/BDoN8LZUDxXyY/LOw9blBuAN4iCi1dNk0E5OnY49A=; b=SM04D+2bAdZE7Wxl8/8SWPajLuXua5EJ75h9iSKEN4X6qCYqS9fy9CkY8JEeHw5GFD ZlosxC3vL4qopVYLlC0C/WNQwf+WMIa0oszffgr5gd5TEtjkBcHZxYfzQQG2R84uYvhm H0kuX5cKrwTDVdTkiyw9AtweAFaZTiG6G/brOL/VFdpZ10sMhFZWTAZfADUJLMkfpmcV V/F03LwtTPaIekvf49PR013gOqjKxCTy+St00wU2IwOqJ9SA3in8z5puO2FYKBEwWhIc NMoJSitn10qtTvjNQi6uQt8PP/EG13KyGkpjTijjQFLSpsBblDrl1O4wReAlsZfjkimM M+7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@verdurent-com.20150623.gappssmtp.com header.s=20150623 header.b=0pngTayz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o25si2720428oic.63.2019.12.12.03.02.21; Thu, 12 Dec 2019 03:02:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@verdurent-com.20150623.gappssmtp.com header.s=20150623 header.b=0pngTayz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728849AbfLLLAf (ORCPT + 99 others); Thu, 12 Dec 2019 06:00:35 -0500 Received: from mail-ua1-f68.google.com ([209.85.222.68]:34681 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728423AbfLLLAe (ORCPT ); Thu, 12 Dec 2019 06:00:34 -0500 Received: by mail-ua1-f68.google.com with SMTP id w20so696379uap.1 for ; Thu, 12 Dec 2019 03:00:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=verdurent-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E/BDoN8LZUDxXyY/LOw9blBuAN4iCi1dNk0E5OnY49A=; b=0pngTayzWJ20KkIBh4tlHJX+QdVx/rkEkOMTPMMkhuqR7vgQNhYEqZ1NPP0dRkr4P+ bDnwbbiSS91uoE+EW/6uHJpeB3oEPywSxie4sceXAxr79+DkZTxNo79cogGtfTDCoF65 p5BhjUqxj68aDMfQvYOga54io5dJ8DtIxyc0AXJdszgIgn6likYDlp9hzDxMYedA/fy+ JBF4uNj6AUsW3L1kiUdruc+lmWz9604Fy2MXvU1GId/o3xOwR6ef6ZfdCjo5RB48Oz/o AOgBtNJQuPYxR0xLGQoHZCvQ6I7teRQogxfgoExeNTKipB0JRJumEMP2I0J9Jty2rVo0 BoKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E/BDoN8LZUDxXyY/LOw9blBuAN4iCi1dNk0E5OnY49A=; b=YOOaRpS6CMVPbmzkATSHU7voCyTGTOW8w31nOt+Ouli0RReiHiQIO1A6zsFNWY+eEs J5J/psUaK6PuCkcqOWfLA7ozVCHWmw1itRfBXz3FwIxZfcWm06tfcSXWs6fqNhAp9T9W 1TYDM2rO6EqqMC9zCMWxi5vakaa2jsClKgWZzkuqTT/z1XXFY3QA4Sh70CkGp0YJJjnH X8iXILOtpTjNvuj33Mrl4ln2IvgAhmJy+S0tt97j4qNrJnxmIgMFB9o8CqMIk7JkpkV9 19SH24sJC1EzIRP1u2T7IdLnn0gPshquW+moo7BjRQc2xNYWAvWPNQAzIssriPFqSq9+ YHRA== X-Gm-Message-State: APjAAAUOC2W/6yGaYr51xyxptiSpghzsLILf/h5s4EWwHIEXnC7lJeSU QWxkwqKvhqT4fSdN5UwPlV2vVkw38HpjyF4UW1MHiA== X-Received: by 2002:ab0:7352:: with SMTP id k18mr7377553uap.77.1576148432270; Thu, 12 Dec 2019 03:00:32 -0800 (PST) MIME-Version: 1.0 References: <1574934847-30372-1-git-send-email-rkambl@codeaurora.org> <1574934847-30372-2-git-send-email-rkambl@codeaurora.org> In-Reply-To: <1574934847-30372-2-git-send-email-rkambl@codeaurora.org> From: Amit Kucheria Date: Thu, 12 Dec 2019 16:30:20 +0530 Message-ID: Subject: Re: [PATCH v2 1/1] arm64: dts: qcom: sc7180: Add device node support for TSENS in SC7180 To: Rajeshwari Cc: Andy Gross , Bjorn Andersson , Rob Herring , Mark Rutland , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , sivaa@codeaurora.org, sanm@codeaurora.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rajeshwari, On Thu, Nov 28, 2019 at 3:25 PM Rajeshwari wrote: > > Add TSENS node and user thermal zone for TSENS sensors in SC7180. > > Signed-off-by: Rajeshwari > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 527 +++++++++++++++++++++++++++++++++++ > 1 file changed, 527 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 666e9b9..6656ffc 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -911,6 +911,26 @@ > status = "disabled"; > }; > > + tsens0: thermal-sensor@c263000 { > + compatible = "qcom,sc7180-tsens","qcom,tsens-v2"; > + reg = <0 0x0c263000 0 0x1ff>, /* TM */ > + <0 0x0c222000 0 0x1ff>; /* SROT */ > + #qcom,sensors = <15>; > + interrupts = ; > + interrupt-names = "uplow"; > + #thermal-sensor-cells = <1>; > + }; > + > + tsens1: thermal-sensor@c265000 { > + compatible = "qcom,sc7180-tsens","qcom,tsens-v2"; > + reg = <0 0x0c265000 0 0x1ff>, /* TM */ > + <0 0x0c223000 0 0x1ff>; /* SROT */ > + #qcom,sensors = <10>; > + interrupts = ; > + interrupt-names = "uplow"; > + #thermal-sensor-cells = <1>; > + }; > + > spmi_bus: spmi@c440000 { > compatible = "qcom,spmi-pmic-arb"; > reg = <0 0x0c440000 0 0x1100>, > @@ -1121,6 +1141,513 @@ > }; > }; > > + thermal-zones { > + cpu0-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + > + thermal-sensors = <&tsens0 1>; > + > + trips { > + cpu0_alert0: trip-point0 { > + temperature = <90000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu0_alert1: trip-point1 { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu0_crit: cpu_crit { > + temperature = <110000>; > + hysteresis = <1000>; > + type = "critical"; > + }; Where are the cooling maps for all the cpu thermal zones? A passive trip point w/o a cooling map is not of much use. If you are waiting for cpufreq support to land before adding them, then remove the passive trip points for now and add them along with the cooling maps when you have cooling devices. > + }; > + }; > + > + cpu1-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + > + thermal-sensors = <&tsens0 2>; > + > + trips { > + cpu1_alert0: trip-point0 { > + temperature = <90000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu1_alert1: trip-point1 { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu1_crit: cpu_crit { > + temperature = <110000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + cpu2-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + > + thermal-sensors = <&tsens0 3>; > + > + trips { > + cpu2_alert0: trip-point0 { > + temperature = <90000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu2_alert1: trip-point1 { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu2_crit: cpu_crit { > + temperature = <110000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + cpu3-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + > + thermal-sensors = <&tsens0 4>; > + > + trips { > + cpu3_alert0: trip-point0 { > + temperature = <90000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu3_alert1: trip-point1 { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu3_crit: cpu_crit { > + temperature = <110000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + cpu4-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + > + thermal-sensors = <&tsens0 5>; > + > + trips { > + cpu4_alert0: trip-point0 { > + temperature = <90000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu4_alert1: trip-point1 { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu4_crit: cpu_crit { > + temperature = <110000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + cpu5-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + > + thermal-sensors = <&tsens0 6>; > + > + trips { > + cpu5_alert0: trip-point0 { > + temperature = <90000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu5_alert1: trip-point1 { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu5_crit: cpu_crit { > + temperature = <110000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + cpu6-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + > + thermal-sensors = <&tsens0 9>; > + > + trips { > + cpu6_alert0: trip-point0 { > + temperature = <90000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu6_alert1: trip-point1 { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu6_crit: cpu_crit { > + temperature = <110000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + cpu7-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + > + thermal-sensors = <&tsens0 10>; > + > + trips { > + cpu7_alert0: trip-point0 { > + temperature = <90000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu7_alert1: trip-point1 { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu7_crit: cpu_crit { > + temperature = <110000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + cpu8-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + > + thermal-sensors = <&tsens0 11>; > + > + trips { > + cpu8_alert0: trip-point0 { > + temperature = <90000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu8_alert1: trip-point1 { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu8_crit: cpu_crit { > + temperature = <110000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + cpu9-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + > + thermal-sensors = <&tsens0 12>; > + > + trips { > + cpu9_alert0: trip-point0 { > + temperature = <90000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu9_alert1: trip-point1 { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu9_crit: cpu_crit { > + temperature = <110000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > +