Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp786420ybl; Thu, 12 Dec 2019 05:01:33 -0800 (PST) X-Google-Smtp-Source: APXvYqyw+YbEjbC5dD7LUDIGi4z8qIASbjUNDyyNBSK27gFUBBOn5wyfsWQFHUIYHbloggqiCjjA X-Received: by 2002:aca:ad47:: with SMTP id w68mr4715495oie.63.1576155693207; Thu, 12 Dec 2019 05:01:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576155693; cv=none; d=google.com; s=arc-20160816; b=N9OF3XexyxXDPkMGkEPAlthzQwWLY10ic74nqATXuhxE/0mIOgf8pXMzpD/n8EDufC AIUdv1vF5XlQhAwNIidPOSc6lcTM/DjIUKG9Qngv9nt4Ia5oLw9QQcYfmUwbPYbBUt63 o5Q1ZW8mmCrqPBpt8I3RV+jBNuwP2vegpapVBlVd6ghjrKMjjzyzVVqEw/vqiFeNSMk+ nrC+U4FSsU3l9wzS6jhFsqxrYwmwtwfoTX88TQDcNu/nNsYPoao3GdUYx2skf6ufsE+d wvAxnT+Jb/wdYMtM6ZmF8gBdgumG76uLdUhcgc8T3FSlWl5u7yHrCcbmIkmDDsNmW0Nt nF6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=/09Z85DEZAnQkHU5l0jlNS5poHDrF2hfL/FowYzKEC4=; b=a2p07KFOY0V20MCamrenOPtSc2NxUxUM3WUJfY3m+N9RBXvYN/MUZslHM4uFsYk4fY 49ym/rkfap0ZJ0y/Y2j0dIUfJJ3bWmqQ1AsIzM5AkD3SuWaSPzdXzHMo4wHqs88d/fuB fOeTzzEsVPQCXpiFC1luu7QPJQYbLVeQVQgFYTMM2GgH+TU9nmaJM19NptJcn8ATRpIq HBZkqCXmsNtw/Z0WRnOOLzNRBi7MMOB30VBepjNdnJaM8F123cOSGmzrkaXSW+GMjelW sFh0+9soA/e83/UwXP7ooKgI2hHgr7tdKOAr0v0yh8CmaECAbRx075weP5tiKRqXDbt6 A/1A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z84si3055024oia.7.2019.12.12.05.01.19; Thu, 12 Dec 2019 05:01:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729331AbfLLNAb (ORCPT + 99 others); Thu, 12 Dec 2019 08:00:31 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:45762 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729191AbfLLNAa (ORCPT ); Thu, 12 Dec 2019 08:00:30 -0500 Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1ifO4v-0003mN-3e; Thu, 12 Dec 2019 14:00:25 +0100 Date: Thu, 12 Dec 2019 14:00:25 +0100 From: Sebastian Andrzej Siewior To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Ellerman , Segher Boessenkool , Frank Rowand Subject: Re: [PATCH] of: Rework and simplify phandle cache to use a fixed size Message-ID: <20191212130025.elwei6m5lnjzjsau@linutronix.de> References: <20191211232345.24810-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191211232345.24810-1-robh@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-12-11 17:23:45 [-0600], Rob Herring wrote: > Change the implementation to a fixed size and use hash_32() as the > cache index. This greatly simplifies the implementation. It avoids The negative diffstat is nice. It solves the original issue I had and it did not introduce anything new, just tested it. So feel free to: Acked-by: Sebastian Andrzej Siewior Sebastian