Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 12 Dec 2019 15:02:41 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Pavel Machek <pavel@denx.de>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Maxime Ripard <maxime.ripard@bootlin.com>,
        Chen-Yu Tsai <wens@csie.org>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 4.19 185/243] ARM: dts: sun8i: a23/a33: Fix up RTC device
 node
Message-ID: <20191212140241.GA1595136@kroah.com>
References: <20191211150339.185439726@linuxfoundation.org>
 <20191211150351.658072828@linuxfoundation.org>
 <20191212133132.GA13171@amd>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191212133132.GA13171@amd>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Dec 12, 2019 at 02:31:32PM +0100, Pavel Machek wrote:
> Hi!
> 
> > The RTC module on the A23 was claimed to be the same as on the A31, when
> > in fact it is not. The A31 does not have an RTC external clock output,
> > and its internal RC oscillator's average clock rate is not in the same
> > range. The A33's RTC is the same as the A23.
> > 
> > This patch fixes the compatible string and clock properties to conform
> > to the updated bindings. The register range is also fixed.
> 
> No, this is not okay for v4.19. New compatible is not in
> ./drivers/rtc/rtc-sun6i.c, so this will completely break rtc support.

Good catch, I would have thought both of those would happen at the same
time.

Now dropped, thanks.

greg k-h