Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Joey Lee <JLee@suse.com>
To:     Ard Biesheuvel <ard.biesheuvel@linaro.org>
CC:     "Lee, Chun-Yi" <joeyli.kernel@gmail.com>,
        James Morris <jmorris@namei.org>,
        "Serge E . Hallyn" <serge@hallyn.com>,
        David Howells <dhowells@redhat.com>,
        Josh Boyer <jwboyer@fedoraproject.org>,
        Nayna Jain <nayna@linux.ibm.com>,
        Mimi Zohar <zohar@linux.ibm.com>,
        linux-efi <linux-efi@vger.kernel.org>,
        linux-security-module <linux-security-module@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] efi: add a function for transferring status to string
Thread-Topic: [PATCH 1/2] efi: add a function for transferring status to
 string
Thread-Index: AQHVsN48IHC/EIELJUajHOSd7WDsoqe2jdeA
Date:   Thu, 12 Dec 2019 14:24:07 +0000
Message-ID: <20191212142357.GV22409@linux-l9pv.suse>
References: <20191212093812.10518-1-jlee@suse.com>
 <20191212093812.10518-2-jlee@suse.com>
 <CAKv+Gu83Ndu8XWDAUTmHu6udRCXbodqzTyq5wZJvfGiLfidwbw@mail.gmail.com>
In-Reply-To: <CAKv+Gu83Ndu8XWDAUTmHu6udRCXbodqzTyq5wZJvfGiLfidwbw@mail.gmail.com>
Accept-Language: zh-TW, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [124.11.22.254]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bc41a153-7339-4526-0aeb-08d77f0ef2e4
x-ms-traffictypediagnostic: MWHPR1801MB1903:
x-microsoft-antispam-prvs: <MWHPR1801MB1903954AE816DDEA0A528ADDA3550@MWHPR1801MB1903.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3631;
x-forefront-prvs: 0249EFCB0B
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(136003)(396003)(376002)(346002)(366004)(39860400002)(189003)(199004)(52116002)(6916009)(71200400001)(6506007)(4326008)(33656002)(5660300002)(6486002)(54906003)(316002)(86362001)(26005)(7416002)(81166006)(8936002)(81156014)(8676002)(64756008)(66446008)(2906002)(66476007)(478600001)(66946007)(186003)(36756003)(66556008)(1076003)(6512007)(9686003);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR1801MB1903;H:MWHPR1801MB1919.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: suse.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 1fHawgUt6+3KfPzsPjMjc17otrOR5X2kZm5NPcG851FORpE5SA3TXH6NTO232TNTJkZXEaR2UTrJD0Y8bDr3e15XTP8IYdvYIydJFlXTKMOwE39WADw1+nIuJg65XVZJQA1pYC6XdDTb92Bduo5LJVq+urqyxN9+OW+iox2w8BiN+RqgJt3rL7XDpslLDdCwgr9Q4I2zgr58N4oC9FxoBVIWn8kPvQGQb8RwSeI0Md1+EsdlDlEQzaIsqUqHVf90mua2JbojDK8dPZWh5e7OFek7CRPOHA79bEU+uFlT8iGmrR4eWFJKn+d6XvFESDteph7jKcXsjS6nZShGYY/pI9FFr5y5poF6VtnSlz+Vkfj/esoTL9nJwahsTfjMmbNr+R22uVjf/2BWreP3Dl+RnNeDMwAKbmZqEuArsdVQU99YGH1VsDsyS0s4iD5koVfp
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <31C4C5E617C9F742A826A5DD8DCC726D@namprd18.prod.outlook.com>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: bc41a153-7339-4526-0aeb-08d77f0ef2e4
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2019 14:24:07.8804
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 856b813c-16e5-49a5-85ec-6f081e13b527
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Q4SRWuAvaUsNeDG/C5HsWwo4ZHt9FL7oEADJDzd8Q46MwQ8VtXZkVyQFZWx6Bd6R
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB1903
X-OriginatorOrg: suse.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ard, 

On Thu, Dec 12, 2019 at 11:20:48AM +0000, Ard Biesheuvel wrote:
> On Thu, 12 Dec 2019 at 10:38, Lee, Chun-Yi <joeyli.kernel@gmail.com> wrote:
> >
> > This function can be used to transfer EFI status code to string
> > to improve the readability of debug log.
> >
> > Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
> 
> I think I mentioned this the last time you sent this patch: by making
> this a static inline, those strings will be copied into each object
> file that uses this routine.
> Instead, please make it an ordinary function.
> 

Sorry for I just sent a old version patch. I will send a new one.

Thanks a lot!
Joey Lee 

> > ---
> >  include/linux/efi.h | 26 ++++++++++++++++++++++++++
> >  1 file changed, 26 insertions(+)
> >
> > diff --git a/include/linux/efi.h b/include/linux/efi.h
> > index d87acf62958e..08daf4cdd807 100644
> > --- a/include/linux/efi.h
> > +++ b/include/linux/efi.h
> > @@ -42,6 +42,32 @@
> >  #define EFI_ABORTED            (21 | (1UL << (BITS_PER_LONG-1)))
> >  #define EFI_SECURITY_VIOLATION (26 | (1UL << (BITS_PER_LONG-1)))
> >
> > +#define EFI_STATUS_STR(_status) \
> > +       case EFI_##_status: \
> > +               return "EFI_" __stringify(_status);
> > +
> > +static inline char *
> > +efi_status_to_str(unsigned long status)
> > +{
> > +       switch (status) {
> > +       EFI_STATUS_STR(SUCCESS)
> > +       EFI_STATUS_STR(LOAD_ERROR)
> > +       EFI_STATUS_STR(INVALID_PARAMETER)
> > +       EFI_STATUS_STR(UNSUPPORTED)
> > +       EFI_STATUS_STR(BAD_BUFFER_SIZE)
> > +       EFI_STATUS_STR(BUFFER_TOO_SMALL)
> > +       EFI_STATUS_STR(NOT_READY)
> > +       EFI_STATUS_STR(DEVICE_ERROR)
> > +       EFI_STATUS_STR(WRITE_PROTECTED)
> > +       EFI_STATUS_STR(OUT_OF_RESOURCES)
> > +       EFI_STATUS_STR(NOT_FOUND)
> > +       EFI_STATUS_STR(ABORTED)
> > +       EFI_STATUS_STR(SECURITY_VIOLATION)
> > +       }
> > +
> > +       return "";
> > +}
> > +
> >  typedef unsigned long efi_status_t;
> >  typedef u8 efi_bool_t;
> >  typedef u16 efi_char16_t;              /* UNICODE character */
> > --
> > 2.16.4
> >