Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp940986ybl; Thu, 12 Dec 2019 07:17:25 -0800 (PST) X-Google-Smtp-Source: APXvYqxW1tJjTMUtLh7YdYaotTbv1HDv/QmlJmzsqio6Yn2TKQsF0f5VsaW+QLPzXs2Vnu/g+oYR X-Received: by 2002:a9d:6f11:: with SMTP id n17mr8501244otq.126.1576163845517; Thu, 12 Dec 2019 07:17:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576163845; cv=none; d=google.com; s=arc-20160816; b=oK0Tuqw87XqbBaPzfp2u67kwscQIeT5yKa8TtSFSJZZtXakcYsxtavP5940u30+EvW tbOPz4dxrzW8n4Pghk8ftW9hpk55OjGs3NnEE5rOooanSKWwTFOErxmhroWpGoZXMvpQ ANn5BSExhEAH9u3SiQxzHf+y8Ej9H3FT5le8HnqNyW2ScP7XHbvorqY7AVApmnnnA6F/ S9K9pZs3J2rX6rGDr7jfe/Cxh2OfiM8q0uA10o3fkFJJuQ3FUVyD/pev81FJLfvio1h0 YQwzohmkTw98mLf2AIG4DJKLL3S7ZKi9w6xAvoNOYUnvzVIQ7o/amE0+WfNoxFgw+nA8 F56A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=fqIAUYObIqhJeHpHjDLZJpvGSDr/AnjM2VLcw/JukHs=; b=M7a/YMsTp66xyvVr4Aa1m4Ag7+648zx0TeXtvVT6Ro1kN1wEgISUuY2omAI7fKAetU Zs+cxQaAz9HCr/81uN2H66vJEQPJySGEIsb3TE6Tt/benfY2NYV5p7yeA2DI0or1VnIF zX2lfh36FTFnAdLfOqoC1qCo7qO6R4jNnXaCyln3GFdYidws1eVI53wjpSYmspr4sfr3 G817ZzOnBqopsp4XtlZgHpPSewY28puV7wBQ+6aF6g9/QMxilkIdfLxT+CgnJyZSLgKI iG1v56QQQCXSCHXgHn2Onz6cZzo8OZOQF3jDPCrZcduiVCOyvtJXge7gzut7MuvvKU7O XlcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=o41nx2Fa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u16si3109830otq.92.2019.12.12.07.17.11; Thu, 12 Dec 2019 07:17:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=o41nx2Fa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729211AbfLLPPb (ORCPT + 99 others); Thu, 12 Dec 2019 10:15:31 -0500 Received: from merlin.infradead.org ([205.233.59.134]:40624 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728654AbfLLPPb (ORCPT ); Thu, 12 Dec 2019 10:15:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fqIAUYObIqhJeHpHjDLZJpvGSDr/AnjM2VLcw/JukHs=; b=o41nx2FahlOPNHfP7Q0L1ZpCw WuIg0y8CiVgeOACrHgtzNu9jKnfWi55H3b3Qvd+T2Ckldvb7rZxsOeqkBiXhnq4gVfeeRpcQkntU/ LiBZpxsxl9jZdVx5bzEQvr1b5oet6Z+3/wrBzyzXOvN0f8eUOnBTiH+Lukt2WZyVCwo79apL7Ues3 /CqS8NOVf+I+PqUxBYweYwB7AFrP/sfhP6VSf4JoIA8p3Ri3JjmVYCCrKYXJUz8BZD2FMvsqEHzAf fM5V8ZZAGOMjMn0PDWFOfIssp06hi/aD2oDU+F5fHL9UUVkzjfYbBm0MgL7TFUmUmOCVyDqO5dCFs l48pgnpLQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifQBU-0002pM-Jb; Thu, 12 Dec 2019 15:15:20 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id A8BF5300F29; Thu, 12 Dec 2019 16:13:58 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 10DD22B195AE5; Thu, 12 Dec 2019 16:15:19 +0100 (CET) Date: Thu, 12 Dec 2019 16:15:19 +0100 From: Peter Zijlstra To: Srikar Dronamraju Cc: Dave Chinner , Phil Auld , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Moyer , Dave Chinner , Eric Sandeen , Christoph Hellwig , Jens Axboe , Ingo Molnar , Tejun Heo , Vincent Guittot Subject: Re: [PATCH v4] sched/core: Preempt current task in favour of bound kthread Message-ID: <20191212151519.GA2827@hirez.programming.kicks-ass.net> References: <20191120220313.GC18056@pauld.bos.csb> <20191121132937.GW4114@hirez.programming.kicks-ass.net> <20191209165122.GA27229@linux.vnet.ibm.com> <20191209231743.GA19256@dread.disaster.area> <20191210054330.GF27253@linux.vnet.ibm.com> <20191210172307.GD9139@linux.vnet.ibm.com> <20191211173829.GB21797@linux.vnet.ibm.com> <20191211224617.GE19256@dread.disaster.area> <20191212101031.GV2827@hirez.programming.kicks-ass.net> <20191212150737.GC21797@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191212150737.GC21797@linux.vnet.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 12, 2019 at 08:37:37PM +0530, Srikar Dronamraju wrote: > * Peter Zijlstra [2019-12-12 11:10:31]: > > > > > +static struct sched_entity * > > +__pick_next_entity(struct cfs_rq *cfs_rq, struct sched_entity *curr); > > I think we already have __pick_next_entity in kernel/sched/fair.c D'oh... yeah, I just wrote stuff, it never actually got near a compiler.