Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191212133306.24663-1-info@metux.net>
In-Reply-To: <20191212133306.24663-1-info@metux.net>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Thu, 12 Dec 2019 17:10:55 +0100
Message-ID: <CAMpxmJU0UmA0ZppFPDMgMZ9jfz5v55P0yy87-qY5=P=QKzckiw@mail.gmail.com>
Subject: Re: [PATCH] drivers: gpio: remove unneeded MODULE_VERSION() usage
To:     "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio <linux-gpio@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

czw., 12 gru 2019 o 14:33 Enrico Weigelt, metux IT consult
<info@metux.net> napisa=C5=82(a):
>
> Remove MODULE_VERSION(), as it isn't needed at all: the only version
> making sense is the kernel version.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
>  drivers/gpio/gpio-sama5d2-piobu.c | 1 -
>  drivers/gpio/gpio-tb10x.c         | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-sama5d2-piobu.c b/drivers/gpio/gpio-sama5d=
2-piobu.c
> index b04c561f3280..4d47b2c41186 100644
> --- a/drivers/gpio/gpio-sama5d2-piobu.c
> +++ b/drivers/gpio/gpio-sama5d2-piobu.c
> @@ -244,7 +244,6 @@ static struct platform_driver sama5d2_piobu_driver =
=3D {
>
>  module_platform_driver(sama5d2_piobu_driver);
>
> -MODULE_VERSION("1.0");
>  MODULE_LICENSE("GPL v2");
>  MODULE_DESCRIPTION("SAMA5D2 PIOBU controller driver");
>  MODULE_AUTHOR("Andrei Stefanescu <andrei.stefanescu@microchip.com>");
> diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c
> index 5e375186f90e..866201cf5f65 100644
> --- a/drivers/gpio/gpio-tb10x.c
> +++ b/drivers/gpio/gpio-tb10x.c
> @@ -243,4 +243,3 @@ static struct platform_driver tb10x_gpio_driver =3D {
>  module_platform_driver(tb10x_gpio_driver);
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("tb10x gpio.");
> -MODULE_VERSION("0.0.1");
> --
> 2.11.0
>

Patch applied.

Bart