Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To:     Marco Felsch <m.felsch@pengutronix.de>,
        Support Opensource <Support.Opensource@diasemi.com>,
        "lee.jones@linaro.org" <lee.jones@linaro.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>
CC:     "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: RE: [RESEND PATCH v3 2/3] mfd: da9062: add support for the DA9062
 GPIOs in the core
Thread-Topic: [RESEND PATCH v3 2/3] mfd: da9062: add support for the DA9062
 GPIOs in the core
Thread-Index: AQHVsQXcKFcQyOE/80WxSSkJ3fgLS6e2sC7A
Date:   Thu, 12 Dec 2019 16:45:46 +0000
Message-ID: <AM5PR1001MB099464F0AD7334D0AE67011C80550@AM5PR1001MB0994.EURPRD10.PROD.OUTLOOK.COM>
References: <20191212160413.15232-1-m.felsch@pengutronix.de>
 <20191212160413.15232-3-m.felsch@pengutronix.de>
In-Reply-To: <20191212160413.15232-3-m.felsch@pengutronix.de>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [165.225.80.228]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 346cf975-cbfd-46a2-d075-08d77f22bcb5
x-ms-traffictypediagnostic: AM5PR1001MB1043:
x-ms-exchange-sharedmailbox-routingagent-processed: True
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <AM5PR1001MB1043FF2ABFB1D29303F827AFA7550@AM5PR1001MB1043.EURPRD10.PROD.OUTLOOK.COM>
x-ms-oob-tlc-oobclassifiers: OLM:4941;
x-forefront-prvs: 0249EFCB0B
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(136003)(346002)(396003)(39860400002)(376002)(366004)(189003)(199004)(8676002)(4326008)(110136005)(316002)(54906003)(81156014)(81166006)(2906002)(8936002)(86362001)(55016002)(55236004)(66476007)(9686003)(7696005)(71200400001)(5660300002)(66446008)(66946007)(64756008)(186003)(76116006)(33656002)(53546011)(52536014)(26005)(66556008)(6506007)(478600001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR1001MB1043;H:AM5PR1001MB0994.EURPRD10.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:0;
received-spf: None (protection.outlook.com: diasemi.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: xzkjdq/c7x1Wij/9wuQ82GVBDxYpUTDWbGhMD55U/orDh/MsAYrBrHhGSysYQa/UtLpyT4/CJhDjmewu4YodbYI64RALHVDLUqOXEPYbZ/unixndxIRHEJyPjApJAU1vB2J0cKhNv4q/ozIbyucnX3rxr2xCWTguZfyDPVlluGZlB89KXeJCu0HTJzXi6aHQxZsUY2igkq1TGDZ9NLcGvt+DxYd6KuvgrUCX6c+ToENyAfALw6zlfIjTosgMhgyvzL4ZxtnHkazyLcxBbZhNpTKzhLofRFZuOh70tnELiy+uyM3Znt0oikW/uyqhIp2ZIF8Sv988YoubvVh3FKErBngyMnCVfZ1kKYeU27dEnEh8zwXiHIo6S9gY2Zm7IVnbVlOUURowdLUyXKZwCru0C9Pbal004hu5+tLUt5jwI3gamMkm+YerTGV9BdLelAF3
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: diasemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 346cf975-cbfd-46a2-d075-08d77f22bcb5
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2019 16:45:46.6562
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 511e3c0e-ee96-486e-a2ec-e272ffa37b7c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: e9CrwFPlyiMdKgK6Lcfn0eA0eH8vKHb7OMn7M5thpnseEcCV+QNDX2OECWW0mnpteeIPK+LM5xbNomtbNqpVB0C9Ec3FFgcBVo9XZcIBJOU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR1001MB1043
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12 December 2019 16:04, Marco Felsch wrote:

> Currently the da9062 GPIO's aren't available. The patch adds the support
> to make these available by adding a gpio device with the corresponding
> irq resources. Furthermore the patch fixes a minor style issue for the
> onkey device.
>=20
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>

Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

> ---
>  drivers/mfd/da9062-core.c | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
> index e69626867c26..5290bdc0ddcd 100644
> --- a/drivers/mfd/da9062-core.c
> +++ b/drivers/mfd/da9062-core.c
> @@ -233,6 +233,14 @@ static struct resource da9062_onkey_resources[] =3D =
{
>  	DEFINE_RES_NAMED(DA9062_IRQ_ONKEY, 1, "ONKEY",
> IORESOURCE_IRQ),
>  };
>=20
> +static struct resource da9062_gpio_resources[] =3D {
> +	DEFINE_RES_NAMED(DA9062_IRQ_GPI0, 1, "GPI0", IORESOURCE_IRQ),
> +	DEFINE_RES_NAMED(DA9062_IRQ_GPI1, 1, "GPI1", IORESOURCE_IRQ),
> +	DEFINE_RES_NAMED(DA9062_IRQ_GPI2, 1, "GPI2", IORESOURCE_IRQ),
> +	DEFINE_RES_NAMED(DA9062_IRQ_GPI3, 1, "GPI3", IORESOURCE_IRQ),
> +	DEFINE_RES_NAMED(DA9062_IRQ_GPI4, 1, "GPI4", IORESOURCE_IRQ),
> +};
> +
>  static const struct mfd_cell da9062_devs[] =3D {
>  	{
>  		.name		=3D "da9062-core",
> @@ -266,7 +274,13 @@ static const struct mfd_cell da9062_devs[] =3D {
>  		.name		=3D "da9062-onkey",
>  		.num_resources	=3D ARRAY_SIZE(da9062_onkey_resources),
>  		.resources	=3D da9062_onkey_resources,
> -		.of_compatible =3D "dlg,da9062-onkey",
> +		.of_compatible	=3D "dlg,da9062-onkey",
> +	},
> +	{
> +		.name		=3D "da9062-gpio",
> +		.num_resources	=3D ARRAY_SIZE(da9062_gpio_resources),
> +		.resources	=3D da9062_gpio_resources,
> +		.of_compatible	=3D "dlg,da9062-gpio",
>  	},
>  };
>=20
> --
> 2.20.1