Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To:     Marco Felsch <m.felsch@pengutronix.de>,
        Support Opensource <Support.Opensource@diasemi.com>,
        "lee.jones@linaro.org" <lee.jones@linaro.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>
CC:     "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: RE: [RESEND PATCH v3 3/3] pinctrl: da9062: add driver support
Thread-Topic: [RESEND PATCH v3 3/3] pinctrl: da9062: add driver support
Thread-Index: AQHVsQXfQ9DGkUJA90ed8RfDS4RwT6e2sLrQ
Date:   Thu, 12 Dec 2019 16:48:26 +0000
Message-ID: <AM5PR1001MB0994E2D72A95E4AC4796F80A80550@AM5PR1001MB0994.EURPRD10.PROD.OUTLOOK.COM>
References: <20191212160413.15232-1-m.felsch@pengutronix.de>
 <20191212160413.15232-4-m.felsch@pengutronix.de>
In-Reply-To: <20191212160413.15232-4-m.felsch@pengutronix.de>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [165.225.80.228]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 69abee29-50f1-431d-b920-08d77f231bf7
x-ms-traffictypediagnostic: AM5PR1001MB1202:
x-ms-exchange-sharedmailbox-routingagent-processed: True
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <AM5PR1001MB1202696EA343D8578FFB65B8A7550@AM5PR1001MB1202.EURPRD10.PROD.OUTLOOK.COM>
x-ms-oob-tlc-oobclassifiers: OLM:4714;
x-forefront-prvs: 0249EFCB0B
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(346002)(136003)(396003)(39860400002)(366004)(376002)(189003)(199004)(54906003)(186003)(55016002)(64756008)(76116006)(66446008)(66556008)(110136005)(33656002)(316002)(66946007)(66476007)(26005)(2906002)(5660300002)(52536014)(71200400001)(4326008)(478600001)(8936002)(8676002)(86362001)(81156014)(81166006)(6506007)(53546011)(55236004)(9686003)(7696005);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR1001MB1202;H:AM5PR1001MB0994.EURPRD10.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:0;
received-spf: None (protection.outlook.com: diasemi.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: WLcKWDKymmBnUg/sgavELY/0SA9nde0e4Ioc/OTX+WqSXlicwfe0Dk7ue0tO3jpnkpBSMT48k8+LEhqRryb2e99P19f4yZLuLxLLvESijVx7SZmf1kjNV6G8khfwQXZVM/ymPV1cXJPLx9Rx10AAw1+y3iKnFnR7V0LJL/M7ZYbLLdNm05/oUBeE/6XkORYlunN5gOvr4qEW3Fi98gBI75gRlcPT+y7tCJrdzB5BHhjZDmMUdLwlPh0a1w9t+wB5KRV9tIQH2EqN/qKeUHIn73RlnA3vqDpceFHhMI5BhZabBh/eP9/CJxPQpL/RzfpErQxHB57ZN3aZUOva1qB7EfvFVa6WOnNR1RTIwQyH9ehSlopZays+blnDLOtYPLxQeWD7WzEATw7O87k5t1S2X45KGouPaXe7J+tQUWwNcIGlx6wsM9zMuNDHznaZiZDx
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: diasemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69abee29-50f1-431d-b920-08d77f231bf7
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2019 16:48:26.5257
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 511e3c0e-ee96-486e-a2ec-e272ffa37b7c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3hwDHCh65USDR4CO4kWD/UGV0Pc6BrGdgKLoW546tNN6z+wHRbk5XfB3loYWJLuhmZ15IBDeO/Sev7SFECsBjKJNWvsaElRa7GcQmIGg3Y0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR1001MB1202
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12 December 2019 16:04, Marco Felsch wrote:

> +static int da9062_gpio_set_config(struct gpio_chip *gc, unsigned int off=
set,
> +				  unsigned long config)
> +{
> +	struct da9062_pctl *pctl =3D gpiochip_get_data(gc);
> +	struct regmap *regmap =3D pctl->da9062->regmap;
> +	int gpio_mode;
> +
> +	/*
> +	 * We need to meet the following restrictions [1, Figure 18]:
> +	 * - PIN_CONFIG_BIAS_PULL_DOWN -> only allowed if the pin is used as
> +	 *				  gpio input
> +	 * - PIN_CONFIG_BIAS_PULL_UP   -> only allowed if the pin is used as
> +	 *				  gpio output open-drain.
> +	 */
> +
> +	switch (pinconf_to_config_param(config)) {
> +	case PIN_CONFIG_BIAS_PULL_DOWN:
> +		gpio_mode =3D da9062_pctl_get_pin_mode(pctl, offset);
> +		if (gpio_mode < 0)
> +			return -EINVAL;
> +		else if (gpio_mode !=3D DA9062_PIN_GPI)
> +			return -ENOTSUPP;
> +		return regmap_update_bits(regmap, DA9062AA_CONFIG_K,
> +					  BIT(offset), BIT(offset));
> +	case PIN_CONFIG_BIAS_PULL_UP:
> +		gpio_mode =3D da9062_pctl_get_pin_mode(pctl, offset);
> +		if (gpio_mode < 0)
> +			return -EINVAL;
> +		else if (gpio_mode !=3D DA9062_PIN_GPO_OD)
> +			return -ENOTSUPP;
> +		return regmap_update_bits(regmap, DA9062AA_CONFIG_K,
> +					  BIT(offset), BIT(offset));

Apologies for the delay on reviewing. Just looking at the datasheet, how do=
 we
disable PULL_DOWN (for input) and PULL_UP (for output)? Should we not have =
a
'PIN_CONFIG_BIAS_DISABLE' case here to handle this?

> +	case PIN_CONFIG_DRIVE_OPEN_DRAIN:
> +		return da9062_pctl_set_pin_mode(pctl, offset,
> +						DA9062_PIN_GPO_OD);
> +	case PIN_CONFIG_DRIVE_PUSH_PULL:
> +		return da9062_pctl_set_pin_mode(pctl, offset,
> +						DA9062_PIN_GPO_PP);
> +	default:
> +		return -ENOTSUPP;
> +	}
> +}