Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1050688ybl; Thu, 12 Dec 2019 08:55:26 -0800 (PST) X-Google-Smtp-Source: APXvYqyfzP6kSQbncqQgxNXxpkcroCWQ+GiGU/jmaVcAn12VpmNq6rT7v1E5t4PuK9TC8CY8VWqI X-Received: by 2002:aca:a949:: with SMTP id s70mr5871094oie.80.1576169726615; Thu, 12 Dec 2019 08:55:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576169726; cv=none; d=google.com; s=arc-20160816; b=CwRCZRtov96rUkw37bIsvkK6UcV+Aovb+9u4lwm2PTgfA51E1atbA7Jmdi5/Ab3Cow fvQB42bLeYpH7ULsVyTEm0TwXgoEx9IvQCJQwEgPTmi/rbyRAxs4VvVK57Hc1fCcujnp /5A1a+iYZeO0TNn5/v7lqkilHn0DijKZbx6kHZoklBo69YJaBUS5EFGKpKSXU57+Ioh0 4xnYWf8ZZkaNBIXsoH0ej7N/DZ8YNCFUFcOEWG3zoz/0LnL8i2OLLi3zpwt37Yrq1wPl rsNLJRYjA0cQYMuAVdsZqu3FuEZTM3elkQDE/mrPT0fBErFLgIROK5GtEC+aOFWYOswW f8yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=UCTY2ZJGNyXtFJsvZsGLGckBUYZTr5/2T6PFOCKC8bc=; b=vhwGmrBSmZBcZibYFMWKrXMB5l3t7iGQBtcqheb1s6MY/AYScFfVt38xMwb6Bj4irL cSktZN8W3iFom3k1873UhbNcEP3KS1Fwl6iamxdwegUm3mWUlyvo7wr2JhWPVyXlEvtG 0pHAjJ4kAq3uFeKRh9l3QQSTHisHp0/hq5BMuczKMKXt/k2UWwQFKCcEWcgRJSCE/0xp vA7t14sdubxyO15XeneF7phzICxmu//gKljIAsQ8JjfM8j7O0Xq/YXM4IW7H+FIfYLMo wmz1rif1Ai6cj03FGAQimuFXDzHgoWIQleFzT7A3CdxIZwVSIeVvYJD7VwmfiaQvbl2l gnHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k126si3543520oib.43.2019.12.12.08.55.13; Thu, 12 Dec 2019 08:55:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730013AbfLLQxQ (ORCPT + 99 others); Thu, 12 Dec 2019 11:53:16 -0500 Received: from foss.arm.com ([217.140.110.172]:53366 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729961AbfLLQxQ (ORCPT ); Thu, 12 Dec 2019 11:53:16 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 884F830E; Thu, 12 Dec 2019 08:53:13 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0452F3F6CF; Thu, 12 Dec 2019 08:53:12 -0800 (PST) Date: Thu, 12 Dec 2019 16:53:11 +0000 From: Mark Brown To: Charles Keepax Cc: Shengjiu Wang , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, gregkh@linuxfoundation.org, kstewart@linuxfoundation.org, allison@lohutok.net, guennadi.liakhovetski@linux.intel.com, tglx@linutronix.de, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: wm8962: fix lambda value Message-ID: <20191212165311.GK4310@sirena.org.uk> References: <1576065442-19763-1-git-send-email-shengjiu.wang@nxp.com> <20191212164835.GD10451@ediswmail.ad.cirrus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ogUXNSQj4OI1q3LQ" Content-Disposition: inline In-Reply-To: <20191212164835.GD10451@ediswmail.ad.cirrus.com> X-Cookie: We have DIFFERENT amounts of HAIR -- User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ogUXNSQj4OI1q3LQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Dec 12, 2019 at 04:48:35PM +0000, Charles Keepax wrote: > On Wed, Dec 11, 2019 at 07:57:22PM +0800, Shengjiu Wang wrote: > > According to user manual, it is required that FLL_LAMBDA > 0 > > in all cases (Integer and Franctional modes). > How well tested is this change, and is it addressing an issue you > have observed? I agree this does better fit the datasheet just a > little nervous as its an older part that has seen a lot of usage. I've got a feeling that requirement might've been added in later versions of the datasheet... --ogUXNSQj4OI1q3LQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3ycHYACgkQJNaLcl1U h9CUewf9HCpR8m1farmmx9Se1np+I9L3i4ncQb8j5AD1UGgSmhZMsNze4JTk6oWA 9DT0aL69PsnCxrYL8gV8CMy0vJPKhLg3+nRQvb1aVsRPBbWbtFQkSZA4YJ/xnmuu lC7PGYlGH7XM2z8QU7XwRsZQVwZ183+1QF4srp4w+VSCDtTku8I4nHzVzCOvGMaF 3T8dZQkGZ642sYUA3ZZCBRfVJOKIE/JsEQYLTksyOLqIAhjzvg31uyT+P1GnvZjV iD7C8zj22PjiICoEhOFk+0KpLcb38763CCxC7jF4Z3prrNY+jV0ExukK4VfG3vCh 67xrgyK5Y7JF8tUgkZ5Zu9c9/ulLZQ== =q6x7 -----END PGP SIGNATURE----- --ogUXNSQj4OI1q3LQ--