Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 1/2] IMA: Define workqueue for early boot "key"
 measurements
To:     Mimi Zohar <zohar@linux.ibm.com>, linux-integrity@vger.kernel.org
Cc:     eric.snowberg@oracle.com, dhowells@redhat.com,
        mathew.j.martineau@linux.intel.com, matthewgarrett@google.com,
        sashal@kernel.org, jamorris@linux.microsoft.com,
        linux-kernel@vger.kernel.org, keyrings@vger.kernel.org
References: <20191211185116.2740-1-nramas@linux.microsoft.com>
 <20191211185116.2740-2-nramas@linux.microsoft.com>
 <1576138743.4579.147.camel@linux.ibm.com>
From:   Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
Message-ID: <0cc15a43-8e1b-9819-33fe-8325068f8df2@linux.microsoft.com>
Date:   Thu, 12 Dec 2019 08:57:19 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.1
MIME-Version: 1.0
In-Reply-To: <1576138743.4579.147.camel@linux.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 12/12/19 12:19 AM, Mimi Zohar wrote:

>>> +	ima_process_keys = true;
>> +
>> +	INIT_LIST_HEAD(&temp_ima_keys);
>> +
>> +	mutex_lock(&ima_keys_mutex);
>> +
>> +	list_for_each_entry_safe(entry, tmp, &ima_keys, list)
>> +		list_move_tail(&entry->list, &temp_ima_keys);
>> +
>> +	mutex_unlock(&ima_keys_mutex);
> 
> 
> The v1 comment, which explained the need for using a temporary
> keyring, is an example of an informative comment.  If you don't
> object, instead of re-posting this patch, I can insert it.
> 
> Mimi

Sure Mimi. Thanks for including the comment in the patch.

thanks,
  -lakshmi