In-Reply-To: <787b0d920601221636h7acbb891wd52b88e0aea75aaf@mail.gmail.com>
References: <787b0d920601221636h7acbb891wd52b88e0aea75aaf@mail.gmail.com>
Mime-Version: 1.0 (Apple Message framework v746.2)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <5AB1D65D-8F03-4CDF-9847-D75143EC0A9C@mac.com>
Cc: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 7bit
From: Kyle Moffett <mrmacman_g4@mac.com>
Subject: Re: anon unions are cool
Date: Sun, 22 Jan 2006 19:56:26 -0500
To: Albert Cahalan <acahalan@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1504
Lines: 55

On Jan 22, 2006, at 19:36, Albert Cahalan wrote:
> For example, suppose we wanted to rename a badly-named struct  
> member. If the struct is used all over the kernel, this becomes a  
> giant project with huge potential for patch conflicts.

Actually, pure struct-member renames are not that common, however it  
_is_ common to add an accessor method due to upcoming locking/ 
virtualization changes or similar.  For that case (Using a random  
recent example from the list.  This was decided to not be the best  
route for pid virtualization, but it's just an example):

struct task_struct {
	[...]
	
	pid_t pid;
	
	[...]
};

This would become:

struct task_struct {
	[...]
	
	union {
		pid_t pid __deprecated;
		pid_t __internal_pid;
	};
	
	[...]
};

static inline pid_t task_pid(struct task_struct *t) {
	return t->__internal_pid;
}

Code that used task->pid would get a deprecation warning, however new  
code that used the task_pid(task) would work fine; and the task_pid()  
function itself would generate no warnings.

Cheers,
Kyle Moffett

--
Debugging is twice as hard as writing the code in the first place.   
Therefore, if you write the code as cleverly as possible, you are, by  
definition, not smart enough to debug it.
   -- Brian Kernighan


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/