Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1134383ybl; Thu, 12 Dec 2019 10:08:35 -0800 (PST) X-Google-Smtp-Source: APXvYqxS+4ZSuanv79seOApet2gfMEB2DuZ57jqCKcmt8QiTm5ql5EiNbVwSr3nbpGFj8Ck4j6Fm X-Received: by 2002:a9d:245:: with SMTP id 63mr10059311otb.229.1576174115693; Thu, 12 Dec 2019 10:08:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576174115; cv=none; d=google.com; s=arc-20160816; b=BzyRJY1h6gpyRAjU2EXKcPMuMeYC87r6M2b1Pk4elhoT1zG8hz6mbdmxO4iaQ4rI65 lBLApfivD0PAM1LztyaJz1KwhLm5KXStKYug/Pe/VEs1PayzmLYCvY72yE3KhioAzv5w Ss1tZZwI7A2adRFo5ctB2uXPGLvRY9N2gwJECxGmBOlShS73fgg3sHM75T0qA686orZE hp+BxLpWKYTKqE1dSqreNJS0PqQsrpv5C/o6XGBq7/cmUmmHrlm34uZZpRrgpRUcod+U l37O3YXDsOv69v2vUaH1jMWh1YOXLRYCLLQmKbRzyC4Kej/6sg7PQlPJinspd8+Iv/mP OHjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=Q9yKjtgg5C+39OLUHkVr4dIQw5sKH1M+2Vd3optb3OI=; b=DCBa1lR2l8o6aF1ET2JQshWhUY5z/4viyF0gZMWbyMkU9fnmOc2OK207yvdlRqp8/j lXysFqUrgDPn6LzFBrT0t+FVD5TLuKIjV91MsNZD8Nj6HIRKRvjkvQu2hnrq0sWV6QJA 1D5Nb/bl/MJz4+rT1TBiqR4AsHKZ5bDPB3Uv4+BdqQA1Pwb4J4OpYEM6gXPdgEbKMTW1 sbfZkQ9F+ECze28XwemfcHKOcpmEbMOeRlXnWHxeqdHrOYyEuTIbsKMUiDWLPDWsXCUe Wp9uxo8j+5B8fQwDWFaY1G6ELpRwFHgfZ7l3CNb4WOzpylPshB2SkCbkhuLx9jAjynb5 MO7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u190si3470474oie.117.2019.12.12.10.08.18; Thu, 12 Dec 2019 10:08:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730314AbfLLSHc (ORCPT + 99 others); Thu, 12 Dec 2019 13:07:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:55324 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730305AbfLLSHc (ORCPT ); Thu, 12 Dec 2019 13:07:32 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7AE2D21556; Thu, 12 Dec 2019 18:07:31 +0000 (UTC) Date: Thu, 12 Dec 2019 13:07:29 -0500 From: Steven Rostedt To: Tom Zanussi Cc: Sven Schnelle , linux-trace-devel@vger.kernel.org, LKML Subject: Re: ftrace histogram sorting broken on BE architecures Message-ID: <20191212130729.05091d3a@gandalf.local.home> In-Reply-To: <1576092363.2833.20.camel@kernel.org> References: <20191211123316.GD12147@stackframe.org> <20191211103557.7bed6928@gandalf.local.home> <20191211110959.2baeb70f@gandalf.local.home> <1576082238.2833.8.camel@kernel.org> <20191211120051.711582ee@gandalf.local.home> <1576092363.2833.20.camel@kernel.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Dec 2019 13:26:03 -0600 Tom Zanussi wrote: > > Are they? I see in create_key_field: > > > > key_size = ALIGN(key_size, sizeof(u64)); > > > > Which to me seems that we'll have nothing smaller than sizeof(u64). > > > > Yeah, that makes them effectively u64 in this case, so I'd agree. Hi Tom, Does this mean it's good to go? It just passed my test suite, and I can send it to Linus now. -- Steve