Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1141885ybl; Thu, 12 Dec 2019 10:15:18 -0800 (PST) X-Google-Smtp-Source: APXvYqwX+y5FDAQvpLhpcT545F4hjKMFmtxY7hWsUjYnDoSOI1LqtNEcuRbI6MTmL7HQz8RzTqiN X-Received: by 2002:a05:6808:3ca:: with SMTP id o10mr5644660oie.14.1576174518236; Thu, 12 Dec 2019 10:15:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576174518; cv=none; d=google.com; s=arc-20160816; b=vUBQClgVX5hfRrexmVJ5uoSvwob/cSw82maTOuNPZtT5obwHiG+Pfd/0uhriTnIKM1 RKbl9uT9unVFIlWQUi4whqa7LyN5kp6ZR89kPYMbSouZ691eTwUHme/nm50za4gCAFGb 2Aw/1ZsNKbjuOvb35m8LB9mLD7vFVBD84OP1tlqJH+1AtxKJF+fj4IQDdxQAFM8ozgfM Zri2OPYpI/0kORUy9kwP7wo9YeF3FMs4tMeaLrk1rbwO48JvWlHjaKsU58T1+GDeRACM /3rJVIHbXMn7x3M1WUVp4tpoDKzfI8chCxC0S+AcBvMA41MlfKKH7CM5pyfrlWAeLekm aKBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Y1UiIVcuA3oFM0QnLqWtFP569EO3r+AI39JJJvdEsCM=; b=QqgEhlMbDIQQbhpow1URhRuVubFFvqoDP/t10I+SEsdMCivGnok0Qp7fIVKNtxp7Ba CdubmOR6X669kl5TyuNaEHpeJNoFeTXpQdklnxNGHpTi3B4wQPFyymgyGpoJHJ7L3SU5 7VcOeLTyWNpGV9DPE4u4vXx/VUwpKHfwHbx5bFjdC9bm5N81J4Q+G4T6RGn+UmKy687t eW/B9TsJ2z0VATzUA8aHIOMyVCWMqdKBhruOpSO/M4vdqCy/KG1wWYnYDWdmweTCgMMU 1UYtHn/mcZ8FxT11y0ccQr4TXmTHkdujDAdOtRMnMQe0Baw7u5V1LlSgvHoWtH7Nca1n 0xew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u190si3470474oie.117.2019.12.12.10.15.06; Thu, 12 Dec 2019 10:15:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730343AbfLLSOg (ORCPT + 99 others); Thu, 12 Dec 2019 13:14:36 -0500 Received: from isilmar-4.linta.de ([136.243.71.142]:56748 "EHLO isilmar-4.linta.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730080AbfLLSOf (ORCPT ); Thu, 12 Dec 2019 13:14:35 -0500 X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES Received: from light.dominikbrodowski.net (brodo.linta [10.1.0.102]) by isilmar-4.linta.de (Postfix) with ESMTPSA id D73D9200A85; Thu, 12 Dec 2019 18:14:33 +0000 (UTC) Received: by light.dominikbrodowski.net (Postfix, from userid 1000) id D092420AFD; Thu, 12 Dec 2019 19:14:26 +0100 (CET) From: Dominik Brodowski To: Alexander Viro , Linus Torvalds Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , Andrew Morton , Ingo Molnar , linux-kernel@vger.kernel.org Subject: [GIT PULL] remove ksys_mount() and ksys_dup() Date: Thu, 12 Dec 2019 19:14:17 +0100 Message-Id: <20191212181422.31033-1-linux@dominikbrodowski.net> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following changes since commit ae4b064e2a616b545acf02b8f50cc513b32c7522: Merge tag 'afs-fixes-20191211' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs (2019-12-11 18:10:40 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux.git remove-ksys-mount-dup for you to fetch changes up to 8243186f0cc7c57cf9d6a110cd7315c44e3e0be8: fs: remove ksys_dup() (2019-12-12 19:00:36 +0100) This small series replaces all in-kernel calls to the userspace-focused ksys_mount() and ksys_dup() with calls to kernel-centric functions: For each replacement of ksys_mount() with do_mount(), one needs to verify that the first and third parameter (char *dev_name, char *type) are strings allocated in kernelspace and that the fifth parameter (void *data) is either NULL or refers to a full page (only occurence in init/do_mounts.c::do_mount_root()). The second and fourth parameters (char *dir_name, unsigned long flags) are passed by ksys_mount() to do_mount() unchanged, and therefore do not require particular care. Moreover, instead of pretending to be userspace, the opening of /dev/console as stdin/stdout/stderr can be implemented using in-kernel functions as well. Thereby, ksys_dup() can be removed for good. --- Changes since the split-series patches[1,2]: - merge both series (on suggestion by Linus) - remove pointless cast (on suggestion by Linus) [1] https://lore.kernel.org/lkml/20191212135724.331342-1-linux@dominikbrodowski.net/ [2] https://lore.kernel.org/lkml/20191212140752.347520-1-linux@dominikbrodowski.net/ Thanks, Dominik ---------------------------------------------------------------- Dominik Brodowski (5): devtmpfs: use do_mount() instead of ksys_mount() initrd: use do_mount() instead of ksys_mount() init: use do_mount() instead of ksys_mount() init: unify opening /dev/console as stdin/stdout/stderr fs: remove ksys_dup() drivers/base/devtmpfs.c | 6 +++--- fs/file.c | 7 +------ fs/namespace.c | 10 ++-------- include/linux/device.h | 4 ++-- include/linux/initrd.h | 2 ++ include/linux/syscalls.h | 3 --- init/do_mounts.c | 30 +++++++++++++++++++++++------- init/do_mounts_initrd.c | 11 ++++------- init/main.c | 31 ++++++++++++++++++++++++++----- 9 files changed, 63 insertions(+), 41 deletions(-) -- 2.24.1