Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1163303ybl; Thu, 12 Dec 2019 10:34:42 -0800 (PST) X-Google-Smtp-Source: APXvYqzCRmQfFzm+g8MuLVLyteR7E8ClNWlEXKfHn/v1vvT2uEAMuHnFea0VdsUaWkVq/viIoIpg X-Received: by 2002:a9d:7ada:: with SMTP id m26mr10030441otn.111.1576175682517; Thu, 12 Dec 2019 10:34:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576175682; cv=none; d=google.com; s=arc-20160816; b=g4pCoOFC4aoUzq3pbYLadXKntZIMv0EU+f4lucEby1JryHqS14e5klfzXDPiXNtPOi EtbO7O7nXJKuquiNtnbzw1QugDaNmdpvqNEp/VjrjU6WA4wCDObDlzelRrs3nxLlpee7 sbrtJv2dcCQbtJBeEvFjoyNa8N7p/oAVoFax2fXTG+u+xwpX0dbIPtPoVy+eO8ZttwMd A+g531xv+jpyxuRxdRhJInDKiPahcQEA3tuVA1Cza636q2r89Gsx17PjeLi2OLw/2sZK RFpmmlHNLkWQd5Vawgo6N9EQv94awWxEfwLbm679S9koPLDhqO1S4MKLrXpLuJUkTYAX 8rlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=1vhjna/rh+rVgKI+zkzgMfp5mWRrD9pxqEOzOJXpA4Y=; b=HmZO1IXiyRRABQRQbiIcYn+W/sPnjG5L+CCZBQPd4ohQE090szc9FzdKQFusKbdGSl GWJiPPrOzjj88dBlH5tZhrM8sIMqzqXdWt2JETWntNdgTK83nd9Dcih+phiipSOQUqVb QNbtXyVcB581ms5ojYMP9E2GM4B4BE3s4PlZ/Ru9svJmYEy0lN5GS74RfS2XHaB2zE6z DTpxJ7ECdFJ63HkYvFRC3MxLXSsIA6sPEk+JN9TD2S8jIKKt84ZEHVbJxAtuSJQpZnE4 T4iFwrMM44d6AzBqWEwNaJTKfOYkCZxS+5/dSaLN1W8JWp/87/yMq/ynKsz5riy1V/3I +5UA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="kzsW8/3f"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d11si3574589oti.325.2019.12.12.10.34.30; Thu, 12 Dec 2019 10:34:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="kzsW8/3f"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730458AbfLLScp (ORCPT + 99 others); Thu, 12 Dec 2019 13:32:45 -0500 Received: from mail.skyhub.de ([5.9.137.197]:47250 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730211AbfLLSco (ORCPT ); Thu, 12 Dec 2019 13:32:44 -0500 Received: from zn.tnic (p200300EC2F0A5A0010289BED6992E3B4.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:5a00:1028:9bed:6992:e3b4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 62E201EC01AD; Thu, 12 Dec 2019 19:32:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1576175562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=1vhjna/rh+rVgKI+zkzgMfp5mWRrD9pxqEOzOJXpA4Y=; b=kzsW8/3fnaWojTpWx+xOZuFE5jkvWcgtWb0zHWdGQvHha8Z3n16k6oLdIOkrt3LZWH/mbE 40RXHatBBtsZbAG2t/5SMWP8ndSe6ntSi7+6wLxah6GSy4g0pqbbHSZpsh98GMHiVzGYvm Z5LGh7kWizRyKULfw1bLYt/9PqDVdYU= Date: Thu, 12 Dec 2019 19:32:41 +0100 From: Borislav Petkov To: Liran Alon Cc: Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Radim =?utf-8?B?S3LEjW3DocWZ?= , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Tony Luck , Tony W Wang-oc , Len Brown , Shuah Khan , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-edac@vger.kernel.org, linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org, Jarkko Sakkinen Subject: Re: [PATCH v4 11/19] x86/cpu: Print VMX flags in /proc/cpuinfo using VMX_FEATURES_* Message-ID: <20191212183241.GI4991@zn.tnic> References: <20191128014016.4389-1-sean.j.christopherson@intel.com> <20191128014016.4389-12-sean.j.christopherson@intel.com> <20191212122646.GE4991@zn.tnic> <4A24DE75-4E68-4EC6-B3F3-4ACB0EE82BF0@oracle.com> <17c6569e-d0af-539c-6d63-f4c07367d8d1@redhat.com> <20191212174357.GE3163@linux.intel.com> <52dd758d-a590-52a6-4248-22d6852b75cd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 12, 2019 at 07:52:55PM +0200, Liran Alon wrote: > Why should CPU VMX features be treated differently than standard CPUID > deduced features? CPU SVM features are also present in /proc/cpuinfo > today (Because they are deduced from CPUID leafs). So it should be > similar. Well, VMX features are not CPUID bits apparently because . And Intel hw folk will give you a bunch, I bet. So Sean needs to do all this dancing to get them to be more usable to other kernel code. SVM feature bits are proper CPUID bits and this is what the cpufeatures glue does - mirro CPUID bits, mainly. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette