Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1192669ybl;
        Thu, 12 Dec 2019 11:05:02 -0800 (PST)
X-Google-Smtp-Source: APXvYqxVEDGA1HUdrpXSUJCXPOnWh3e2gAQSqyR8mgdGoDqfAkWUu2oZWJBAFyYOmg+pXi+lBwuf
X-Received: by 2002:a54:468b:: with SMTP id k11mr5824070oic.134.1576177502727;
        Thu, 12 Dec 2019 11:05:02 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1576177502; cv=none;
        d=google.com; s=arc-20160816;
        b=f5cBt1KIWCbNUmH8ZLaDGRPL4wmkgE4pzuNrk9owTSOOOylj6y4GBy4bO4u3PH8y6H
         Rc4INIY2f3uDIkGhGn9tCBfGWZ02N0Jxkk30eWJZKoFQwv7frMLJ+YwJVQqPaje3Qud6
         EwfdZCzTQRloJmrpOoTmZxMn/9cT+R/P7De/hKCMRerYw35px3+OoNWevPcj0T13jW7P
         O1rw5Pmw2UCsp399lAOF6f3hFr3jt8rfPmanvO270zj8Il+Ry6Un6hFB41REJq4bzu2X
         eDNtGYge659t532OIBTSc6wo7YqVSBpX2TqNHm4Gi0xeJJShfgM0hsnwQw6GK8WedCox
         5YhA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=Mpwz8OtwoJkD7+VIkqlYVMGMG6D1uBPXrLTV5X9FQmc=;
        b=C2dW1iACFuGIWq/vS5aVJfTw1tFJQKnusXi0rVYyH0ahOhl8qUSNT5LFQyKtMxXN7q
         7t1mDmTkJ5XsvjLMCngr8xcE+1XjovOq8KDgxYeih+DkWcdq/MMUbGfHgqZst/plsXRN
         wd9tqLAFVFnAvgKskSVygX5TH47BbVLLtS8HuOb2Ak9oDXJHKBrj2xYl6Xr8WwL4h+Cn
         KHA1AFau8kFK3qd9TTC/pMDGDe0mADE5pw3GgSPRKRtkluAPVfQRutm6m5I31ABQx1qF
         UuSNWJTOWkXHzczbj6opg7keT69EN8BqrujNzLXerwygfG7K8GsZ3JVxY1vP71eScJ8d
         vpKQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id i12si4080079otk.215.2019.12.12.11.04.43;
        Thu, 12 Dec 2019 11:05:02 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730611AbfLLTD4 (ORCPT <rfc822;dafubiji@gmail.com> + 99 others);
        Thu, 12 Dec 2019 14:03:56 -0500
Received: from shards.monkeyblade.net ([23.128.96.9]:42702 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1730168AbfLLTD4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 12 Dec 2019 14:03:56 -0500
Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 6DCB6153DFC91;
        Thu, 12 Dec 2019 11:03:55 -0800 (PST)
Date:   Thu, 12 Dec 2019 11:03:54 -0800 (PST)
Message-Id: <20191212.110354.354662228217900367.davem@davemloft.net>
To:     info@metux.net
Cc:     linux-kernel@vger.kernel.org, jchapman@katalix.com,
        netdev@vger.kernel.org
Subject: Re: [PATCH] net: l2tp: remove unneeded MODULE_VERSION() usage
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20191212133613.25376-1-info@metux.net>
References: <20191212133613.25376-1-info@metux.net>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 12 Dec 2019 11:03:55 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Enrico Weigelt, metux IT consult" <info@metux.net>
Date: Thu, 12 Dec 2019 14:36:13 +0100

> Remove MODULE_VERSION(), as it isn't needed at all: the only version
> making sense is the kernel version.
> 
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>

Is there a plan to remove MODULE_VERSION across the entire kernel tree?

Where is that documented?

Otherwise what gave you the reason to make this change in the first place?

No context, no high level explanation of what's going on, so it's hard
to review and decide whether to accept your change sorry.

At the least, you will have to write a more complete commit log message.