Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp191518ybl; Thu, 12 Dec 2019 16:23:20 -0800 (PST) X-Google-Smtp-Source: APXvYqxoEeqYQe/Py9bAOXpyVBtuq1Xo2NMKfKgDhyz4Q7gf3OYJ6G5LiTEcNsgFexV5HGox4xRR X-Received: by 2002:a9d:73ca:: with SMTP id m10mr11245818otk.289.1576196600687; Thu, 12 Dec 2019 16:23:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576196600; cv=none; d=google.com; s=arc-20160816; b=yumREDEeDCihxHaVa+j77ynYDK9H4cN3jxpiLubBlRhnlVd4SBOwbDl2Bj6TA4OU0K evT3H+zqZ/TRFafB7YyhfXT2zoa0E91xov5zkTOSFvxoXfNOCqKfVW0SgGV8OxvbKAC7 2XYDittq8L7ARXDy0znS/ZFIw4oj//XmBo7KTNIwkYbOOoaxTwRGJ2yGRUa8nfmUAjOn S8tf0v3piYzxpPp3FIc+fR+wOR0BywfsQd4BURuCLf9e8YiBvd0PkoAVR+hetHzgJfaU dxz1z4FyR89FMj6M/xP8jboIPYh9CsEvOZJG716nuTpRjK03CV+8uC34SaGLgpSBLdsv RZtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date; bh=I7mteVAchHNtyA2SO5WTkISV2PL3y1Ej0VfdMnSoT0Y=; b=JSezWw7S7ulZuqXiFiACvHftZ3ERVDgBNPoJBpcN+CM1hShvnvSp+oXNDw5sBJZytm yYM2TJ15dIfsagfHDRhNQmwkfP+4XPLaBINnwUmsGOEz7Rq/G8nhrQVLndXve8Rhvhu0 kHNj6FJxPedmTED3oif4aN7qH7qIXDjc15ksKee427PCWjiyedEYa7qoGaRWUQ1jzFgZ euTyWaR5lAD9uU74VHCRQCvktSonMvp19NtkVD7PfvH/0x7jEdtRzo9rjMKI09zc0QLR 0pIEF2i+E44su2Ley+m8erUnxdGQ8kxIudhxs4PGeiYZ/uVrsXri7u8/qq5LnXCUWoN7 mmAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 123si4474134oif.177.2019.12.12.16.23.04; Thu, 12 Dec 2019 16:23:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731342AbfLMACp (ORCPT + 99 others); Thu, 12 Dec 2019 19:02:45 -0500 Received: from relmlor1.renesas.com ([210.160.252.171]:55604 "EHLO relmlie5.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731107AbfLMACp (ORCPT ); Thu, 12 Dec 2019 19:02:45 -0500 Date: 13 Dec 2019 09:02:43 +0900 X-IronPort-AV: E=Sophos;i="5.69,307,1571670000"; d="scan'208";a="34277192" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie5.idc.renesas.com with ESMTP; 13 Dec 2019 09:02:43 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id ECC7341277A1; Fri, 13 Dec 2019 09:02:42 +0900 (JST) Message-ID: <87o8wd5bz1.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Geert Uytterhoeven Cc: Yoshinori Sato , Rich Felker , Andrew Morton , Linux-sh list , Linux Kernel Mailing List Subject: Re: [PATCH] sh: add missing DECLARE_EXPORT() for __ashiftrt_r4_2x In-Reply-To: References: <87v9qmcloc.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert Thank you for your review > > __ashiftrt_r4_2x is used from kernel module. > > We need DECLARE_EXPORT(), otherwise we will get compile error. > > > > ERROR: "__ashiftrt_r4_25" [drivers/iio/pressure/bmp280.ko] undefined! > > ERROR: "__ashiftrt_r4_26" [drivers/iio/dac/ad5764.ko] undefined! > > ERROR: "__ashiftrt_r4_26" [drivers/iio/accel/mma7660.ko] undefined! > > ERROR: "__ashiftrt_r4_25" [drivers/iio/accel/dmard06.ko] undefined! > > ERROR: "__ashiftrt_r4_26" [drivers/iio/accel/bma220_spi.ko] undefined! > > ERROR: "__ashiftrt_r4_25" [drivers/crypto/hisilicon/sec/hisi_sec.ko] undefined! > > ERROR: "__ashiftrt_r4_26" [drivers/rtc/rtc-x1205.ko] undefined! > > ERROR: "__ashiftrt_r4_25" [drivers/rtc/rtc-pcf85063.ko] undefined! > > ERROR: "__ashiftrt_r4_25" [drivers/rtc/rtc-pcf2123.ko] undefined! > > ERROR: "__ashiftrt_r4_25" [drivers/input/tablet/gtco.ko] undefined! > > ERROR: "__ashiftrt_r4_26" [drivers/input/mouse/psmouse.ko] undefined! > > ERROR: "__ashiftrt_r4_28" [drivers/input/mouse/psmouse.ko] undefined! > > ERROR: "__ashiftrt_r4_28" [drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.ko] undefined! > > ERROR: "__ashiftrt_r4_28" [fs/udf/udf.ko] undefined! (snip) > Wouldn't it make sense to just add all of them (__ashiftrt_r4_[0-32])? Oops, there are more missing __ashiftrt_r4_xx Thank you for pointing it. will post v2 Thank you for your help !! Best regards --- Kuninori Morimoto