Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191210022742.822686-1-jim.cromie@gmail.com> <20191210022742.822686-7-jim.cromie@gmail.com>
 <26c09145-b3d2-52e0-4c31-bfb11a78be31@akamai.com>
In-Reply-To: <26c09145-b3d2-52e0-4c31-bfb11a78be31@akamai.com>
From:   jim.cromie@gmail.com
Date:   Thu, 12 Dec 2019 18:35:01 -0700
Message-ID: <CAJfuBxwggurCvoUq23ZVcDJ1P6TaPVvCvAWkmxw9p9__sx8OTQ@mail.gmail.com>
Subject: Re: [PATCH v4 06/16] dyndbg: fix a BUG_ON in ddebug_describe_flags
To:     Jason Baron <jbaron@akamai.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, akpm@linuxfoundation.org,
        Greg KH <gregkh@linuxfoundation.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        kbuild test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Dec 10, 2019 at 12:58 PM Jason Baron <jbaron@akamai.com> wrote:
> >
> > +struct flagsbuf { char buf[12]; };   /* big enough to hold all the flags */
>
>
> ARRAY_SIZE(opt_array) + 1
>
> max number of flags + string termination.
>


Ok  12 is generous.
v2 had xyz flags, for a total of 9+1 flag chars.
figured a multiple of 4 was sensible, almost went to 16
then didnt think about it anymore.