Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 1/2] IMA: Define workqueue for early boot "key"
 measurements
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
        linux-integrity@vger.kernel.org
Cc:     eric.snowberg@oracle.com, dhowells@redhat.com,
        mathew.j.martineau@linux.intel.com, matthewgarrett@google.com,
        sashal@kernel.org, jamorris@linux.microsoft.com,
        linux-kernel@vger.kernel.org, keyrings@vger.kernel.org
Date:   Thu, 12 Dec 2019 21:32:57 -0500
In-Reply-To: <6e0dad33-66f9-4807-d08d-ff30396cec5e@linux.microsoft.com>
References: <20191213004250.21132-1-nramas@linux.microsoft.com>
         <20191213004250.21132-2-nramas@linux.microsoft.com>
         <1576202134.4579.189.camel@linux.ibm.com>
         <6e0dad33-66f9-4807-d08d-ff30396cec5e@linux.microsoft.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Message-Id: <1576204377.4579.206.camel@linux.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2019-12-12 at 17:59 -0800, Lakshmi Ramasubramanian wrote:
> On 12/12/19 5:55 PM, Mimi Zohar wrote:
> >> +/*
> >> + * ima_process_queued_keys() - process keys queued for measurement
> >> + *
> >> + * This function sets ima_process_keys to true and processes queued keys.
> >> + * From here on keys will be processed right away (not queued).
> >> + */
> >> +void ima_process_queued_keys(void)
> >> +{
> >> +	struct ima_key_entry *entry, *tmp;
> >> +	LIST_HEAD(temp_ima_keys);
> >> +
> >> +	if (ima_process_keys)
> >> +		return;
> >> +
> >> +	/*
> >> +	 * To avoid holding the mutex when processing queued keys,
> >> +	 * transfer the queued keys with the mutex held to a temp list,
> >> +	 * release the mutex, and then process the queued keys from
> >> +	 * the temp list.
> >> +	 *
> >> +	 * Since ima_process_keys is set to true, any new key will be
> >> +	 * processed immediately and not be queued.
> >> +	 */
> >> +	INIT_LIST_HEAD(&temp_ima_keys);
> >> +
> >> +	mutex_lock(&ima_keys_mutex);
> > 
> > Don't you need a test here, before setting ima_process_keys?
> > 
> > 	if (ima_process_keys)
> > 		return;
> > 
> > Mimi
> 
> That check is done before the comment - at the start of 
> ima_process_queued_keys().

The first test prevents taking the mutex unnecessarily.

Mimi


> +void ima_process_queued_keys(void)
> +{
> +	struct ima_key_entry *entry, *tmp;
> +	LIST_HEAD(temp_ima_keys);
> +
> +	if (ima_process_keys)
> +		return;
> 
> thanks,
>   -lakshmi