Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 1/2] IMA: Define workqueue for early boot "key"
 measurements
To:     Mimi Zohar <zohar@linux.ibm.com>, linux-integrity@vger.kernel.org
Cc:     eric.snowberg@oracle.com, dhowells@redhat.com,
        mathew.j.martineau@linux.intel.com, matthewgarrett@google.com,
        sashal@kernel.org, jamorris@linux.microsoft.com,
        linux-kernel@vger.kernel.org, keyrings@vger.kernel.org
References: <20191213004250.21132-1-nramas@linux.microsoft.com>
 <20191213004250.21132-2-nramas@linux.microsoft.com>
 <1576202134.4579.189.camel@linux.ibm.com>
From:   Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
Message-ID: <6e0dad33-66f9-4807-d08d-ff30396cec5e@linux.microsoft.com>
Date:   Thu, 12 Dec 2019 17:59:11 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <1576202134.4579.189.camel@linux.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 12/12/19 5:55 PM, Mimi Zohar wrote:
>> +/*
>> + * ima_process_queued_keys() - process keys queued for measurement
>> + *
>> + * This function sets ima_process_keys to true and processes queued keys.
>> + * From here on keys will be processed right away (not queued).
>> + */
>> +void ima_process_queued_keys(void)
>> +{
>> +	struct ima_key_entry *entry, *tmp;
>> +	LIST_HEAD(temp_ima_keys);
>> +
>> +	if (ima_process_keys)
>> +		return;
>> +
>> +	/*
>> +	 * To avoid holding the mutex when processing queued keys,
>> +	 * transfer the queued keys with the mutex held to a temp list,
>> +	 * release the mutex, and then process the queued keys from
>> +	 * the temp list.
>> +	 *
>> +	 * Since ima_process_keys is set to true, any new key will be
>> +	 * processed immediately and not be queued.
>> +	 */
>> +	INIT_LIST_HEAD(&temp_ima_keys);
>> +
>> +	mutex_lock(&ima_keys_mutex);
> 
> Don't you need a test here, before setting ima_process_keys?
> 
> 	if (ima_process_keys)
> 		return;
> 
> Mimi

That check is done before the comment - at the start of 
ima_process_queued_keys().

+void ima_process_queued_keys(void)
+{
+	struct ima_key_entry *entry, *tmp;
+	LIST_HEAD(temp_ima_keys);
+
+	if (ima_process_keys)
+		return;

thanks,
  -lakshmi