Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\))
Subject: Re: [PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree
 bindings for QCA6390
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <ab0557bcacdae61027b775f440145b05@codeaurora.org>
Date:   Fri, 13 Dec 2019 08:37:17 +0100
Cc:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, bgodavar@codeaurora.org,
        linux-bluetooth-owner@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <5F24A10B-D0DB-4FE7-8EB1-1028671599FB@holtmann.org>
References: <0101016ef8b923bc-5760b40c-1968-4992-9186-8e3965207236-000000@us-west-2.amazonses.com>
 <24B540FF-C627-4DF9-9077-247A4A6A3605@holtmann.org>
 <ab0557bcacdae61027b775f440145b05@codeaurora.org>
To:     Rocky Liao <rjliao@codeaurora.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Rocky,

>>> Add compatible string for the Qualcomm QCA6390 Bluetooth controller
>>> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
>>> ---
>>> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 1 +
>>> 1 file changed, 1 insertion(+)
>>> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>> index 68b67d9db63a..87b7f9d22414 100644
>>> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>> @@ -10,6 +10,7 @@ device the slave device is attached to.
>>> Required properties:
>>> - compatible: should contain one of the following:
>>>   * "qcom,qca6174-bt"
>>> +   * "qcom,qca6390-bt"
>>>   * "qcom,wcn3990-bt"
>>>   * "qcom,wcn3998-bt"
>> now I am confused. Is this a DT platform or ACPI or both?
> We need to support both, should I update ACPI part in this doc as well?

this patch is fine the, but the other one would be better if you split it in DT and ACPI support.

Regards

Marcel