Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 13 Dec 2019 08:23:36 +0000
From:   Lee Jones <lee.jones@linaro.org>
To:     Orson Zhai <orson.zhai@spreadtrum.com>
Cc:     Rob Herring <robh@kernel.org>, Orson Zhai <orson.zhai@unisoc.com>,
        Arnd Bergmann <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        baolin.wang@unisoc.com, kevin.tang@unisoc.com,
        Chunyan Zhang <chunyan.zhang@unisoc.com>,
        liangcai.fan@unisoc.com, orsonzhai@gmail.com
Subject: Re: [PATCH v3] mfd: syscon: Add arguments support for syscon
 reference
Message-ID: <20191213082336.GD3468@dell>
References: <1576037311-6052-1-git-send-email-orson.zhai@unisoc.com>
 <CAK8P3a0244jKrEop2rHVyJZ57h4A9+mqb-5g-wLUSfR2G1svwg@mail.gmail.com>
 <20191213024935.GD9271@lenovo>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20191213024935.GD9271@lenovo>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 13 Dec 2019, Orson Zhai wrote:

> Hi Lee and Rob,
> 
> On Wed, Dec 11, 2019 at 02:55:39PM +0100, Arnd Bergmann wrote:
> > On Wed, Dec 11, 2019 at 5:09 AM Orson Zhai <orson.zhai@unisoc.com> wrote:
> > >
> > > There are a lot of similar global registers being used across multiple SoCs
> > > from Unisoc. But most of these registers are assigned with different offset
> > > for different SoCs. It is hard to handle all of them in an all-in-one
> > > kernel image.
> > >
> > > Add a helper function to get regmap with arguments where we could put some
> > > extra information such as the offset value.
> > >
> > > Signed-off-by: Orson Zhai <orson.zhai@unisoc.com>
> > > Tested-by: Baolin Wang <baolin.wang@unisoc.com>
> >
> > Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> 
> Does this patch look good to be applied?
> 
> Or if any comments please feel free to send to me.

If it looks good to Arnd, it looks good to me.

I have quite a number of reviews to get through first though, please
bear with me and resist the urge to nag.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog