Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp579010ybl; Fri, 13 Dec 2019 01:01:53 -0800 (PST) X-Google-Smtp-Source: APXvYqyzlLp02F90I7czNmQVPjpF+BOb9AnMjomsY8xmN4qO2c0lav4GdsDqovZRf9lUjKUODKSH X-Received: by 2002:a9d:549:: with SMTP id 67mr12645922otw.175.1576227713706; Fri, 13 Dec 2019 01:01:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576227713; cv=none; d=google.com; s=arc-20160816; b=MquKRExRoI/artHXZoXeDhtuVWeDTHY57seZiZA2OR8C5VKh660tZhjHEvQlbaFpmU 5H1cP2CpDZPveAdAA4yOMwU+QtwUa47HxEEDrVxVyp4/sa20KgHqQhOS4KVg58TcVznq n2qri1rv5twI79/y33mE9FN71FQ3dZW93EfA3gAK4vZ8Rz1Ti8pd7W2YW7eJBDyrZY4+ O9UANMJ02PlpCW56BNPp57BjvdsBGjGSp6JGWxDM5x0X3SE0LsI/lUdJSfE6Jj+oxTwD uCbdw0nqlxPFkBe7yqL4ZGfggaNXUXrnVX31J15z65mtoiOGkfFp9A+C8+4wj4Z8/FFq xg4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=3jZaiuryeY6BJqpI9DZsPsi9h5lh5G3/b2/dzF6oMFQ=; b=na+QwwKsOseJ3pQt8O/zEVfclu6h/3yXkZ+lXgq0KZHQLH3jXRbpPmNoT090YTR4Zk 5lOswEzlgoRyBoCPcA2uOKvU/LDF5NrLoqHRnfg8Iu1MqYZtKNQkrwc+hYfo6PyhlHfE jCvm4RcAnl3KzPgCO0MdpJZ7sHhcTVZktvwcFV6Ow3bOXo3BYP2qjf3U00GWYW4CTbuI 1Ut+/dv3t0jB7kQpiy3uAfk6/kDsQTl7ZjYdwP5erp7pEjYBYzL/ThAH2jSCo4KoY+yE 25GByKWfHt47NndPf+6z6abeCEC6/5GqPfXZD2IniklfMk6E90DObUnAFL0UIkzO5/oq I/1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o6si4810183otk.201.2019.12.13.01.01.41; Fri, 13 Dec 2019 01:01:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726141AbfLMJAu (ORCPT + 99 others); Fri, 13 Dec 2019 04:00:50 -0500 Received: from mx2.suse.de ([195.135.220.15]:48566 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725747AbfLMJAt (ORCPT ); Fri, 13 Dec 2019 04:00:49 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 115DDB1FC; Fri, 13 Dec 2019 09:00:48 +0000 (UTC) Subject: Re: [PATCH] xen-blkback: prevent premature module unload To: Paul Durrant , xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Konrad Rzeszutek Wilk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jens Axboe References: <20191210145305.6605-1-pdurrant@amazon.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <0a83ebaa-40b8-55f0-cff0-5aaf7bc14e98@suse.com> Date: Fri, 13 Dec 2019 10:00:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20191210145305.6605-1-pdurrant@amazon.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.12.19 15:53, Paul Durrant wrote: > Objects allocated by xen_blkif_alloc come from the 'blkif_cache' kmem > cache. This cache is destoyed when xen-blkif is unloaded so it is > necessary to wait for the deferred free routine used for such objects to > complete. This necessity was missed in commit 14855954f636 "xen-blkback: > allow module to be cleanly unloaded". This patch fixes the problem by > taking/releasing extra module references in xen_blkif_alloc/free() > respectively. > > Signed-off-by: Paul Durrant Pushed to xen/tip.git for-linus-5.5b Juergen