Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp608651ybl; Fri, 13 Dec 2019 01:36:34 -0800 (PST) X-Google-Smtp-Source: APXvYqzWwRTh4A5dfn/UtrQBgMQZuNT+oFAqgCLWdu3T8wHJ7dvuxJJdBTE9glr4F9PXLkg5ZCC2 X-Received: by 2002:a05:6830:1047:: with SMTP id b7mr14157583otp.77.1576229794007; Fri, 13 Dec 2019 01:36:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576229793; cv=none; d=google.com; s=arc-20160816; b=xsUIn1+zcWLPQAFNc1afZYnljZ9jIEX1bGCNfoahDIGCnr7PruJ450UTi6AX27DyEQ f9/OKbjUZjXcHK4BqYZvYNyYSfS51G6I/h8RCaG8P0C3A0vYDLCvN4cGwUQkP9WbbYnh GyNPCbO9jKNVHc7TeaaFcT8gzsWNe66ZhD7LxOvBd46mUjqEDtJw7noqaZZK7BE/d1ug I9fU3WYCARKnA7g2YuwDi2AEWE5K9uVfsQVkGEhEOx02bQaQDu/n1Di2bI+BlrOhZKtm X7VVPtmcAgY5bq7HYLFHEAQHLRdAe+bgPmBmcS5+uLn5XstTNCuG6IDKq9oTNULjBY30 YpOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=I24v40mR5rRr9vvDsi06QxjcuzANgRNkq1gmA1yrQ7U=; b=biojoQCtscq0WGs1bOmngmuhGYLcokSvUlVlaJQGEih0v39S48NogIOKcm2WjTolKi C4rgY/9pq7AFKs3aDsv6lDIidpKnSL82jufNJ4YZ+LNlHQKI2IgTI0ExhkgeiLLVG/u8 oNi3rj4OTltilowdFynKnhs0hBBYcZ3BemAj0p42Umyo9He6G3JZ2gmvIDbzCu3Mb0N6 WO0QEA4JC8LMvML8OvTHDj0BtUSLVTZhjK8/ybvlxoSap/M62U+ebh9EqfwADCb5DLb1 /z+mA1ZtaYVlCHWpLtRoIL/XAZgzoU4KMT23cXVghEP/nqOcqDEcjIfyITWAnevTTSzg c11A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x126si4660566oix.53.2019.12.13.01.36.22; Fri, 13 Dec 2019 01:36:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726642AbfLMJfE (ORCPT + 99 others); Fri, 13 Dec 2019 04:35:04 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:57596 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726090AbfLMJfE (ORCPT ); Fri, 13 Dec 2019 04:35:04 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 4A6B61C246E; Fri, 13 Dec 2019 10:35:02 +0100 (CET) Date: Fri, 13 Dec 2019 10:35:01 +0100 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Thinh Nguyen , Felipe Balbi , Sasha Levin Subject: Re: [PATCH 4.19 099/243] usb: dwc3: debugfs: Properly print/set link state for HS Message-ID: <20191213093501.GA27976@amd> References: <20191211150339.185439726@linuxfoundation.org> <20191211150345.799359877@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LQksG6bCIzRHxTLp" Content-Disposition: inline In-Reply-To: <20191211150345.799359877@linuxfoundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2019-12-11 16:04:21, Greg Kroah-Hartman wrote: > From: Thinh Nguyen >=20 > [ Upstream commit 0d36dede457873404becd7c9cb9d0f2bcfd0dcd9 ] >=20 > Highspeed device and below has different state names than superspeed and > higher. Add proper checks and printouts of link states for highspeed and > below. This is debugfs, so I don't believe it was suitable for stable in the first place, but.... > + case DWC3_LINK_STATE_RESUME: > + return "Resume"; > + default: > + return "UNKNOWN link state\n"; > + } You may want to delete \n here, it will be duplicated if this ever triggers. Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --LQksG6bCIzRHxTLp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl3zW0UACgkQMOfwapXb+vICpQCfQHzNyEi8pbT+Xw6OnRhG7h07 jKIAnjd/cwx9RAtSs75/JPIETKGhNhwn =D5ZS -----END PGP SIGNATURE----- --LQksG6bCIzRHxTLp--