Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 13 Dec 2019 10:42:13 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Kevin Tang <kevin3.tang@gmail.com>
Cc:     airlied@linux.ie, daniel@ffwll.ch, orsonzhai@gmail.com,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        zhang.lyra@gmail.com, baolin.wang@linaro.org
Subject: Re: [PATCH RFC 1/8] dt-bindings: display: add Unisoc's drm master
 bindings
Message-ID: <20191213094213.5eetnprhwolssdbp@gilmour.lan>
References: <1575966995-13757-1-git-send-email-kevin3.tang@gmail.com>
 <1575966995-13757-2-git-send-email-kevin3.tang@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ydjubsryd27sfjsx"
Content-Disposition: inline
In-Reply-To: <1575966995-13757-2-git-send-email-kevin3.tang@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ydjubsryd27sfjsx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

On Tue, Dec 10, 2019 at 04:36:28PM +0800, Kevin Tang wrote:
> From: Kevin Tang <kevin.tang@unisoc.com>
>
> The Unisoc DRM master device is a virtual device needed to list all
> DPU devices or other display interface nodes that comprise the
> graphics subsystem
>
> Cc: Orson Zhai <orsonzhai@gmail.com>
> Cc: Baolin Wang <baolin.wang@linaro.org>
> Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
> ---
>  Documentation/devicetree/bindings/display/sprd/drm.txt | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/sprd/drm.txt
>
> diff --git a/Documentation/devicetree/bindings/display/sprd/drm.txt b/Documentation/devicetree/bindings/display/sprd/drm.txt
> new file mode 100644
> index 0000000..7327b9e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/sprd/drm.txt
> @@ -0,0 +1,18 @@
> +Unisoc DRM master device
> +================================
> +
> +The Unisoc DRM master device is a virtual device needed to list all
> +DPU devices or other display interface nodes that comprise the
> +graphics subsystem.
> +
> +Required properties:
> +- compatible: Should be "sprd,display-subsystem"
> +- ports: Should contain a list of phandles pointing to display interface port
> +  of DPU devices.
> +
> +example:
> +
> +display-subsystem {
> +	compatible = "sprd,display-subsystem";
> +	ports = <&dpu_out>;
> +};

You should be using YAML schemas to describe your bindings nowadays.

Also, I'm not sure about how the display engine (and its component) is
going to be integrated into the SoCs, but usually have the name of the
first SoC to use it is a good practice in the case where there's a
second generation of display engine coming up in the future.

Maxime

--ydjubsryd27sfjsx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXfNc9QAKCRDj7w1vZxhR
xWjCAP9+RHPQU7IQY7UgNoGRVTC9xxrprwGFIvhh+jpm/mA2CwD/a/yUzjPw2Pim
8CJuodPMEdclpB4AlTUXTO2caVatRQ8=
=8l90
-----END PGP SIGNATURE-----

--ydjubsryd27sfjsx--