Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp616962ybl; Fri, 13 Dec 2019 01:47:13 -0800 (PST) X-Google-Smtp-Source: APXvYqxQZELbDhYmrlyqBXRxmsnqCGGifEz1DeQ6//ZEcmsUTZdz1p21AP4skX/2nKQSijfwXy8A X-Received: by 2002:a9d:6005:: with SMTP id h5mr14262634otj.153.1576230433683; Fri, 13 Dec 2019 01:47:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576230433; cv=none; d=google.com; s=arc-20160816; b=xdELq+P/2yRZ8UrgxQWkkZccYwpu/XwnkDLBNgM+BVuVK1W1cGISksEQ8Wx54CgpYF QW6QGBakoyvQzfSDC6WRQbadBt64rAgx0Fr+5DImMtTagX0o88hrAg3thcePuXxq2LBF J+WQ7kO976QnGcrI9JSI5uxdEjCD7QLX/tsmUt3VzZgnfN7TMuEO4HXqS55SbrjByMe/ 4tc4mdLpyFt9sL4Bb9e1fFdDsVPSiAIn6EoWnDpm1B2FHT/zrMhIbgExsJ7J+wf8NxC9 mxsqpaTYlpHmqPqbcPF3WwXo2dxaWctlHKNhJsm3rMT1OixeOj9jp66gjqHBkvCNUbOK EvEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature:dkim-signature; bh=9EWMZmsphQyg/+dC9Cq4JFD2u/5w4AH6ycvkMlNzRqs=; b=ALc6NDJLlZIx58ep+w0RH6jX2QW39wU3Lg1AvMO1eQH/3ygzHDHTa7HSHTuVeTV6No FInUWDOWxVQXXOSEbR0FhollkmqxWJStS92j76FIquNtQb56h4zKb9oajlnyDAzJKK+2 qBp0euNoVhYCsbl5NPt5p1itBbRU/r0aX9ZgkDRT29ei4J4+DKOmZfBsSeWK3ZyoHFcD h3jM1i/7durf8UPOQqLJa21tSRD1G4ryMeOdYanwGAjNDO8A0zAJuD0DvVabneiEums/ tSQE0sDjegOmB3w4Jwh55sG+IChhygsxJm+MTtpfuPHdvKQEqI5KsO16CPQqxPeKWAPj hbgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm1 header.b=MilBJvex; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=Japy6OMw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q28si311600oij.149.2019.12.13.01.47.01; Fri, 13 Dec 2019 01:47:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm1 header.b=MilBJvex; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=Japy6OMw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726016AbfLMJqN (ORCPT + 99 others); Fri, 13 Dec 2019 04:46:13 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:42423 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725793AbfLMJqN (ORCPT ); Fri, 13 Dec 2019 04:46:13 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id EC6912227E; Fri, 13 Dec 2019 04:46:11 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 13 Dec 2019 04:46:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=9EWMZmsphQyg/+dC9Cq4JFD2u/5 w4AH6ycvkMlNzRqs=; b=MilBJvexN+qXkJ2br9gsNvcl2GjH2hyiOE1MPIn1i5X v1RJesDk/0x1g6jx4Lhkz6O1fnXZTZdVE6SfTRIV6CVUkzvuhtrdm60esIXZ1sT+ KAs0rymtujne2s6fInhxnh+yl5siIqHOuJSLG2Az9I0TAyf3mGse6DO9nVcjZ19X 22nxK0guiBQ3nvPcs27EaGxEzJKUjSVh1F04YR7NknrPtyQUXjJjGZ3cv7TcWsOr FSdBBHmuc0SbY2hYq3qtYGWleZWiYeHgSi5D3BaMsKuyjkLAofVUTVc364cCzy1S /BV4e3UF6B/d/8g7jRschHk/xKf7bQ+jXGV+ThSov/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=9EWMZm sphQyg/+dC9Cq4JFD2u/5w4AH6ycvkMlNzRqs=; b=Japy6OMw0fPVxppihyo5hf +SiecAg6VDNxj0NWEpiwHOAzg4oA9cKGZ8E+GFM9uKGdM2tGZpAYbC5RooqnaUd+ k5gFx+/XvPK1mfcCgdN1vI4RHfFQR4VqZmVvMjSXHW55pDvblPLM1hGqfpL4MPBN 8g8RA/OAn8YwNpZxCIJlUwfUor4ZmxazJZNyqosYw/YIDanPfh1fYvxxOslqllkw U3FCx6toSwN8jYoVchHBXphNYc5zCZuix0JZvEZl/wMJEDfSZJJzstm/+ICvwXB6 HmBBEgbLBuinYaM1K0xwiWAwBMCKxJ5ybMpIDHSJqTzYAw/fZzlqnvQiVpCxbtfw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudelledgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecukfhppeeltd drkeelrdeikedrjeeinecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggv rhhnohdrthgvtghhnecuvehluhhsthgvrhfuihiivgepvd X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id BB6F680063; Fri, 13 Dec 2019 04:46:10 -0500 (EST) Date: Fri, 13 Dec 2019 10:46:08 +0100 From: Maxime Ripard To: Kevin Tang Cc: airlied@linux.ie, daniel@ffwll.ch, orsonzhai@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, zhang.lyra@gmail.com, baolin.wang@linaro.org Subject: Re: [PATCH RFC 5/8] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings Message-ID: <20191213094608.awut27zbutuxhlsv@gilmour.lan> References: <1575966995-13757-1-git-send-email-kevin3.tang@gmail.com> <1575966995-13757-6-git-send-email-kevin3.tang@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6zgxd3we6mnaxudq" Content-Disposition: inline In-Reply-To: <1575966995-13757-6-git-send-email-kevin3.tang@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6zgxd3we6mnaxudq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 10, 2019 at 04:36:32PM +0800, Kevin Tang wrote: > From: Kevin Tang > > Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY) > support for Unisoc's display subsystem. > > Cc: Orson Zhai > Cc: Baolin Wang > Cc: Chunyan Zhang > Signed-off-by: Kevin Tang > --- > .../devicetree/bindings/display/sprd/dphy.txt | 49 ++++++++++++++++ > .../devicetree/bindings/display/sprd/dsi.txt | 68 ++++++++++++++++++++++ > 2 files changed, 117 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/sprd/dphy.txt > create mode 100644 Documentation/devicetree/bindings/display/sprd/dsi.txt > > diff --git a/Documentation/devicetree/bindings/display/sprd/dphy.txt b/Documentation/devicetree/bindings/display/sprd/dphy.txt > new file mode 100644 > index 0000000..474c2b2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sprd/dphy.txt > @@ -0,0 +1,49 @@ > +Unisoc MIPI DSI-PHY (D-PHY) > +============================================================================ > + > +Required properties: > + - compatible: value should be "sprd,dsi-phy". > + - reg: must be the dsi controller base address. > + - #address-cells, #size-cells: should be set respectively to <1> and <0> > + > +Video interfaces: > + Device node can contain video interface port nodes according to [1]. > + The following are properties specific to those nodes: > + > + port node inbound: > + - reg: (required) must be 0. > + port node outbound: > + - reg: (required) must be 1. > + > + endpoint node connected from DSI controller node (reg = 0): > + - remote-endpoint: specifies the endpoint in DSI node. > + endpoint node connected to panel node (reg = 1): > + - remote-endpoint: specifies the endpoint in panel node. > + > +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt > + > + > +Example: > + > + dphy: dphy { > + compatible = "sprd,dsi-phy"; > + reg = <0x0 0x63100000 0x0 0x1000>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* input port*/ > + port@1 { > + reg = <1>; > + dphy_in: endpoint { > + remote-endpoint = <&dsi_out>; > + }; > + }; > + > + /* output port */ > + port@0 { > + reg = <0>; > + dphy_out: endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > + }; There's support for the MIPI D-PHY in the Linux PHY framework now, so it would be a good fit for this (and that would mean using the generic PHY bindings too. > diff --git a/Documentation/devicetree/bindings/display/sprd/dsi.txt b/Documentation/devicetree/bindings/display/sprd/dsi.txt > new file mode 100644 > index 0000000..1719ff5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sprd/dsi.txt > @@ -0,0 +1,68 @@ > +Unisoc MIPI DSI Master > +============================================================================= > + > +Required properties: > + - compatible: value should be "sprd,dsi-host"; > + - reg: physical base address and length of the registers set for the device > + - interrupts: should contain DSI interrupt > + - clocks: list of clock specifiers, must contain an entry for each required > + entry in clock-names > + - clock-names: list of clock names sorted in the same order as the clocks > + property. Again, a list of the expected clock names and what they represent would be great here. Thanks! Maxime --6zgxd3we6mnaxudq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXfNd4AAKCRDj7w1vZxhR xSpSAQDTCGvPU8zMvz1OrUwV0y36VMtShiznWTC5hjK+GuJDLwD/Yt4yfhCETmY5 EKIzNfriYbWPRYY7BEN45tUr4SJrbQE= =dwwy -----END PGP SIGNATURE----- --6zgxd3we6mnaxudq--