Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 13 Dec 2019 13:09:13 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Valentin Schneider <valentin.schneider@arm.com>
Cc:     "chengjian (D)" <cj.chengjian@huawei.com>, mingo@kernel.org,
        linux-kernel@vger.kernel.org, chenwandun@huawei.com,
        xiexiuqi@huawei.com, liwei391@huawei.com, huawei.libin@huawei.com,
        bobo.shaobowang@huawei.com, juri.lelli@redhat.com,
        vincent.guittot@linaro.org
Subject: Re: [PATCH] sched/fair: Optimize select_idle_cpu
Message-ID: <20191213120913.GB2844@hirez.programming.kicks-ass.net>
References: <20191212144102.181510-1-cj.chengjian@huawei.com>
 <20191212152406.GB2827@hirez.programming.kicks-ass.net>
 <d40ac385-626f-e86f-b2cb-69adf10a193a@huawei.com>
 <6d188305-66ab-81cf-6340-34d155dcaf3b@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6d188305-66ab-81cf-6340-34d155dcaf3b@arm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Dec 13, 2019 at 11:28:00AM +0000, Valentin Schneider wrote:
> On 13/12/2019 09:57, chengjian (D) wrote:
> > 
> > in select_idle_smt()
> > 
> > /*
> > ?* Scan the local SMT mask for idle CPUs.
> > ?*/
> > static int select_idle_smt(struct task_struct *p, int target)
> > {
> > ??? int cpu, si_cpu = -1;
> > 
> > ??? if (!static_branch_likely(&sched_smt_present))
> > ??????? return -1;
> > 
> > ??? for_each_cpu(cpu, cpu_smt_mask(target)) {
> > ??????? if (!cpumask_test_cpu(cpu, p->cpus_ptr))
> > ??????????? continue;
> > ??????? if (available_idle_cpu(cpu))
> > ??????????? return cpu;
> > ??????? if (si_cpu == -1 && sched_idle_cpu(cpu))
> > ??????????? si_cpu = cpu;
> > ??? }
> > 
> > ??? return si_cpu;
> > }
> > 
> > 
> > Why don't we do the same thing in this function,
> > 
> > although cpu_smt_present () often has few CPUs.
> > 
> > it is better to determine the 'p->cpus_ptr' first.
> > 
> > 
> 
> Like you said the gains here would probably be small - the highest SMT
> count I'm aware of is SMT8 (POWER9). Still, if we end up with both
> select_idle_core() and select_idle_cpu() using that pattern, it would make
> sense IMO to align select_idle_smt() with those.

The cpumask_and() operation added would also have cost. I really don't
see that paying off.

The other sites have the problem that we combine an iteration limit with
affinity constraints. This loop doesn't do that and therefore doesn't
suffer the problem.