Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp866991ybl; Fri, 13 Dec 2019 05:55:44 -0800 (PST) X-Google-Smtp-Source: APXvYqx3vz5tliX8IBAiamcjebUklSyvosRhN4mXamYU8bRupQj87IaSNs5zUoQ+x38ZljGnP6QP X-Received: by 2002:a9d:7357:: with SMTP id l23mr14084379otk.10.1576245344362; Fri, 13 Dec 2019 05:55:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576245344; cv=none; d=google.com; s=arc-20160816; b=BHLVP7uv3yZ1KKzxXSrbkbU2Y18ELpnt0Qu7n6nBLPEtuEyOm7v2xXdICmd33R0hY1 A3+Zx5twlpXT8xxILM6Fn0VDWJP06Za++ZO/fBNb25UcRXEBwTtUUxEOytv7Iz5w5Rkr NvlKtUTywyPOr9EmEuUm381CFAlEAAVbyT4N6H5lacnCrZMN2RMjoZhrT3ZtTuJlZlub BdhYlB15NvBCIa+4NUs0yv9HXsdEpto7qQw5UM4jugVlmNPd4B/vT9Th9OBAlx/6CvGP dkA9ggGIYP0n/ATV+d2+sp2TDwy4VXJSOSPN+nLcIn4CQszgG01rc4gV8zjCe54O5RuE ymaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=RdSTB5NQwjOoYrj/2BgnJiFXxkWUYSC7knKRCi5Mjio=; b=HjzDBsRHFUeSAQyLdk4FzBtchvGV9EAhmEzZGShgbgD+uDqf9GPLQRkiqXDiLlmqtL nA3PpaJkoqLSNWyUfIXY+uvEltXjy6t9d++rmlIAQATaw9m3mKNSW7LdUvtXi01bgyN1 kSHrnozow2gDPVnvziTO+r38EmeauG9l3s06GDSw5I7K/SshMEmkRFA6c6Of0qQbRmC8 sxcxJDhyM6CG4nQHqaU+eXHPB/Pg/VM5eimjvAZ4Y6uBDFQRfaN6vJis7GT86UOWpU06 /MgkDbVfKaG5Wh+nYNWRdpoClvDEYzSrVeKtZbDFcHByNmcoeSg48aEykM6ACZa9YLGy JUIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PBrpArr9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w7si5026215otq.250.2019.12.13.05.55.32; Fri, 13 Dec 2019 05:55:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PBrpArr9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727505AbfLMNys (ORCPT + 99 others); Fri, 13 Dec 2019 08:54:48 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:43141 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727444AbfLMNyr (ORCPT ); Fri, 13 Dec 2019 08:54:47 -0500 Received: by mail-lj1-f196.google.com with SMTP id a13so2710525ljm.10 for ; Fri, 13 Dec 2019 05:54:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=RdSTB5NQwjOoYrj/2BgnJiFXxkWUYSC7knKRCi5Mjio=; b=PBrpArr9B3u6JbYnLb66q7dKmEGL2MtvGbWr/C+TjOKxAEIUfpOMogcjHNKobdOupn ti3jniJZ/GhhfpTfZcUV9yKZcNGGA3smXcs3/rs/Gr221XP/DSC5c6FrNNJKrqvwRb9e OCI/jZiHF1Z6USxpdsQ1rJK2siLGFyXAmzqG8EToVo7+VbF9Rb7vQTWNx5dw6KEs4lvz 2CQpj3uTWh5Sti8hI6DUESBXD1Dk2UPfUDYXqCroccZNuzycyNVZLdUseJkDx4lpE66n KOkN4NZXnKZa0l8wvPlsEzPVbQjKJpbccoQdmuLKJFntwWO/NdDDXVoK87H0dl1Yfuc+ RSLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=RdSTB5NQwjOoYrj/2BgnJiFXxkWUYSC7knKRCi5Mjio=; b=hmpNxX7mf2ylClb0oOzD6WrY+C5xCfevGoO8IeWoMKYeeq/giTGwkhygQKoDv9fvTD LUctMpbonFsSsHSS0GGLch0p3IjRoz+NCXQRoSGccu67n8zMbJxSCLZ8cnOr2VNdIUTo aq1t4bIkiyMXM2RIQjzjlTGfoBb9M1eojVKaK9PW366hFaqA9r78ELpPJ5BJ/SvP0oAI NF/GiRQ7hUUzwotdpsjdzzQ9JUoqJO8m51YAoDF/p7a1pW3AxGvEjiTCBAnCijuUHkFd tPJMaG3AGnE7sjweUPY1+WJhpfvwnMEB7jXGUp3k2WQMq/QWlcTee4GhnOUT7NkDqmNg HOTg== X-Gm-Message-State: APjAAAViMKwu1L4YjQD7hdPciGPdO1Ml4sOWKkLFD7HD859fOowUJuBi 3yJV1/E9hm9fvVGDVkI9l+Y1/8oSChuEyOYa8BE= X-Received: by 2002:a2e:93d5:: with SMTP id p21mr10049365ljh.50.1576245285476; Fri, 13 Dec 2019 05:54:45 -0800 (PST) MIME-Version: 1.0 References: <1576037311-6052-1-git-send-email-orson.zhai@unisoc.com> <20191213024935.GD9271@lenovo> <20191213082336.GD3468@dell> In-Reply-To: <20191213082336.GD3468@dell> From: Orson Zhai Date: Fri, 13 Dec 2019 21:54:33 +0800 Message-ID: Subject: Re: [PATCH v3] mfd: syscon: Add arguments support for syscon reference To: Lee Jones Cc: Orson Zhai , Rob Herring , Orson Zhai , Arnd Bergmann , "linux-kernel@vger.kernel.org" , baolin.wang@unisoc.com, Kevin Tang , Chunyan Zhang , liangcai.fan@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 13, 2019 at 4:23 PM Lee Jones wrote: > > On Fri, 13 Dec 2019, Orson Zhai wrote: > > > Hi Lee and Rob, > > > > On Wed, Dec 11, 2019 at 02:55:39PM +0100, Arnd Bergmann wrote: > > > On Wed, Dec 11, 2019 at 5:09 AM Orson Zhai wr= ote: > > > > > > > > There are a lot of similar global registers being used across multi= ple SoCs > > > > from Unisoc. But most of these registers are assigned with differen= t offset > > > > for different SoCs. It is hard to handle all of them in an all-in-o= ne > > > > kernel image. > > > > > > > > Add a helper function to get regmap with arguments where we could p= ut some > > > > extra information such as the offset value. > > > > > > > > Signed-off-by: Orson Zhai > > > > Tested-by: Baolin Wang > > > > > > Reviewed-by: Arnd Bergmann > > > > Does this patch look good to be applied? > > > > Or if any comments please feel free to send to me. > > If it looks good to Arnd, it looks good to me. > > I have quite a number of reviews to get through first though, please > bear with me and resist the urge to nag. Got it. Thanks for your kind reply! -Orson > > -- > Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF] > Linaro Services Technical Lead > Linaro.org =E2=94=82 Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog