Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1335596ybl; Fri, 13 Dec 2019 13:32:51 -0800 (PST) X-Google-Smtp-Source: APXvYqwKTJyjEuXotybS/sDThUkvpbXiBpL//mYJbqgCPZQvqG7tBxRnN/ll6cu4I2fFiQTK2gFt X-Received: by 2002:a05:6830:56a:: with SMTP id f10mr16285202otc.368.1576272771891; Fri, 13 Dec 2019 13:32:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576272771; cv=none; d=google.com; s=arc-20160816; b=nQ9JcEIqP+oaT89Md+ddbbemYAEF7RjQTmb7LANyeK5dhiwLu0awhf/BiIsqsPVym0 PoiqBKwtgvNsqWfmbKqU13rF3EdK31PiiqenMrlR3wGgC8mnEclvyW2y4nt0QsPcpSln OddYGZTK5r8hFsekR7Ue3lxUSi/wi76RK9Ns6/UHckOZiaoRblTJXrVc3nY13D/N/PZi vmTDPBEjf6mO48yrbyP2drL8Qp1bpOED0iaK+IHuvz20PF4obDEwjVJ+SBb1erPSfLJO Rm2zI+8vlI1L9NRdxQVSmSJhwHGu+DSuhkArlSOYbITPNBfnUMHohxIvKyqDOVuxTne9 Herw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :subject:cc:to:from:date:dkim-signature; bh=Aoa28kdUcAmXkadH+8rqcQQ18pmnTzWmZZhMobYYD+4=; b=o8r0W3jHE28Fnh2lu77pIV1m5xuL3Hj1XhuCTo3OhGcYUt0TVpu5xi3XVgYf9ffQ1s 9AbI1hvNuSLmz8lApCWKzJ1W99i3a0ATiST4L96cq7oaPhDIRG921KKd15OmSbdoj8/b LgtnL5Wn0tvxkrP+NFFuTq+exZaerOJQLpK0RISuD0TK5iZ/eEjoovB3OFUJoOa3zAFc tWN+r570GmVkgfGH5zecdwI2YZ8QGCBcZkwXMNgGDzBMb7SLUJrHW2hJAkvGe9xlo0Zt 2/nOLYrH1M9po0vqPOibwvxddFRV0V8PkifngdbntHgEwdeqvdxj8ImGpeClZz9oPv4c 1hIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=JkWu6RaX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l17si5828292otn.220.2019.12.13.13.32.39; Fri, 13 Dec 2019 13:32:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=JkWu6RaX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726382AbfLMVbs (ORCPT + 99 others); Fri, 13 Dec 2019 16:31:48 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:33961 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725554AbfLMVbs (ORCPT ); Fri, 13 Dec 2019 16:31:48 -0500 Received: by mail-pf1-f193.google.com with SMTP id l127so354565pfl.1 for ; Fri, 13 Dec 2019 13:31:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:user-agent:mime-version; bh=Aoa28kdUcAmXkadH+8rqcQQ18pmnTzWmZZhMobYYD+4=; b=JkWu6RaXpVRwOEblMcd37I3qroMQhLh/u/xUYxznodN69LHmnOp5skkokX9kDmvstr CFTy1LX1y79sJ7EKdkGpNJKUKqOOGsDCqvcIO0dqC3sKqoPFzVn/mSxYQV/XR7bMYefo xfVDU59WbjSXvmrhJ0raiBlKaLNqxKdWQMRMQcym6gyQqTA1aiFaa4VVEIKg7BszNT66 30vqngGcZz8ysHl+DYempCHmAouBT4bZt1VWC42dgN5jul/XB6PHf1rUrVs+zxqP4zOB 47lF51Ciob2T6N6dglyQWvTCA/EU2brfzqnGQSxg1PGqmYvvdM+uR5AyiCiYdYW+i6/k 1q0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:user-agent :mime-version; bh=Aoa28kdUcAmXkadH+8rqcQQ18pmnTzWmZZhMobYYD+4=; b=EYSDQWXGYr2C4aWx6X28UPNX01PBYeJR2ZbXcEGCuddr1tbb91j5ufyetIFRy6TZ/B HGR7WRS4mjqME/hpKRLCoQ8/z+EHwv6oTEHmEUdKsVHC7zCaTLZaxokXdI+rd9zavMnx 2xBHkAMiEjs+gDr65h9YClyANh3KsyCrVKsYk1gjOcmZXX7UBp29CTm6cwKiaqlaU20Y Zo/u2VqiraV/Yt/20+uPrd+h4p9YkHUJMyeq348Ff3wlY6NsStLwouB6aGRa+TAxqv0H OdhtO4OjAVKtrnYxO+r8vE7sRVJgkSsXA5WWywQGcdyHRKLDk3geJJqJEaqwTfBIxtYs q97w== X-Gm-Message-State: APjAAAWEoWyeWwIzkGn249SoagxDQhqnMEB+XGCqLXGRolz5vJXU8AjU Km3e8P2CyJnfwKSh1JKU3grhfQ== X-Received: by 2002:a63:753:: with SMTP id 80mr1653743pgh.95.1576272707558; Fri, 13 Dec 2019 13:31:47 -0800 (PST) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id e16sm6847003pfn.59.2019.12.13.13.31.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2019 13:31:46 -0800 (PST) Date: Fri, 13 Dec 2019 13:31:46 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Dennis Zhou , Tejun Heo , Christoph Lameter cc: Erdem Aktas , Borislav Petkov , Brijesh Singh , linux-kernel@vger.kernel.org Subject: [patch] percpu: Separate decrypted varaibles anytime encryption can be enabled Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Erdem Aktas CONFIG_VIRTUALIZATION may not be enabled for memory encrypted guests. If disabled, decrypted per-CPU variables may end up sharing the same page with variables that should be left encrypted. Always separate per-CPU variables that should be decrypted into their own page anytime memory encryption can be enabled in the guest rather than rely on any other config option that may not be enabled. Fixes: ac26963a1175 ("percpu: Introduce DEFINE_PER_CPU_DECRYPTED") Cc: stable@vger.kernel.org # 4.15+ Signed-off-by: Erdem Aktas Signed-off-by: David Rientjes --- include/linux/percpu-defs.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/percpu-defs.h b/include/linux/percpu-defs.h --- a/include/linux/percpu-defs.h +++ b/include/linux/percpu-defs.h @@ -175,8 +175,7 @@ * Declaration/definition used for per-CPU variables that should be accessed * as decrypted when memory encryption is enabled in the guest. */ -#if defined(CONFIG_VIRTUALIZATION) && defined(CONFIG_AMD_MEM_ENCRYPT) - +#ifdef CONFIG_AMD_MEM_ENCRYPT #define DECLARE_PER_CPU_DECRYPTED(type, name) \ DECLARE_PER_CPU_SECTION(type, name, "..decrypted")