Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1343079ybl; Fri, 13 Dec 2019 13:41:33 -0800 (PST) X-Google-Smtp-Source: APXvYqzmwfW6xuiFmBx3nhz4nIHGoCs4b0pEhjRwkIWtEPjyxWOKS9U2WJ8pL1Svh8YyLIFPX2eT X-Received: by 2002:a05:6830:14d3:: with SMTP id t19mr17658716otq.278.1576273293191; Fri, 13 Dec 2019 13:41:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576273293; cv=none; d=google.com; s=arc-20160816; b=hCgEwqFGd1fBJ98rD0QgpCdI3Qc59fHPxh4b8aMHAXv8tnFSAaAe0mJmxLK04GqUTh ZLj4Ga32GU3I6t67Eh3h2ha8B0rdHRB4Gm9fd0oxiRiivbWLLswcP61/NSYoTCUCGeZ6 hv+7s8ey6wN+X7eclT646jVQPM2n0/diPanVk2z5NXTVJ2XJRT+Zkf5I4BsBG4HI5G59 m7aHxTsRjTRQY/y5jQPrskt2bPDBYnm8iAnPNsgX8H732QvahmEOD/f09FyqsslUE5vz +q7X7vvtIwhNE+w2rAslFKTxRUQdR3c5pSlJhxxbWCaub4F/cTZTiLRM9TertbSQzJiG zejQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=kns9lRLNk7iBLl+oznMVtZYqw3+QAeHuGv8ec9B6yws=; b=GhcbYr8K0wKloF8B4JxUKbWMrgpyeOK7Cyh1WfQX3RRm/t4SDH0LVvsSjyv6+7I3UV 6P+lRQTvceS6rgt30QE7e9WkmTj905Nd4PTT623xDrpZDd5d0CaT4l3A1VaX1hTnLd24 tz9+Svm5EvkuptVFH92Du0sYI3KK/Dp2ARqmxQtc45oZyrZITOInnPAkIi5rDyOoxuFS ZhpqDS0kLPSmXcICPkuwWWIhBuNKCnjPIKjNILg2aZwTkbUtOW8HeGFh5Ti+rDln6eX9 s5eFJhFvKc2sHvkGi0t5M5Fj8XgA7Pn6M1f+JBa0HLrMnsjlwCNDvLAzv9I5qGr5wqz1 qMgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=oJ3bYl1Z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y198si6060746oia.163.2019.12.13.13.41.21; Fri, 13 Dec 2019 13:41:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=oJ3bYl1Z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726786AbfLMVkR (ORCPT + 99 others); Fri, 13 Dec 2019 16:40:17 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:9756 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726382AbfLMVkR (ORCPT ); Fri, 13 Dec 2019 16:40:17 -0500 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 13 Dec 2019 13:40:08 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Fri, 13 Dec 2019 13:40:16 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Fri, 13 Dec 2019 13:40:16 -0800 Received: from [10.110.48.28] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 13 Dec 2019 21:40:15 +0000 Subject: Re: [PATCH] mm/gup: Fix memory leak in __gup_benchmark_ioctl To: Navid Emamdoost , Andrew Morton , "Kirill A. Shutemov" , Keith Busch , , CC: References: <20191211174653.4102-1-navid.emamdoost@gmail.com> From: John Hubbard X-Nvconfidentiality: public Message-ID: <9a692d27-4654-f1fc-d4c5-c6efba02c8a9@nvidia.com> Date: Fri, 13 Dec 2019 13:40:15 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20191211174653.4102-1-navid.emamdoost@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1576273208; bh=kns9lRLNk7iBLl+oznMVtZYqw3+QAeHuGv8ec9B6yws=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=oJ3bYl1Z5Gpmdvi7Y6NeGtebuuLGEPCWYNqk3tJzDS3MKEoKKqQUKczkvTc6g7KXL WyMondT5BBwHQvhYCCmEvUBq8ERzzLR+bydBWA3Fz+u0U0ZuSJzsh3R10KQOn2t+xS 84trCd9TjfilpWf6ixPvaTLnkJC4zq3h7/8gLx5o16nSgn4w2QYy4cTqwy7ORXT1wf DAaliJCEMTzjHL70kcOVSVJ78IYGj4nnw1jw8eQb5oTzgBU/+1kRg24hFLa+bAu+BE vqokTJcSremr/xFOXkvqxSe9SRoCZZO4IySFSSZTytlku/65NSJDSbWuV2bzAdJ6hw 8dScaKdl6pHtw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/19 9:46 AM, Navid Emamdoost wrote: > In the implementation of __gup_benchmark_ioctl() the allocated pages > should be released before returning in case of an invalid cmd. Release > pages via kvfree(). > > Fixes: 714a3a1ebafe ("mm/gup_benchmark.c: add additional pinning methods") > Signed-off-by: Navid Emamdoost > --- > mm/gup_benchmark.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/gup_benchmark.c b/mm/gup_benchmark.c > index 7dd602d7f8db..b160638f647e 100644 > --- a/mm/gup_benchmark.c > +++ b/mm/gup_benchmark.c > @@ -63,6 +63,7 @@ static int __gup_benchmark_ioctl(unsigned int cmd, > NULL); > break; > default: > + kvfree(pages); > return -1; > } > Hi, The patch is correct, but I would like to second Ira's request for a ret value, and a "goto done" to use a single place to kvfree, if you don't mind. Either way, you can add: Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA