Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1762276ybl; Fri, 13 Dec 2019 23:16:29 -0800 (PST) X-Google-Smtp-Source: APXvYqwMKXkwu1SCs7YqNj8NIZvyF6iEcZHPbT4Ya1b3WBoReW+dwweq4nYFFl1/+Sn5xFQJdyj5 X-Received: by 2002:a9d:d0b:: with SMTP id 11mr19884482oti.287.1576307789269; Fri, 13 Dec 2019 23:16:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576307789; cv=none; d=google.com; s=arc-20160816; b=YdgoPF3flm9tvjWO9FF8hp4FFDmV+eEmm8wcFlSP0W+sc8KkDed88edmDQwYK9OqG8 ezYn7IRKMbCDNtBC64SpDDn3wE7Uf3tydM9GxYqtRCrtYKygzQgKx1ydnaWyqtGS5LAj odVqGxe9QwnVVmN4PcrJa4sK09tKb8SZFKn6juUpSqtGjiwFC77gOXAteHCLU12Oq4Xb vROElvYQcxg3A/HGVBWqAvfD8eeNdr2r2B1DF/rk0WrvxRw5Qseat0uMPjxF/OqDZu0G I10UzVMTlIfatqoq8bOgsKqw+E5RSv4ZctBzgKWALbbPj/zW1KT/qfwaDoXlb1bTmDUg Uz+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=tMwjUthhqQ9hoTv144WJaupinyPbR61fTpHmQcNxzm8=; b=xPuVlfiUe8LDlb9SzCCT8Ghk/Gm4dYjX43Y/JokNKoHml7r5C07gCrp3vGJmWVNT9I yBVrWu8/bwX0CBt9tWsX5gz7GTQNMtK9Tzbiw7RHiBc4qPTEQQmyrA5vI0KsUHmTixo4 cI2b6bFGlLHBgRwJdHL1cWZweans2do83vL4MMJE3j4hnBqvei4Wfss6OMoSM6Xp2CaC FJi+d6dyXgoXoJ+6DWz56RSO1KzHlvTQCC1JOqPxB/hc071qWGK7PpnNCb8CWgiE89x2 788VDOdDpKwV1JldbPBdFgUBp3tCOYNnOOKN7hWeuDX882E3N+op5DVpTd0gQ7l2Clvo 176Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=nUw9LW0G; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p14si6644300ota.71.2019.12.13.23.16.17; Fri, 13 Dec 2019 23:16:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=nUw9LW0G; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725893AbfLNHPc (ORCPT + 99 others); Sat, 14 Dec 2019 02:15:32 -0500 Received: from mail.skyhub.de ([5.9.137.197]:40764 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbfLNHPc (ORCPT ); Sat, 14 Dec 2019 02:15:32 -0500 Received: from zn.tnic (p200300EC2F0A5A00D0F33451B6E85A6B.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:5a00:d0f3:3451:b6e8:5a6b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 6522C1EC03AD; Sat, 14 Dec 2019 08:15:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1576307731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=tMwjUthhqQ9hoTv144WJaupinyPbR61fTpHmQcNxzm8=; b=nUw9LW0Gh8geZdoxRoVJhxSqBO7U2bgPbupYXsFqsiYhEIqHNwediy/SLOz2srZrBwdxpo EO/D2m+UABG+bgnTYp9BUUBOrPdKmZwoHsSgR/z7D3pnSKJhCavLmSmUaBteHDKYFfgDce zngTL5CjuR7aXpwGLIP34g7OJcuR7lk= Date: Sat, 14 Dec 2019 08:15:29 +0100 From: Borislav Petkov To: Baoquan He Cc: Masayoshi Mizuma , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Masayoshi Mizuma , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 4/4] x86/mm/KASLR: Adjust the padding size for the direct mapping. Message-ID: <20191214071529.GB28635@zn.tnic> References: <20191115144917.28469-1-msys.mizuma@gmail.com> <20191115144917.28469-5-msys.mizuma@gmail.com> <20191212201916.GL4991@zn.tnic> <20191214033348.GJ28917@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191214033348.GJ28917@MiWiFi-R3L-srv> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 14, 2019 at 11:33:48AM +0800, Baoquan He wrote: > So in kernel there's no way to check if memory hotplug is supported in > system. Which makes it even worse. We will carry this bunch of code which would be dead code on most systems. Do you understand now why I'm pushing back on this to be designed as clean and as lean as possible? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette