Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932356AbWAWQMy (ORCPT ); Mon, 23 Jan 2006 11:12:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932440AbWAWQMv (ORCPT ); Mon, 23 Jan 2006 11:12:51 -0500 Received: from perninha.conectiva.com.br ([200.140.247.100]:39303 "EHLO perninha.conectiva.com.br") by vger.kernel.org with ESMTP id S932239AbWAWQM1 (ORCPT ); Mon, 23 Jan 2006 11:12:27 -0500 Date: Mon, 23 Jan 2006 13:46:14 -0200 From: Luiz Fernando Capitulino To: davem Cc: lkml , netdev@vger.kernel.org, robert.olsson@its.uu.se Subject: [PATCH 00/03] pktgen: Fix kernel_thread() fail leak. Message-Id: <20060123134614.90d92a45.lcapitulino@mandriva.com.br> Organization: Mandriva X-Mailer: Sylpheed version 2.2.0beta4 (GTK+ 2.8.10; i586-mandriva-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1354 Lines: 47 Leak fix: free all the alocated resources if kernel_thread() call fails. Signed-off-by: Luiz Capitulino net/core/pktgen.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index ee26c69..ccffcbb 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -2998,6 +2998,7 @@ static struct pktgen_thread *__init pktg static int __init pktgen_create_thread(const char *name, int cpu) { + int err; struct pktgen_thread *t = NULL; struct proc_dir_entry *pe; @@ -3036,9 +3037,15 @@ static int __init pktgen_create_thread(c t->removed = 0; - if (kernel_thread((void *)pktgen_thread_worker, (void *)t, - CLONE_FS | CLONE_FILES | CLONE_SIGHAND) < 0) + err = kernel_thread((void *)pktgen_thread_worker, (void *)t, + CLONE_FS | CLONE_FILES | CLONE_SIGHAND); + if (err < 0) { printk("pktgen: kernel_thread() failed for cpu %d\n", t->cpu); + remove_proc_entry(t->name, pg_proc_dir); + list_del(&t->th_list); + kfree(t); + return err; + } return 0; } -- Luiz Fernando N. Capitulino - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/