Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191126161824.337724-1-arnd@arndb.de> <20191126161824.337724-7-arnd@arndb.de>
 <09c664fd-87fb-4fac-f104-9afbe7d33aa2@xs4all.nl> <CAK8P3a1TvFCJf8t9T1yOXjsp088s9dbEOKLVDPinfwJe2B-27g@mail.gmail.com>
 <81bb5da1-6b84-8473-4ada-c174f43bbae2@xs4all.nl> <0843718f-1391-3379-38be-41fa9558ea6d@xs4all.nl>
In-Reply-To: <0843718f-1391-3379-38be-41fa9558ea6d@xs4all.nl>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Sat, 14 Dec 2019 22:44:27 +0100
Message-ID: <CAK8P3a1-xLUn368Lajia1=2GEXa92srQ2s9wH--MrRHj+kSTtQ@mail.gmail.com>
Subject: Re: [PATCH v5 6/8] media: v4l2-core: fix v4l2_buffer handling for
 time64 ABI
To:     Hans Verkuil <hverkuil@xs4all.nl>
Cc:     Linux Media Mailing List <linux-media@vger.kernel.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        y2038 Mailman List <y2038@lists.linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        me@zv.io
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Dec 14, 2019 at 12:27 PM Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> On 12/13/19 4:32 PM, Hans Verkuil wrote:
> >>> I am unable to test with musl since v4l2-ctl and v4l2-compliance are C++ programs,
> >>> and there doesn't appear to be an easy way to compile a C++ program with musl.
> >>>
> >>> If you happen to have a test environment where you can compile C++ with musl,
> >>> then let me know and I can give instructions on how to run the compliance tests.
> >>>
> >>> If you can't test that, then I can merge this regardless, and hope for the best
> >>> once the Y2038 fixes end up in glibc. But ideally I'd like to have this tested.
> >>
> >> I've heard good things about the prebuilt toolchains from http://musl.cc/.
> >> These seems to come with a libstdc++, but I have not tried that myself.
> >
> > I'll see if I can give those a spin, but if I can't get it to work quickly,
> > then I don't plan on spending much time on it.
>
> I managed to build v4l2-ctl/compliance with those toolchains, but they seem to be
> still using a 32-bit time_t.
>
> Do I need to get a specific version or do something special?

My mistake: only musl-1.2.0 and up have 64-bit time_t, but this isn't released
yet. According to https://wiki.musl-libc.org/roadmap.html, the release
was planned
for last month, no idea how long it will take.

It appears that a snapshot build at
http://more.musl.cc/7.5.0/x86_64-linux-musl/i686-linux-musl-native.tgz
is new enough to have 64-bit time_t (according to include/bits/alltypes.h),
but this is a month old as well, so it may have known bugs.

Adding Zach to Cc here, maybe he already has plans for another build with
the latest version.

       Arnd