Date: Mon, 23 Jan 2006 15:01:27 -0200
From: Luiz Fernando Capitulino <lcapitulino@mandriva.com.br>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: arjan@infradead.org, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slab: Adds two missing kmalloc() checks.
Message-Id: <20060123150128.eb12603f.lcapitulino@mandriva.com.br>
In-Reply-To: <1138035122.10527.10.camel@localhost>
References: <20060123133121.70f2cbcb.lcapitulino@mandriva.com.br>
	<1138034316.10527.2.camel@localhost>
	<1138034695.2977.48.camel@laptopd505.fenrus.org>
	<1138035122.10527.10.camel@localhost>
Organization: Mandriva
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1206
Lines: 32


 Hi Pekka, Arjan,

On Mon, 23 Jan 2006 18:52:02 +0200
Pekka Enberg <penberg@cs.helsinki.fi> wrote:

| On Mon, 2006-01-23 at 18:38 +0200, Pekka Enberg wrote:
| > > Looks good to me. Arjan, you had some objections last time around. Are
| > > you okay with the change?
| 
| On Mon, 2006-01-23 at 17:44 +0100, Arjan van de Ven wrote:
| > I still fail to see the point. Has anyone EVER seen these trigger????
| 
| Yeah, we probably won't. They seem useful for people who hunt unchecked
| kmalloc() calls, though.

 It really looks useful to me. You don't check for fail because someone has
seen the fail happen. You check for fail in order to have a robust program.

 There are zilions of checks in the kernel and in programs out there which I
think they will never fail. But they are there.

 On the other hand, I'm not going to make too much noise for a such trivial
patch. If you think it's not useful, let's drop it. No problem.

-- 
Luiz Fernando N. Capitulino
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/