Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191215164621.25828-1-pakki001@umn.edu>
In-Reply-To: <20191215164621.25828-1-pakki001@umn.edu>
From:   Andreas Gruenbacher <agruenba@redhat.com>
Date:   Sun, 15 Dec 2019 20:50:28 +0100
Message-ID: <CAHc6FU6rduNDcS7Y6UiWm6EuuwxnVd+75ydG1jW4rfE-kLn4Sw@mail.gmail.com>
Subject: Re: [PATCH] gfs2: remove assertion when journal_info is not empty
To:     Aditya Pakki <pakki001@umn.edu>
Cc:     kjlu@umn.edu, Bob Peterson <rpeterso@redhat.com>,
        cluster-devel <cluster-devel@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello Aditya,

On Sun, Dec 15, 2019 at 5:46 PM Aditya Pakki <pakki001@umn.edu> wrote:
> In gfs2_trans_begin, avoid crashing when current->journal_info
> is not empty. The patch fixes  the error by returning -EINVAL
> instead of crashing.

can you please explain when that patch is needed? Do you have a test
case to reproduce?

Thanks,
Andreas