Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Punit Agrawal <punit1.agrawal@toshiba.co.jp>
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     linux-serial@vger.kernel.org, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, nobuhiro1.iwamatsu@toshiba.co.jp,
        shrirang.bagul@canonical.com, stable@vger.kernel.org,
        Rob Herring <robh@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH] serdev: Don't claim unsupported serial devices
References: <20191218065646.817493-1-punit1.agrawal@toshiba.co.jp>
        <096046b6-324a-8496-8599-ed7e5ffc6e3c@redhat.com>
Date:   Thu, 19 Dec 2019 09:37:23 +0900
In-Reply-To: <096046b6-324a-8496-8599-ed7e5ffc6e3c@redhat.com> (Hans de
        Goede's message of "Wed, 18 Dec 2019 11:05:40 +0100")
Message-ID: <87eex1noak.fsf@kokedama.swc.toshiba.co.jp>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hans de Goede <hdegoede@redhat.com> writes:

> Hi,
>
> On 18-12-2019 07:56, Punit Agrawal wrote:
>> Serdev sub-system claims all serial devices that are not already
>> enumerated. As a result, no device node is created for serial port on
>> certain boards such as the Apollo Lake based UP2. This has the
>> unintended consequence of not being able to raise the login prompt via
>> serial connection.
>>
>> Introduce a blacklist to reject devices that should not be treated as
>> a serdev device. Add the Intel HS UART peripheral ids to the blacklist
>> to bring back serial port on SoCs carrying them.
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Punit Agrawal <punit1.agrawal@toshiba.co.jp>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Johan Hovold <johan@kernel.org>
>> Cc: Hans de Goede <hdegoede@redhat.com>
>
> Thank you for addressing this long standing issue.

I am surprised there hasn't been more people complaining! Maybe even on
x86 mainline isn't that widely used on development boards.

> The basic approach here looks good to me, once the minor
> comments from other reviewers are addressed you can add my:
>
> Acked-by: Hans de Goede <hdegoede@redhat.com>

Thanks!

[...]