Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] net: amd: xgbe: fix possible sleep-in-atomic-context bugs
 in xgbe_powerdown()
To:     David Miller <davem@davemloft.net>
Cc:     thomas.lendacky@amd.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20191218140102.11579-1-baijiaju1990@gmail.com>
 <20191218.132601.160360469201947283.davem@davemloft.net>
From:   Jia-Ju Bai <baijiaju1990@gmail.com>
Message-ID: <62131c40-e69b-0664-2b2a-177a031a6f1f@gmail.com>
Date:   Thu, 19 Dec 2019 10:40:39 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <20191218.132601.160360469201947283.davem@davemloft.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2019/12/19 5:26, David Miller wrote:
> From: Jia-Ju Bai <baijiaju1990@gmail.com>
> Date: Wed, 18 Dec 2019 22:01:02 +0800
>
>> @@ -1257,17 +1257,18 @@ int xgbe_powerdown(struct net_device *netdev, unsigned int caller)
>>   	netif_tx_stop_all_queues(netdev);
>>   
>>   	xgbe_stop_timers(pdata);
>> -	flush_workqueue(pdata->dev_workqueue);
>>   
>>   	hw_if->powerdown_tx(pdata);
>>   	hw_if->powerdown_rx(pdata);
>>   
>> -	xgbe_napi_disable(pdata, 0);
>> -
>>   	pdata->power_down = 1;
>>   
>>   	spin_unlock_irqrestore(&pdata->lock, flags);
>>   
>> +	flush_workqueue(pdata->dev_workqueue);
>> +
>> +	xgbe_napi_disable(pdata, 0);
>> +
> Nope, this doesn't work at all.
>
> You can't leave NAPI enabled, and thus packet processing, after the TX
> and RX units of the chip have been powered down.

Looking at the code, only xgbe_powerup() and xgbe_powerdown() use the 
spinlock "pdata->lock".
How about change the spinlock to a mutex?


Best wishes,
Jia-Ju Bai