Subject: Re: [PATCHSET] Time: Generic Timeofday Subsystem (v B17)
From: john stultz <johnstul@us.ibm.com>
To: Paul Mundt <lethal@linux-sh.org>
Cc: lkml <linux-kernel@vger.kernel.org>, Steven Rostedt <rostedt@goodmis.org>,
       Thomas Gleixner <tglx@linutronix.de>,
       Ulrich Windl <ulrich.windl@rz.uni-regensburg.de>,
       Roman Zippel <zippel@linux-m68k.org>,
       George Anzinger <george@mvista.com>, Ingo Molnar <mingo@elte.hu>
In-Reply-To: <20060122233938.GA31392@linux-sh.org>
References: <1137801626.27699.279.camel@cog.beaverton.ibm.com>
	 <20060122233938.GA31392@linux-sh.org>
Content-Type: text/plain
Date: Mon, 23 Jan 2006 12:10:36 -0800
Message-Id: <1138047036.15682.10.camel@cog.beaverton.ibm.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1834
Lines: 43

On Mon, 2006-01-23 at 01:39 +0200, Paul Mundt wrote:
> On Fri, Jan 20, 2006 at 04:00:26PM -0800, john stultz wrote:
> > The patchset applies against the current 2.6.16-rc1-git.
> > 
> > The complete patchset can be found here:
> > 	http://sr71.net/~jstultz/tod/
> > 
> > As always, feedback, suggestions and bug-reports are always appreciated.
> > 
> Patches weren't explicitly mentioned, but I'm assuming they're also
> welcome ;-)
> 
> At first glance the register/unregister interface is a bit
> unconventional, but I have a few trivial patches to get those fixed up,
> which I'll send to you separately.

Very Cool!

> It looks like struct clocksource will also need suspend/resume ops,
> since it's defining its own sysclass (so there's no overlap with the
> timer sysclass that several other architectures setup to deal with this).
> I haven't done that yet, but if there's interest, I'll hack something up.

Hmmm. While we do have suspend and resume functions for the timekeeping
core, I'm not sure if suspend and resume are necessary for each struct
clocksource since state changes are only allowed inside the callback
hook.  That probably should be better documented. :)

Some specific hardware that might provide a clocksource interface may
need suspend/resume hooks (like the PIT, for example), but in my mind
that would be done independently from the clocksource code.

But maybe I'm not quite grasping what you're suggesting, so feel free to
clarify with maybe an example of its use and I'll re-think it.

Thanks for the code review and patches! I really appreciate it!
-john

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/