Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1566356ybl; Wed, 18 Dec 2019 22:16:14 -0800 (PST) X-Google-Smtp-Source: APXvYqzflbtYQ6SlvsBFmqjCwmGAhF4ijEKpzKGwgAFXyTDpJYc8fTKY5cwuJ4nxfOmQsf01gui2 X-Received: by 2002:a05:6830:11c3:: with SMTP id v3mr7406364otq.74.1576736174307; Wed, 18 Dec 2019 22:16:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576736174; cv=none; d=google.com; s=arc-20160816; b=VEgE4OvIELVQy99klTVDBMfo5Y1UphbDGqYFa3nfjdlJKLMoXmCmQFPauFBaKIo3Qf sShzHw650rZUxQ+SgQPF3Ii7FaFVqRkDHtKnbDOJqcBODYwB4W4KoN5nqi57LSdkIN1E atirwJpBVYDOUctEE3fO0zPEfLNgQGuuh79LrZ4RtNMoiieLNsvb9/Z36/nTykOmgBvI UaRR4mg6gjbnNfBeBSl24CMW+7ve+TcQFrNv1xc704YMnSj5OLr6h/2LQOL9AKF1q/5h HU6ebGRR/K8S6koJfxppsQAQ8f88w4uBbdoGMvhx6++K5GuQIlSzBPFaMw+Gnpb/ThEG aS4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=bh0Tsz0FRFkz1g+d7rZD2Gj7EaunA+7nFMVCPMVS/JQ=; b=pcMNyx8hKSmJ4FemJrazThWWYRgtf3HJzDYR0GIFXd+5/TKVGxNPJDJeYpEcAiTFxi JDM/Kt5wajtHMQzUZxH97UvjQI6Re8Pz4YQT/ayFWD/xXrQA3N4iGNkK+Yux4mQdYub4 prglTF061q8BifQkpApbZyfMp8mY7XCI325gbrVdltx8k9rgSTnmgK6yO4ZY6ZWujkDo bcPAnUR6Ad5XSbY9McuL12oOvbYaDKJxuACANu/++E/oq/xhkL8lsdTB7JvyYDC+5YVS 5+vUs5QytNrCaO3mw8IQ5EJiSqQrd7lsICsTl/ntRAqzVuYjHO/njCwpe3ZerLi/cgTY Vi4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Hge65a3Z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n18si433397otf.285.2019.12.18.22.16.00; Wed, 18 Dec 2019 22:16:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Hge65a3Z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726439AbfLSGPS (ORCPT + 99 others); Thu, 19 Dec 2019 01:15:18 -0500 Received: from mail.skyhub.de ([5.9.137.197]:58084 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725987AbfLSGPR (ORCPT ); Thu, 19 Dec 2019 01:15:17 -0500 Received: from zn.tnic (p200300EC2F0B1C00F1A577DA89A48CEF.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:1c00:f1a5:77da:89a4:8cef]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 77AFB1EC0591; Thu, 19 Dec 2019 07:15:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1576736116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=bh0Tsz0FRFkz1g+d7rZD2Gj7EaunA+7nFMVCPMVS/JQ=; b=Hge65a3Zh8iRt4cP+h6hCWyCpK8fi+9bWdFUQb5P4C8Ca5I7lbf8FE2xhhmiE02iotkguB BXClpzWQo2tjIQzsvRzTJx4NvNCeUOSLJ+iCKqL/MaYOMzxjkhx3/sNVxKawih+AZl1ahu 0UfBAbnLC5NdYx/oVXNl9a/y/1ANZHY= Date: Thu, 19 Dec 2019 07:15:10 +0100 From: Borislav Petkov To: Jarkko Sakkinen Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-sgx@vger.kernel.org, akpm@linux-foundation.org, dave.hansen@intel.com, sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, serge.ayoun@intel.com, shay.katz-zamir@intel.com, haitao.huang@intel.com, andriy.shevchenko@linux.intel.com, tglx@linutronix.de, kai.svahn@intel.com, josh@joshtriplett.org, luto@kernel.org, kai.huang@intel.com, rientjes@google.com, cedric.xing@intel.com, puiterwijk@redhat.com Subject: Re: [PATCH v24 07/24] x86/cpu/intel: Detect SGX supprt Message-ID: <20191219061510.GA32039@zn.tnic> References: <20191129231326.18076-1-jarkko.sakkinen@linux.intel.com> <20191129231326.18076-8-jarkko.sakkinen@linux.intel.com> <20191217151744.GG28788@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 19, 2019 at 02:42:20AM +0200, Jarkko Sakkinen wrote: > It is used in bunch of places in the kernel. I'm a bit confused > when using it is a right thing and when it should be avoided. Yeah, we try to avoid ifdeffery as much as possible. Even if it means pushing it into the called function and hiding it there. :-) Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette