Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1782147ybl; Thu, 19 Dec 2019 02:58:34 -0800 (PST) X-Google-Smtp-Source: APXvYqyxcgBBB8kxxbsiVoKE9ZhkA6OjvHstYXfOWcce9tby+w2qKBdS76H60CVPs0sVumZDaVJx X-Received: by 2002:a9d:7999:: with SMTP id h25mr8119347otm.347.1576753114935; Thu, 19 Dec 2019 02:58:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576753114; cv=none; d=google.com; s=arc-20160816; b=ld8p1mycrovH3ZRAc1z5AXIKuBDFueG92uCPOw+FyWdk0t5XpVIDhxkqAeNJkQ8zYS Yrf+nUZbRS/ySXU15+hDwZdn/oKHjiKDTqLpoVeeqQvm/ZaVRTJYQ+QMujpJFDVB7Jz6 cbyazwUOh59n4wwQ/DUq3UNvtCH++MNOgvT8JWJudzyUpBXOt43iP3bEEe2jAyj33EY/ uLA10NgbYMRWxlxsfNiCCCSfQ4uj58m0lKsqWwJk/qzneuEAEWMJi834wuG2TEUFZ7sK vlRzwg+y5R8qBqrPGQhkvYKDTvi/rqRZ9gdstJs8qrBlIpY3Fvr6iN7zvh59QKOjRhZJ 1cMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=k/ADC7/zyDs9kypvnbQTAQ43s3MccHy+67hQqHcJHGo=; b=ijL2HGC4gi2+J/sh7W0+8oXHbfoQRzfuDgUQlm9EZHAj2zP/j6CrMpUutRpHKYrlcI L+AnenJDNZ+HOMqs0PtpvlukDj7RPdjOu66DF9BZyn3bMSmpJAP2U7K3cZvMuW/TvrGw xzdt0OgwUBAKM4WanjLO8L2pPN6p9oviZVFPwHdI824ozAklAW9UPvLt1ZN57J+ohJj3 8MywggISiUF/yo8z7V9t3c5rkJh6lqpBxdPUadag5OzOS4RNctZcuqRqRdVZUnheLFkT KSdRl4z6DRW9SjzC4U3tktL8naKyUVhp/5pHb7/XQp/8GedO8VY4EsGXvtwmUwBJd/gw xXUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w1si1653249oia.169.2019.12.19.02.58.24; Thu, 19 Dec 2019 02:58:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726890AbfLSK4n (ORCPT + 99 others); Thu, 19 Dec 2019 05:56:43 -0500 Received: from mout-p-101.mailbox.org ([80.241.56.151]:14278 "EHLO mout-p-101.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726633AbfLSK4m (ORCPT ); Thu, 19 Dec 2019 05:56:42 -0500 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 47dpj31MsQzKmf2; Thu, 19 Dec 2019 11:56:39 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter05.heinlein-hosting.de (spamfilter05.heinlein-hosting.de [80.241.56.123]) (amavisd-new, port 10030) with ESMTP id 5rWZwtGny0B0; Thu, 19 Dec 2019 11:56:37 +0100 (CET) From: Aleksa Sarai To: Alexander Viro , Jeff Layton , "J. Bruce Fields" , Shuah Khan Cc: Aleksa Sarai , Florian Weimer , David Laight , Christian Brauner , dev@opencontainers.org, containers@lists.linux-foundation.org, libc-alpha@sourceware.org, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH 0/2] openat2: minor uapi cleanups Date: Thu, 19 Dec 2019 21:55:31 +1100 Message-Id: <20191219105533.12508-4-cyphar@cyphar.com> In-Reply-To: <20191219105533.12508-1-cyphar@cyphar.com> References: <20191219105533.12508-1-cyphar@cyphar.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While openat2(2) is still not yet in Linus's tree, we can take this opportunity to iron out some small warts that weren't noticed earlier: * A fix was suggested by Florian Weimer, to separate the openat2 definitions so glibc can use the header directly. I've put the maintainership under VFS but let me know if you'd prefer it belong ot the fcntl folks. * Having heterogenous field sizes in an extensible struct results in "padding hole" problems when adding new fields (in addition the correct error to use for non-zero padding isn't entirely clear ). The simplest solution is to just copy clone(3)'s model -- always use u64s. It will waste a little more space in the struct, but it removes a possible future headache. Aleksa Sarai (2): uapi: split openat2(2) definitions from fcntl.h openat2: drop open_how->__padding field MAINTAINERS | 1 + fs/open.c | 2 - include/uapi/linux/fcntl.h | 37 +---------------- include/uapi/linux/openat2.h | 40 +++++++++++++++++++ tools/testing/selftests/openat2/helpers.h | 3 +- .../testing/selftests/openat2/openat2_test.c | 24 ++++------- 6 files changed, 51 insertions(+), 56 deletions(-) create mode 100644 include/uapi/linux/openat2.h base-commit: 912dfe068c43fa13c587b8d30e73d335c5ba7d44 -- 2.24.0