Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1811208ybl; Thu, 19 Dec 2019 03:27:03 -0800 (PST) X-Google-Smtp-Source: APXvYqwqCcPb9TbnnIjwRID/zqQEb8MOV9XIzIyZ5F0hSbf5NBO0wmzJCMlTnQihEIontXUhlklO X-Received: by 2002:a9d:74d8:: with SMTP id a24mr8661417otl.100.1576754823785; Thu, 19 Dec 2019 03:27:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576754823; cv=none; d=google.com; s=arc-20160816; b=y1/P9HqiZe2YVWzliJDdX4b+abfNrzEOZvoN1aq7aqLdm83A6UoQy8jHvyuzyeKOP0 CNcVtLZdR0MfwoMMlpYHKMAngE1R7G56nadYsrbMwEJSkohv1Lmi4QRD+EgZ78qBLWc7 xv5MloUp7d0DrNgGTzmtGeRXarWpPK1U+gY8HTXV58LfMtWM2sL9/iXEb6vdXk7IsugV Q0PHKTnjCSsLjQ/S0QLuQIjImIUfZlKaKPOXDP9ARFkBe1GGOgp3YXYrNXB4tm7lgWMl BK2FKyBPjLyS/fplpJVK/VAiNglGEe/lxQeHdqZXmbEq6YOe7OSREX8GJ4pDe20XquUH GkTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:to:from:dkim-signature; bh=5NL3hw3ZipUm0x7KGXD6mjMXU8mT1W7WQy6jFvhbHQo=; b=y77cT7Ue3jWGJUdv98KERRtoWQLQuyjw+tGGO3g0jm0VBLRLLKnwssXH1hKOB/7tM0 45ZDWLT6le7brR5gkx7U3EG9r358DmdQ7tDsleayW3Vm2PcVWMVIQ2Ngx8dnT4BWQkVR 6x+HgzdTEloL/bAc71NrlSdcPtWGoCU++YIvPb/4wT/ywKPtRXVAXQum6qKSi8T8HDT3 Xd8qd1/3MZDPzwHFrp5/xTxrgIji9Tet8ZM5+OeX32sdsN6ElB/l70vvKPY1I/vaasiX E5kv9/PDqaAefZrMOpvY/iVmODR7MKdLwoU8xDC16nrIXfzTMbJJjWoam7CsTNymL7jt ZESw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=P0pIMkw4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l18si3109394oth.236.2019.12.19.03.26.51; Thu, 19 Dec 2019 03:27:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=P0pIMkw4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726712AbfLSLZh (ORCPT + 99 others); Thu, 19 Dec 2019 06:25:37 -0500 Received: from bilbo.ozlabs.org ([203.11.71.1]:58361 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726652AbfLSLZh (ORCPT ); Thu, 19 Dec 2019 06:25:37 -0500 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 47dqLP6ntkz9sPn; Thu, 19 Dec 2019 22:25:33 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1576754734; bh=Zx5Yd53JL3kH4J/q4/1yt1DPvG/CjFpohvESNKMplWE=; h=From:To:Subject:In-Reply-To:References:Date:From; b=P0pIMkw4ErNb1nuX21DZj5B+bxMWXCI5nmpMnd5T6pbiUuAxWRe3O7aYGiY6JIHWI 6tKOYZBhSeKKirWC2ajlvKX8n1LklGqR3iEtRq/0czGjJPqibcwrb2HCaq/bJfHlQW joz438XnOFK6gVX3n/z5HJbu5x/xI6epfBhcV9zVSWTH6idQzG9F210BkUS6QdCYuI awM9SDsFVPT7frGLLHg40y4fFq+ze3zhybiXysOeieaka8bMOVc5xH7gaDcMVeatEI jH2+2xsu8mlfVjwjs/jy3HW60tJTnpLnEAELufqZjXp02xJHY8SFdXpJmz5rwaazsu wzDaeBRGKO6PQ== From: Michael Ellerman To: Daniel Axtens , Christophe Leroy , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, kasan-dev@googlegroups.com, aneesh.kumar@linux.ibm.com, bsingharora@gmail.com Subject: Re: [PATCH v4 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support In-Reply-To: <87bls4tzjn.fsf@dja-thinkpad.axtens.net> References: <20191219003630.31288-1-dja@axtens.net> <20191219003630.31288-5-dja@axtens.net> <87bls4tzjn.fsf@dja-thinkpad.axtens.net> Date: Thu, 19 Dec 2019 22:25:32 +1100 Message-ID: <87fthgmuab.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Daniel Axtens writes: > Christophe Leroy writes: >> On 12/19/2019 12:36 AM, Daniel Axtens wrote: >>> KASAN support on Book3S is a bit tricky to get right: ... >>> diff --git a/arch/powerpc/include/asm/kasan.h b/arch/powerpc/include/asm/kasan.h >>> index 296e51c2f066..f18268cbdc33 100644 >>> --- a/arch/powerpc/include/asm/kasan.h >>> +++ b/arch/powerpc/include/asm/kasan.h >>> @@ -2,6 +2,9 @@ >>> #ifndef __ASM_KASAN_H >>> #define __ASM_KASAN_H >>> >>> +#include >>> +#include >> >> What do you need asm/pgtable.h for ? >> >> Build failure due to circular inclusion of asm/pgtable.h: > > I see there's a lot of ppc32 stuff, I clearly need to bite the bullet > and get a ppc32 toolchain so I can squash these without chewing up any > more of your time. I'll sort that out and send a new spin. I think you run Ubuntu, in which case it should just be: $ apt install gcc-powerpc-linux-gnu cheers