Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 19 Dec 2019 12:35:37 +0100
From:   Paul Cercueil <paul@crapouillou.net>
Subject: RE: [PATCH v2 3/3] power/supply: Add generic USB charger driver
To:     Peter Chen <peter.chen@nxp.com>
Cc:     Sebastian Reichel <sre@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>, od@zcrc.me,
        linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Message-Id: <1576755337.3.0@crapouillou.net>
In-Reply-To: <VI1PR04MB53273342340E350BFFFDE12F8B530@VI1PR04MB5327.eurprd04.prod.outlook.c
        om>
References: <20191211155032.167032-1-paul@crapouillou.net>
        <20191211155032.167032-3-paul@crapouillou.net>
        <20191212091814.GA7035@b29397-desktop> <1576270147.3.0@crapouillou.net>
        <VI1PR04MB5327401FFD2D32E937548DD48B510@VI1PR04MB5327.eurprd04.prod.outlook.com>
        <1576493525.3.0@crapouillou.net>
        <VI1PR04MB5327B8EF35340FC4B2D02DE88B500@VI1PR04MB5327.eurprd04.prod.outlook.com>
        <1576617863.3.1@crapouillou.net>
        <VI1PR04MB53273342340E350BFFFDE12F8B530@VI1PR04MB5327.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Peter,


Le mer., d=E9c. 18, 2019 at 02:46, Peter Chen <peter.chen@nxp.com> a=20
=E9crit :
>=20
>>  >>  >
>>  >>  >>  >>  +
>>  >>  >>  >>  +	desc =3D &charger->desc;
>>  >>  >>  >>  +	desc->name =3D "usb-charger";
>>  >>  >>  >>  +	desc->properties =3D usb_charger_properties;
>>  >>  >>  >>  +	desc->num_properties =3D=20
>> ARRAY_SIZE(usb_charger_properties);
>>  >>  >>  >>  +	desc->get_property =3D usb_charger_get_property;
>>  >>  >>  >>  +	desc->type =3D POWER_SUPPLY_TYPE_USB;
>>  >>  >>  >
>>  >>  >>  > What's your further plan for this generic USB charger?
>>  >>  >>  > To support BC1.2, we need to know charger type, and how we
>>  >> could  >> get  > it?
>>  >>  >>  >
>>  >>  >>  > Peter
>>  >>  >>
>>  >>  >>  Well I don't really know. The USB role framework does not=20
>> give
>>  >> any  >> info about  what's plugged.
>>  >>  >>
>>  >>  >
>>  >>  > What's the use case for this patch set? How it be used?
>>  >>
>>  >>  My devicetree:
>>  >>
>>  >>  usb_otg: usb@13440000 {
>>  >>  	compatible =3D "ingenic,jz4770-musb", "simple-mfd";
>>  >>  	reg =3D <0x13440000 0x10000>;
>>  >>  	[...]
>>  >>
>>  >>  	usb-role-switch;
>>  >>
>>  >>  	connector {
>>  >>  		compatible =3D "gpio-usb-b-connector", "usb-b-connector";
>>  >>  		label =3D "mini-USB";
>>  >>  		type =3D "mini";
>>  >>
>>  >>  		id-gpios =3D <&gpf 18 GPIO_ACTIVE_HIGH>;
>>  >>  		vbus-gpios =3D <&gpb 5 GPIO_ACTIVE_HIGH>;
>>  >>  		[...]
>>  >>  	};
>>  >>
>>  >>  	usb_charger: usb-charger {
>>  >>  		compatible =3D "usb-charger";
>>  >>  	};
>>  >>  };
>>  >>
>>  >>  The new gpio-usb-connector driver uses the ID/VBUS GPIOs to=20
>> detect
>>  >> in  which state (device, host, unconnected) a OTG connector is.
>>  >> However,  that means I cannot use the standard gpio-charger=20
>> driver to
>>  >> detect the  presence of a charger based on the state of the VBUS
>>  >> gpio, since it's  already requested here. So the point of this
>>  >> patchset is to provide an  alternative to gpio-charger that works
>>  >> with OTG controllers compatible  with 'usb-role-switch'.
>>  >>
>>  >
>>  > Thanks for explaining it.
>>  >
>>  > What's the user for this USB charger,  PMIC or what else? How the=20
>> user
>>  > uses this USB charger interface?
>>=20
>>  It's exported as a standard charger, so it can be passed to client=20
>> drivers through
>>  devicetree, and its online status can be retrieved from sysfs.
>>=20
>=20
> Hi Paul,
>=20
> If you would like to get role from usb-role-switch, the udc driver=20
> may probably have already worked.
> There is a 'state' entry under the udc device to indicate USB Ch9=20
> state. Try to see if it could
> satisfy your requirement.

This is not the proper way to retrieve charger status.
Linux supports chargers through the power supply subsystem, that's=20
where it should be exported.

Cheers,
-Paul

=