Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1956929ybl; Thu, 19 Dec 2019 05:51:51 -0800 (PST) X-Google-Smtp-Source: APXvYqw6ymIZRTF5ayvicxbFZFG8/K/p1dfFi/NcB+HBAbvmoqMTIN2tQDTD2sIartlhIqSCxIf3 X-Received: by 2002:a9d:58cb:: with SMTP id s11mr9245725oth.55.1576763511758; Thu, 19 Dec 2019 05:51:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576763511; cv=none; d=google.com; s=arc-20160816; b=uaNNjQimvMT40caJFqj9zMjGq/GCf6HM0iygIbWteh9A+eryMgmXzlvLYVYHTf97Gz YwxNYnUFH4OJZRdy0mJGU/z9wh/qKiS6e48kzbR8gIrNyw/CvXucTKiTSxgKE2xD5VhI 4iyTYdyXN/A84ocOA6TSr7LKt0U+nPkUNebEqMSOMme3ltg9SkCzR9kTKsNBOxebXqUt ute+OJf7+8m72uhSlvnKxgnFTnpeZUoZZ43Aw3CS34PnH8zDy/B2dpf2eeu5uyUKPCDU puGq+gyxcsHFG8/5i1Vgbuv7uKvtXhxbAjFNYXSqmg53Hv8/EADgus/0RUu1t74OHNrY 0w1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=9j5TghLBlC8vtEsHazQPr5eOQkZTvvYOCQUcaBPR/70=; b=RRof8+X2syqMxGBSdKjWf/vCjsKM0kAoAPI11YMIvRDzefOaPrLSqAnPJzszMuCTyc XJu9SEKbu7AacTYV9RT2WbC//AW0LRxiJXba9orvoDNyAoV0FYpBXP1B9hDqC80i2W9R G+X0NKsmnQ/RZ/0tjl9tPxlzth4uTIQkP8ptmCF2PTEwrY96uqsnPhpeIm2cOEbG/BNY hXHHo22yOithTgxga1OH309ISsSRA4UX8CvyWfS3T1wvUtFKOJO9wrgac7SrBSQYot6z Xa+Kgpo11dxZHindwJYq/yU0HEnUC9COPKeM4gM0IF5iTFIBJMxzOObrjYGm9K29YNKP Fsgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q16si3442588otk.226.2019.12.19.05.51.40; Thu, 19 Dec 2019 05:51:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726847AbfLSNuq (ORCPT + 99 others); Thu, 19 Dec 2019 08:50:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:43536 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726779AbfLSNup (ORCPT ); Thu, 19 Dec 2019 08:50:45 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6C9182467E; Thu, 19 Dec 2019 13:50:44 +0000 (UTC) Date: Thu, 19 Dec 2019 08:50:42 -0500 From: Steven Rostedt To: Kirill Tkhai Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC] sched: Micro optimization in pick_next_task() and in check_preempt_curr() Message-ID: <20191219085042.0a29437b@gandalf.local.home> In-Reply-To: <157675913272.349305.8936736338884044103.stgit@localhost.localdomain> References: <157675913272.349305.8936736338884044103.stgit@localhost.localdomain> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 Dec 2019 15:39:14 +0300 Kirill Tkhai wrote: > @@ -6569,6 +6558,11 @@ void __init sched_init(void) > unsigned long ptr = 0; > int i; > > + BUG_ON(&idle_sched_class > &fair_sched_class || > + &fair_sched_class > &rt_sched_class || > + &rt_sched_class > &dl_sched_class || > + &dl_sched_class > &stop_sched_class); > + Can this be a BUILD_BUG_ON? These address should all be constants. -- Steve > wait_bit_init(); >