Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 19 Dec 2019 14:53:50 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Kirill Tkhai <ktkhai@virtuozzo.com>, mingo@redhat.com,
        juri.lelli@redhat.com, vincent.guittot@linaro.org,
        dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] sched: Micro optimization in pick_next_task() and in
 check_preempt_curr()
Message-ID: <20191219135350.GA2844@hirez.programming.kicks-ass.net>
References: <157675913272.349305.8936736338884044103.stgit@localhost.localdomain>
 <20191219085042.0a29437b@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191219085042.0a29437b@gandalf.local.home>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Dec 19, 2019 at 08:50:42AM -0500, Steven Rostedt wrote:
> On Thu, 19 Dec 2019 15:39:14 +0300
> Kirill Tkhai <ktkhai@virtuozzo.com> wrote:
> 
> > @@ -6569,6 +6558,11 @@ void __init sched_init(void)
> >  	unsigned long ptr = 0;
> >  	int i;
> >  
> > +	BUG_ON(&idle_sched_class > &fair_sched_class ||
> > +		&fair_sched_class > &rt_sched_class ||
> > +		&rt_sched_class > &dl_sched_class ||
> > +		&dl_sched_class > &stop_sched_class);
> > +
> 
> Can this be a BUILD_BUG_ON? These address should all be constants.

Nope, BUILD_BUG_ON() is for compile time constants, these are link time
constants.